coreboot-gerrit March 2013

coreboot-gerrit@coreboot.org

1 participants
443 discussions

Patch merged into coreboot/master: 42f5513 armv7: fixes for dcache_op_by_mva()
by gerrit＠coreboot.org 26 Mar '13

26 Mar '13

the following patch was just integrated into master: commit 42f5513d3d09e50eee6279c401897f34b1eb0053 Author: David Hendricks <dhendrix(a)chromium.org> Date: Mon Mar 25 19:50:11 2013 -0700 armv7: fixes for dcache_op_by_mva() This fixes a couple issues with dcache_op_by_mva(): - Add missing data and instruction sync barriers. - Removes unneded -1 from loop terminating condition. Change-Id: I098388614397c1e53079c017d56b1cf3ef273676 Signed-off-by: David Hendricks <dhendrix(a)chromium.org> Reviewed-on: http://review.coreboot.org/2913 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> Build-Tested: build bot (Jenkins) at Tue Mar 26 05:10:12 2013, giving +1 Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Tue Mar 26 21:10:46 2013, giving +2 See http://review.coreboot.org/2913 for details. -gerrit

1 0

Patch merged into coreboot/master: 49675b9 ARMv7: Drop ROMSTAGE_BASE from Makefile.inc
by gerrit＠coreboot.org 26 Mar '13

26 Mar '13

the following patch was just integrated into master: commit 49675b950f2cbd40455dd1584ae8dfb50a1f3274 Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Tue Mar 26 11:28:47 2013 -0700 ARMv7: Drop ROMSTAGE_BASE from Makefile.inc It's not used (instead ARM puts it in Kconfig) Change-Id: Ia22a7ac756bec4cb6fee00a4d946a020ea6290aa Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-on: http://review.coreboot.org/2916 Reviewed-by: David Hendricks <dhendrix(a)chromium.org> Tested-by: build bot (Jenkins) Build-Tested: build bot (Jenkins) at Tue Mar 26 19:49:18 2013, giving +1 Reviewed-By: David Hendricks <dhendrix(a)chromium.org> at Tue Mar 26 19:30:54 2013, giving +2 See http://review.coreboot.org/2916 for details. -gerrit

1 0

Patch merged into coreboot/master: 0a527e7 libpayload: Fix prototype warnings in PDCurses
by gerrit＠coreboot.org 26 Mar '13

26 Mar '13

the following patch was just integrated into master: commit 0a527e7e5d3be94add22b654b74defd259f0ea76 Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Mon Mar 25 15:38:21 2013 -0700 libpayload: Fix prototype warnings in PDCurses This fixes the following PDCurses warnings: CC curses/pdcurses-backend/pdcsetsc.libcurses.o curses/pdcurses-backend/pdcsetsc.c: In function 'PDC_curs_set': curses/pdcurses-backend/pdcsetsc.c:17:9: warning: implicit declaration of function 'serial_cursor_enable' [-Wimplicit-function-declaration] curses/pdcurses-backend/pdcsetsc.c:22:9: warning: implicit declaration of function 'video_console_cursor_enable' [-Wimplicit-function-declaration] CC curses/pdcurses-backend/pdcutil.libcurses.o curses/pdcurses-backend/pdcutil.c:30:6: warning: no previous prototype for 'curses_enable_serial' [-Wmissing-prototypes] curses/pdcurses-backend/pdcutil.c:35:6: warning: no previous prototype for 'curses_enable_vga' [-Wmissing-prototypes] curses/pdcurses-backend/pdcutil.c:40:5: warning: function declaration isn't a prototype [-Wstrict-prototypes] curses/pdcurses-backend/pdcutil.c:45:5: warning: function declaration isn't a prototype [-Wstrict-prototypes] Change-Id: If0d4d475d3006f1a77f67ec46c6bdf4ee2906981 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-on: http://review.coreboot.org/2908 Reviewed-by: Dave Frodin <dave.frodin(a)se-eng.com> Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> Build-Tested: build bot (Jenkins) at Tue Mar 26 01:03:35 2013, giving +1 Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Tue Mar 26 19:37:33 2013, giving +2 See http://review.coreboot.org/2908 for details. -gerrit

1 0

Patch merged into coreboot/master: c7b6d7d libpayload: Fix type issues
by gerrit＠coreboot.org 26 Mar '13

26 Mar '13

the following patch was just integrated into master: commit c7b6d7db092cfd925f1fb6333e166a54663310e7 Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Mon Mar 25 15:03:41 2013 -0700 libpayload: Fix type issues There were a number of type issues in libpayload that sneaked in with 903f8e0. - size_t and ssize_t were conflicting with gcc builtins - some stdint types were used in libpayload but not defined in our stdint.h With this patch it's possible to compile libpayload with the reference toolchain again. Change-Id: Idd5ccfdd9f3536b36bceca2d101e7405883b10bc Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-on: http://review.coreboot.org/2903 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> Build-Tested: build bot (Jenkins) at Tue Mar 26 19:36:29 2013, giving +1 Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Tue Mar 26 19:36:33 2013, giving +2 See http://review.coreboot.org/2903 for details. -gerrit

1 0

Patch merged into coreboot/master: e21f5e1 libpayload: fix size_t handling
by gerrit＠coreboot.org 26 Mar '13

26 Mar '13

the following patch was just integrated into master: commit e21f5e14834af6426bd6fc3e7f37f6b18243f416 Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Mon Mar 25 15:13:20 2013 -0700 libpayload: fix size_t handling libcbfs was using printf for size_t typed variables. However, printf did not support printing those. This patch fixes the issue, removing the warning when compiling ram_media.c libcbfs/ram_media.c:52:10: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat] libcbfs/ram_media.c:52:10: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat] Change-Id: Iaf6e723f9a5b0a61a39d3125036fee9853e37ba8 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-on: http://review.coreboot.org/2904 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> Build-Tested: build bot (Jenkins) at Tue Mar 26 00:13:02 2013, giving +1 Reviewed-By: Ronald G. Minnich <rminnich(a)gmail.com> at Tue Mar 26 19:35:28 2013, giving +2 See http://review.coreboot.org/2904 for details. -gerrit

1 0

New patch to review for coreboot: 5d747b5 ARMv7: Drop ROMSTAGE_BASE from Makefile.inc
by Stefan Reinauer 26 Mar '13

26 Mar '13

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2916 -gerrit commit 5d747b5783806d3f8748f59d384b14fb21f8589e Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Tue Mar 26 11:28:47 2013 -0700 ARMv7: Drop ROMSTAGE_BASE from Makefile.inc It's not used (instead ARM puts it in Kconfig) Change-Id: Ia22a7ac756bec4cb6fee00a4d946a020ea6290aa Signed-off-by: Stefan Reinauer <reinauer(a)google.com> --- src/arch/armv7/Makefile.inc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/arch/armv7/Makefile.inc b/src/arch/armv7/Makefile.inc index 7873e61..dec0b3f 100644 --- a/src/arch/armv7/Makefile.inc +++ b/src/arch/armv7/Makefile.inc @@ -260,7 +260,6 @@ endif $(objgenerated)/romstage.ld: $$(ldscripts) $(obj)/ldoptions @printf " GEN $(subst $(obj)/,,$(@))\n" rm -f $@ - printf "ROMSTAGE_BASE = 0x0;\n" > $@.tmp printf '$(foreach ldscript,ldoptions $(ldscripts),INCLUDE "$(ldscript:$(obj)/%=%)"\n)' >> $@.tmp mv $@.tmp $@

1 0

Patch set updated for coreboot: 562acde libpayload: Fix type issues
by Stefan Reinauer 26 Mar '13

26 Mar '13

Stefan Reinauer (stefan.reinauer(a)coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2903 -gerrit commit 562acde7f29ad17c3c2d35e708960fa1ffd9644e Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Mon Mar 25 15:03:41 2013 -0700 libpayload: Fix type issues There were a number of type issues in libpayload that sneaked in with 903f8e0. - size_t and ssize_t were conflicting with gcc builtins - some stdint types were used in libpayload but not defined in our stdint.h With this patch it's possible to compile libpayload with the reference toolchain again. Change-Id: Idd5ccfdd9f3536b36bceca2d101e7405883b10bc Signed-off-by: Stefan Reinauer <reinauer(a)google.com> --- payloads/libpayload/include/armv7/arch/types.h | 4 ++-- payloads/libpayload/include/stdint.h | 8 ++++++++ payloads/libpayload/include/x86/arch/types.h | 4 ++-- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/payloads/libpayload/include/armv7/arch/types.h b/payloads/libpayload/include/armv7/arch/types.h index d6f4aa8..bb40257 100644 --- a/payloads/libpayload/include/armv7/arch/types.h +++ b/payloads/libpayload/include/armv7/arch/types.h @@ -53,8 +53,8 @@ typedef signed long long s64; typedef long time_t; typedef long suseconds_t; -typedef unsigned int size_t; -typedef int ssize_t; +typedef unsigned long size_t; +typedef long ssize_t; #ifndef NULL #define NULL ((void *)0) diff --git a/payloads/libpayload/include/stdint.h b/payloads/libpayload/include/stdint.h index dd7439d..966a1ed 100644 --- a/payloads/libpayload/include/stdint.h +++ b/payloads/libpayload/include/stdint.h @@ -29,8 +29,16 @@ #ifndef __STDINT_H #define __STDINT_H + #include <arch/types.h> +typedef long long int intmax_t; +typedef unsigned long long uintmax_t; + typedef unsigned long uintptr_t; typedef long intptr_t; + +#define UINT32_MAX (4294967295U) +#define UINT64_MAX (18446744073709551615ULL) + #endif diff --git a/payloads/libpayload/include/x86/arch/types.h b/payloads/libpayload/include/x86/arch/types.h index d6f4aa8..bb40257 100644 --- a/payloads/libpayload/include/x86/arch/types.h +++ b/payloads/libpayload/include/x86/arch/types.h @@ -53,8 +53,8 @@ typedef signed long long s64; typedef long time_t; typedef long suseconds_t; -typedef unsigned int size_t; -typedef int ssize_t; +typedef unsigned long size_t; +typedef long ssize_t; #ifndef NULL #define NULL ((void *)0)

1 0

Patch merged into coreboot/master: a6c495e libpayload: Fix const warnings in keyname() and termname()
by gerrit＠coreboot.org 26 Mar '13

26 Mar '13

the following patch was just integrated into master: commit a6c495edcaaade187280262db1bbce887fa28003 Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Mon Mar 25 15:15:16 2013 -0700 libpayload: Fix const warnings in keyname() and termname() The keyname() and termname() functions were creating a whole lot of warnings of the style curses/PDCurses-3.4/pdcurses/keyname.c:41:9: warning: initialization discards 'const' qualifier from pointer target type [enabled by default] This patch fixes them. Change-Id: Iae3c4e5201b48c2d2033cac48577e0462a34f309 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-on: http://review.coreboot.org/2905 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Build-Tested: build bot (Jenkins) at Tue Mar 26 00:25:03 2013, giving +1 See http://review.coreboot.org/2905 for details. -gerrit

1 0

Patch merged into coreboot/master: 8d225f1 libpayload: Fix variable shadowing in PDCurses
by gerrit＠coreboot.org 26 Mar '13

26 Mar '13

the following patch was just integrated into master: commit 8d225f141d45e3eba5bb39973e4889e884d9a64f Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Mon Mar 25 15:30:30 2013 -0700 libpayload: Fix variable shadowing in PDCurses PDCurses has a function called overlay() and also uses overlay as a variable name in some functions. This patch fixes the ambiguity that caused warnings like curses/PDCurses-3.4/pdcurses/overlay.c: In function '_copy_win': curses/PDCurses-3.4/pdcurses/overlay.c:51:39: warning: declaration of 'overlay' shadows a global declaration [-Wshadow] In file included from curses/PDCurses-3.4/curspriv.h:16:0, from curses/PDCurses-3.4/pdcurses/overlay.c:3: curses/PDCurses-3.4/curses.h:1014:9: warning: shadowed declaration is here [-Wshadow] Change-Id: I907653df0c8bb32c98bdcbc6476e94d2da6e0e90 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-on: http://review.coreboot.org/2906 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Build-Tested: build bot (Jenkins) at Tue Mar 26 00:38:07 2013, giving +1 See http://review.coreboot.org/2906 for details. -gerrit

1 0

Patch merged into coreboot/master: 0fef4fe libpayload: Fix missing prototype warning for Xinitscr()
by gerrit＠coreboot.org 26 Mar '13

26 Mar '13

the following patch was just integrated into master: commit 0fef4fe61ba4a6775fa8ab671212bf0acc9a8adf Author: Stefan Reinauer <reinauer(a)chromium.org> Date: Mon Mar 25 15:32:25 2013 -0700 libpayload: Fix missing prototype warning for Xinitscr() Xinitscr is only used internally in PDCurses, unless XCURSES is defined. This patch fixes a warning that is produced because of that. Change-Id: I211f75717276cf028e0b435f328d1687d3536eb7 Signed-off-by: Stefan Reinauer <reinauer(a)google.com> Reviewed-on: http://review.coreboot.org/2907 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Build-Tested: build bot (Jenkins) at Tue Mar 26 00:50:41 2013, giving +1 See http://review.coreboot.org/2907 for details. -gerrit

1 0

← Newer
1
...
22
23
24
25
26
27
28
...
45
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2013