coreboot-gerrit November 2013

coreboot-gerrit@coreboot.org

1 participants
856 discussions

New patch to review for coreboot: 7b9517b arch/x86/acpi/globutil.asl: Make control method `S2BF` serialized
by Paul Menzel 18 Nov '13

18 Nov '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4093 -gerrit commit 7b9517b41ebf8fac9df0304b373d1d06adc6fd62 Author: Paul Menzel <paulepanter(a)users.sourceforge.net> Date: Mon Nov 18 11:57:45 2013 +0100 arch/x86/acpi/globutil.asl: Make control method `S2BF` serialized The ASL Optimizing Compiler version 20130517-64 issues the following warning when building for example AMD Parmer and ASRock E350M1. IASL coreboot-builds/amd_parmer/mainboard/amd/parmer/dsdt.ramstage.o dsdt.ramstage.asl 196: Method(S2BF, 1) Remark 2120 - ^ Control Method should be made Serialized (due to creation of named objects within) Intel ACPI Component Architecture ASL Optimizing Compiler version 20130517-64 Copyright (c) 2000 - 2013 Intel Corporation ASL Input: dsdt.ramstage.asl - 1164 lines, 23047 bytes, 547 keywords AML Output: dsdt.ramstage.aml - 6898 bytes, 305 named objects, 242 executable opcodes Hex Dump: dsdt.ramstage.hex - 65007 bytes Compilation complete. 0 Errors, 0 Warnings, 1 Remarks, 347 Optimizations Taking the advice and making the control method serialized, as expected, the remark is gone and there are no size changes. The remark was added in ACPICA version 20130517 [1] and gives the following explanation. If a thread blocks within the method for any reason, and another thread enters the method, the method will fail because an attempt will be made to create the same (named) object twice. In this case, issue a remark that the method should be marked serialized. ACPICA BZ 909. [1] https://github.com/acpica/acpica/commit/ba84d0fc18ba910a47a3f71c68a43543c06… iASL: If a non-serialized method creates named objects, issue remark. Change-Id: I502cca731b6b4cd3e17c57fc191f1eed10a5a1fe Signed-off-by: Paul Menzel <paulepanter(a)users.sourceforge.net> --- src/arch/x86/acpi/globutil.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/arch/x86/acpi/globutil.asl b/src/arch/x86/acpi/globutil.asl index b39113f..a39d6ed 100644 --- a/src/arch/x86/acpi/globutil.asl +++ b/src/arch/x86/acpi/globutil.asl @@ -39,7 +39,7 @@ Method(SLEN, 1) Return(Sizeof(Local0)) } -Method(S2BF, 1) +Method(S2BF, 1, Serialized) { Add(SLEN(Arg0), One, Local0) Name(BUFF, Buffer(Local0) {})

1 0

Patch set updated for coreboot: bc7c722 AMD f15tn, f16kb: Remove CDIT table and DMI table
by Paul Menzel 18 Nov '13

18 Nov '13

Paul Menzel (paulepanter(a)users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4092 -gerrit commit bc7c72226030545422dd612a1ea5e2f9de6d5f34 Author: WANG Siyuan <wangsiyuanbuaa(a)gmail.com> Date: Mon Nov 18 10:34:06 2013 +0800 AMD f15tn, f16kb: Remove CDIT table and DMI table On AMD Trinity and Kabini boards errors similar to the following are shown. ASSERTION FAILED: file 'src/mainboard/asrock/imb-a180/agesawrapper.c',line 431 DmiTable:100123f7, AcpiPstatein: 10010129,AcpiSrat:0,AcpiSlit:0, Mce:10010de9,Cmc:10010eab,Alib:1002111c, AcpiIvrs:0 in agesawrapper_amdinitlate agesawrapper_amdinitlate failed: 5 The reason is that on f16kb boards, the CDIT and DMI table are not created. On f15tn boards, only the DMI table is not created. Until the root cause is found, disable the table generation to remove the errors. Thanks to Wei Hu for debugging and reporting this issue on the list [1]. [1] http://www.coreboot.org/pipermail/coreboot/2013-November/076607.html CDIT table is not created Change-Id: I837e3c322bb5331a9b950a72397796a60642c3f3 Signed-off-by: WANG Siyuan <SiYuan.Wang(a)amd.com> Signed-off-by: WANG Siyuan <wangsiyuanbuaa(a)gmail.com> --- src/mainboard/amd/olivehill/agesawrapper.c | 1 - src/mainboard/amd/olivehill/buildOpts.c | 3 ++- src/mainboard/amd/parmer/agesawrapper.c | 1 - src/mainboard/amd/parmer/buildOpts.c | 2 +- src/mainboard/amd/thatcher/agesawrapper.c | 1 - src/mainboard/amd/thatcher/buildOpts.c | 2 +- src/mainboard/asrock/imb-a180/agesawrapper.c | 1 - src/mainboard/asrock/imb-a180/buildOpts.c | 3 ++- src/mainboard/asus/f2a85-m/agesawrapper.c | 1 - src/mainboard/asus/f2a85-m/buildOpts.c | 2 +- 10 files changed, 7 insertions(+), 10 deletions(-) diff --git a/src/mainboard/amd/olivehill/agesawrapper.c b/src/mainboard/amd/olivehill/agesawrapper.c index f0ad493..8300e34 100644 --- a/src/mainboard/amd/olivehill/agesawrapper.c +++ b/src/mainboard/amd/olivehill/agesawrapper.c @@ -427,7 +427,6 @@ agesawrapper_amdinitlate ( AmdCreateStruct(&AmdParamStruct); AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr; Status = AmdInitLate(AmdLateParams); - /* CDIT table is not created. */ if (Status != AGESA_SUCCESS) { agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus); ASSERT(Status == AGESA_SUCCESS); diff --git a/src/mainboard/amd/olivehill/buildOpts.c b/src/mainboard/amd/olivehill/buildOpts.c index 0528315..ae7f5e9 100644 --- a/src/mainboard/amd/olivehill/buildOpts.c +++ b/src/mainboard/amd/olivehill/buildOpts.c @@ -77,7 +77,8 @@ #define BLDOPT_REMOVE_SLIT FALSE //TRUE #define BLDOPT_REMOVE_WHEA FALSE //TRUE #define BLDOPT_REMOVE_CRAT TRUE -//#define BLDOPT_REMOVE_DMI FALSE //TRUE +#define BLDOPT_REMOVE_CDIT TRUE +#define BLDOPT_REMOVE_DMI TRUE //#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE //#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE //#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE diff --git a/src/mainboard/amd/parmer/agesawrapper.c b/src/mainboard/amd/parmer/agesawrapper.c index 013df13..fcbdded 100644 --- a/src/mainboard/amd/parmer/agesawrapper.c +++ b/src/mainboard/amd/parmer/agesawrapper.c @@ -427,7 +427,6 @@ agesawrapper_amdinitlate ( AmdCreateStruct(&AmdParamStruct); AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr; Status = AmdInitLate(AmdLateParams); - /* CDIT table is not created. */ if (Status != AGESA_SUCCESS) { agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus); ASSERT(Status == AGESA_SUCCESS); diff --git a/src/mainboard/amd/parmer/buildOpts.c b/src/mainboard/amd/parmer/buildOpts.c index d022ae7..1a23190 100644 --- a/src/mainboard/amd/parmer/buildOpts.c +++ b/src/mainboard/amd/parmer/buildOpts.c @@ -74,7 +74,7 @@ #define BLDOPT_REMOVE_SLIT FALSE //TRUE #define BLDOPT_REMOVE_WHEA FALSE //TRUE #define BLDOPT_REMOVE_CRAT TRUE -//#define BLDOPT_REMOVE_DMI FALSE //TRUE +#define BLDOPT_REMOVE_DMI TRUE //#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE //#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE //#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE diff --git a/src/mainboard/amd/thatcher/agesawrapper.c b/src/mainboard/amd/thatcher/agesawrapper.c index 6b71ef64..6331197 100644 --- a/src/mainboard/amd/thatcher/agesawrapper.c +++ b/src/mainboard/amd/thatcher/agesawrapper.c @@ -425,7 +425,6 @@ agesawrapper_amdinitlate ( AmdCreateStruct(&AmdParamStruct); AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr; Status = AmdInitLate(AmdLateParams); - /* CDIT table is not created. */ if (Status != AGESA_SUCCESS) { agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus); ASSERT(Status == AGESA_SUCCESS); diff --git a/src/mainboard/amd/thatcher/buildOpts.c b/src/mainboard/amd/thatcher/buildOpts.c index aace5fd..87f0460 100644 --- a/src/mainboard/amd/thatcher/buildOpts.c +++ b/src/mainboard/amd/thatcher/buildOpts.c @@ -74,7 +74,7 @@ #define BLDOPT_REMOVE_SLIT FALSE //TRUE #define BLDOPT_REMOVE_WHEA FALSE //TRUE #define BLDOPT_REMOVE_CRAT TRUE -//#define BLDOPT_REMOVE_DMI FALSE //TRUE +#define BLDOPT_REMOVE_DMI TRUE //#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE //#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE //#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE diff --git a/src/mainboard/asrock/imb-a180/agesawrapper.c b/src/mainboard/asrock/imb-a180/agesawrapper.c index f0ad493..8300e34 100644 --- a/src/mainboard/asrock/imb-a180/agesawrapper.c +++ b/src/mainboard/asrock/imb-a180/agesawrapper.c @@ -427,7 +427,6 @@ agesawrapper_amdinitlate ( AmdCreateStruct(&AmdParamStruct); AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr; Status = AmdInitLate(AmdLateParams); - /* CDIT table is not created. */ if (Status != AGESA_SUCCESS) { agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus); ASSERT(Status == AGESA_SUCCESS); diff --git a/src/mainboard/asrock/imb-a180/buildOpts.c b/src/mainboard/asrock/imb-a180/buildOpts.c index d0aae25..7c57183 100644 --- a/src/mainboard/asrock/imb-a180/buildOpts.c +++ b/src/mainboard/asrock/imb-a180/buildOpts.c @@ -77,7 +77,8 @@ #define BLDOPT_REMOVE_SLIT FALSE //TRUE #define BLDOPT_REMOVE_WHEA FALSE //TRUE #define BLDOPT_REMOVE_CRAT TRUE -//#define BLDOPT_REMOVE_DMI FALSE //TRUE +#define BLDOPT_REMOVE_CDIT TRUE +#define BLDOPT_REMOVE_DMI TRUE //#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE //#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE //#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE diff --git a/src/mainboard/asus/f2a85-m/agesawrapper.c b/src/mainboard/asus/f2a85-m/agesawrapper.c index b1d6279..529878b 100644 --- a/src/mainboard/asus/f2a85-m/agesawrapper.c +++ b/src/mainboard/asus/f2a85-m/agesawrapper.c @@ -427,7 +427,6 @@ agesawrapper_amdinitlate ( AmdCreateStruct(&AmdParamStruct); AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr; Status = AmdInitLate(AmdLateParams); - /* CDIT table is not created. */ if (Status != AGESA_SUCCESS) { agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus); ASSERT(Status == AGESA_SUCCESS); diff --git a/src/mainboard/asus/f2a85-m/buildOpts.c b/src/mainboard/asus/f2a85-m/buildOpts.c index 7f893f9..0091cd9 100644 --- a/src/mainboard/asus/f2a85-m/buildOpts.c +++ b/src/mainboard/asus/f2a85-m/buildOpts.c @@ -75,7 +75,7 @@ #define BLDOPT_REMOVE_SLIT FALSE //TRUE #define BLDOPT_REMOVE_WHEA FALSE //TRUE #define BLDOPT_REMOVE_CRAT TRUE -//#define BLDOPT_REMOVE_DMI FALSE //TRUE +#define BLDOPT_REMOVE_DMI TRUE //#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE //#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE //#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE

1 0

Patch set updated for coreboot: 631d96e Remove CDIT table and DMI table of AMD f15tn and f16kb boards
by WANG Siyuan 18 Nov '13

18 Nov '13

WANG Siyuan (wangsiyuanbuaa(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4092 -gerrit commit 631d96e264458ead7c19ecdab95dd107bab24033 Author: WANG Siyuan <wangsiyuanbuaa(a)gmail.com> Date: Mon Nov 18 10:34:06 2013 +0800 Remove CDIT table and DMI table of AMD f15tn and f16kb boards There is such kind error: ASSERTION FAILED: file 'src/mainboard/asrock/imb-a180/agesawrapper.c',line 431 DmiTable:100123f7, AcpiPstatein: 10010129,AcpiSrat:0,AcpiSlit:0, Mce:10010de9,Cmc:10010eab,Alib:1002111c, AcpiIvrs:0 in agesawrapper_amdinitlate agesawrapper_amdinitlate failed: 5 On f16kb boards, CDIT table and DMI table are failed to created. On f15tn boards, DMI table is failed to created. We remove these tow tables before we find the root cause. Thank Wei Hu for debugging and founding this issue. Change-Id: I837e3c322bb5331a9b950a72397796a60642c3f3 Signed-off-by: WANG Siyuan <SiYuan.Wang(a)amd.com> Signed-off-by: WANG Siyuan <wangsiyuanbuaa(a)gmail.com> --- src/mainboard/amd/olivehill/agesawrapper.c | 1 - src/mainboard/amd/olivehill/buildOpts.c | 3 ++- src/mainboard/amd/parmer/agesawrapper.c | 1 - src/mainboard/amd/parmer/buildOpts.c | 2 +- src/mainboard/amd/thatcher/agesawrapper.c | 1 - src/mainboard/amd/thatcher/buildOpts.c | 2 +- src/mainboard/asrock/imb-a180/agesawrapper.c | 1 - src/mainboard/asrock/imb-a180/buildOpts.c | 3 ++- src/mainboard/asus/f2a85-m/agesawrapper.c | 1 - src/mainboard/asus/f2a85-m/buildOpts.c | 2 +- 10 files changed, 7 insertions(+), 10 deletions(-) diff --git a/src/mainboard/amd/olivehill/agesawrapper.c b/src/mainboard/amd/olivehill/agesawrapper.c index f0ad493..8300e34 100644 --- a/src/mainboard/amd/olivehill/agesawrapper.c +++ b/src/mainboard/amd/olivehill/agesawrapper.c @@ -427,7 +427,6 @@ agesawrapper_amdinitlate ( AmdCreateStruct(&AmdParamStruct); AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr; Status = AmdInitLate(AmdLateParams); - /* CDIT table is not created. */ if (Status != AGESA_SUCCESS) { agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus); ASSERT(Status == AGESA_SUCCESS); diff --git a/src/mainboard/amd/olivehill/buildOpts.c b/src/mainboard/amd/olivehill/buildOpts.c index 0528315..ae7f5e9 100644 --- a/src/mainboard/amd/olivehill/buildOpts.c +++ b/src/mainboard/amd/olivehill/buildOpts.c @@ -77,7 +77,8 @@ #define BLDOPT_REMOVE_SLIT FALSE //TRUE #define BLDOPT_REMOVE_WHEA FALSE //TRUE #define BLDOPT_REMOVE_CRAT TRUE -//#define BLDOPT_REMOVE_DMI FALSE //TRUE +#define BLDOPT_REMOVE_CDIT TRUE +#define BLDOPT_REMOVE_DMI TRUE //#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE //#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE //#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE diff --git a/src/mainboard/amd/parmer/agesawrapper.c b/src/mainboard/amd/parmer/agesawrapper.c index 013df13..fcbdded 100644 --- a/src/mainboard/amd/parmer/agesawrapper.c +++ b/src/mainboard/amd/parmer/agesawrapper.c @@ -427,7 +427,6 @@ agesawrapper_amdinitlate ( AmdCreateStruct(&AmdParamStruct); AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr; Status = AmdInitLate(AmdLateParams); - /* CDIT table is not created. */ if (Status != AGESA_SUCCESS) { agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus); ASSERT(Status == AGESA_SUCCESS); diff --git a/src/mainboard/amd/parmer/buildOpts.c b/src/mainboard/amd/parmer/buildOpts.c index d022ae7..1a23190 100644 --- a/src/mainboard/amd/parmer/buildOpts.c +++ b/src/mainboard/amd/parmer/buildOpts.c @@ -74,7 +74,7 @@ #define BLDOPT_REMOVE_SLIT FALSE //TRUE #define BLDOPT_REMOVE_WHEA FALSE //TRUE #define BLDOPT_REMOVE_CRAT TRUE -//#define BLDOPT_REMOVE_DMI FALSE //TRUE +#define BLDOPT_REMOVE_DMI TRUE //#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE //#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE //#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE diff --git a/src/mainboard/amd/thatcher/agesawrapper.c b/src/mainboard/amd/thatcher/agesawrapper.c index 6b71ef64..6331197 100644 --- a/src/mainboard/amd/thatcher/agesawrapper.c +++ b/src/mainboard/amd/thatcher/agesawrapper.c @@ -425,7 +425,6 @@ agesawrapper_amdinitlate ( AmdCreateStruct(&AmdParamStruct); AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr; Status = AmdInitLate(AmdLateParams); - /* CDIT table is not created. */ if (Status != AGESA_SUCCESS) { agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus); ASSERT(Status == AGESA_SUCCESS); diff --git a/src/mainboard/amd/thatcher/buildOpts.c b/src/mainboard/amd/thatcher/buildOpts.c index aace5fd..87f0460 100644 --- a/src/mainboard/amd/thatcher/buildOpts.c +++ b/src/mainboard/amd/thatcher/buildOpts.c @@ -74,7 +74,7 @@ #define BLDOPT_REMOVE_SLIT FALSE //TRUE #define BLDOPT_REMOVE_WHEA FALSE //TRUE #define BLDOPT_REMOVE_CRAT TRUE -//#define BLDOPT_REMOVE_DMI FALSE //TRUE +#define BLDOPT_REMOVE_DMI TRUE //#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE //#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE //#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE diff --git a/src/mainboard/asrock/imb-a180/agesawrapper.c b/src/mainboard/asrock/imb-a180/agesawrapper.c index f0ad493..8300e34 100644 --- a/src/mainboard/asrock/imb-a180/agesawrapper.c +++ b/src/mainboard/asrock/imb-a180/agesawrapper.c @@ -427,7 +427,6 @@ agesawrapper_amdinitlate ( AmdCreateStruct(&AmdParamStruct); AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr; Status = AmdInitLate(AmdLateParams); - /* CDIT table is not created. */ if (Status != AGESA_SUCCESS) { agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus); ASSERT(Status == AGESA_SUCCESS); diff --git a/src/mainboard/asrock/imb-a180/buildOpts.c b/src/mainboard/asrock/imb-a180/buildOpts.c index d0aae25..7c57183 100644 --- a/src/mainboard/asrock/imb-a180/buildOpts.c +++ b/src/mainboard/asrock/imb-a180/buildOpts.c @@ -77,7 +77,8 @@ #define BLDOPT_REMOVE_SLIT FALSE //TRUE #define BLDOPT_REMOVE_WHEA FALSE //TRUE #define BLDOPT_REMOVE_CRAT TRUE -//#define BLDOPT_REMOVE_DMI FALSE //TRUE +#define BLDOPT_REMOVE_CDIT TRUE +#define BLDOPT_REMOVE_DMI TRUE //#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE //#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE //#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE diff --git a/src/mainboard/asus/f2a85-m/agesawrapper.c b/src/mainboard/asus/f2a85-m/agesawrapper.c index b1d6279..529878b 100644 --- a/src/mainboard/asus/f2a85-m/agesawrapper.c +++ b/src/mainboard/asus/f2a85-m/agesawrapper.c @@ -427,7 +427,6 @@ agesawrapper_amdinitlate ( AmdCreateStruct(&AmdParamStruct); AmdLateParams = (AMD_LATE_PARAMS *)AmdParamStruct.NewStructPtr; Status = AmdInitLate(AmdLateParams); - /* CDIT table is not created. */ if (Status != AGESA_SUCCESS) { agesawrapper_amdreadeventlog(AmdLateParams->StdHeader.HeapStatus); ASSERT(Status == AGESA_SUCCESS); diff --git a/src/mainboard/asus/f2a85-m/buildOpts.c b/src/mainboard/asus/f2a85-m/buildOpts.c index 7f893f9..0091cd9 100644 --- a/src/mainboard/asus/f2a85-m/buildOpts.c +++ b/src/mainboard/asus/f2a85-m/buildOpts.c @@ -75,7 +75,7 @@ #define BLDOPT_REMOVE_SLIT FALSE //TRUE #define BLDOPT_REMOVE_WHEA FALSE //TRUE #define BLDOPT_REMOVE_CRAT TRUE -//#define BLDOPT_REMOVE_DMI FALSE //TRUE +#define BLDOPT_REMOVE_DMI TRUE //#define BLDOPT_REMOVE_EARLY_SAMPLES FALSE //#define BLDCFG_REMOVE_ACPI_PSTATES_PPC TRUE //#define BLDCFG_REMOVE_ACPI_PSTATES_PCT TRUE

1 0

New patch to review for coreboot: ab64330 Remove CDIT table and DMI table of AMD f15tn and f16kb boards
by WANG Siyuan 18 Nov '13

18 Nov '13

WANG Siyuan (wangsiyuanbuaa(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4092 -gerrit commit ab64330dfa0d01129e4024c7fe46770f7480a1e2 Author: WANG Siyuan <wangsiyuanbuaa(a)gmail.com> Date: Mon Nov 18 10:34:06 2013 +0800 Remove CDIT table and DMI table of AMD f15tn and f16kb boards There is such kind error: ASSERTION FAILED: file 'src/mainboard/asrock/imb-a180/agesawrapper.c',line 431 DmiTable:100123f7, AcpiPstatein: 10010129,AcpiSrat:0,AcpiSlit:0, Mce:10010de9,Cmc:10010eab,Alib:1002111c, AcpiIvrs:0 in agesawrapper_amdinitlate agesawrapper_amdinitlate failed: 5 On f16kb boards, CDIT table and DMI table are failed to created. On f15tn boards, DMI table is failed to created. We remove these tow tables before we find the root cause. Thank Wei Hu for debugging and founding this issue. Change-Id: I837e3c322bb5331a9b950a72397796a60642c3f3 Signed-off-by: WANG Siyuan <SiYuan.Wang(a)amd.com> Signed-off-by: WANG Siyuan <wangsiyuanbuaa(a)gmail.com> --- src/mainboard/amd/olivehill/buildOpts.c | 4 ++++ src/mainboard/amd/parmer/buildOpts.c | 3 +++ src/mainboard/amd/thatcher/buildOpts.c | 3 +++ src/mainboard/asrock/imb-a180/buildOpts.c | 4 ++++ src/mainboard/asus/f2a85-m/buildOpts.c | 3 +++ 5 files changed, 17 insertions(+) diff --git a/src/mainboard/amd/olivehill/buildOpts.c b/src/mainboard/amd/olivehill/buildOpts.c index 0528315..634cb32 100644 --- a/src/mainboard/amd/olivehill/buildOpts.c +++ b/src/mainboard/amd/olivehill/buildOpts.c @@ -61,6 +61,10 @@ #endif #endif +/* remove CDIT and DMI table */ +#define BLDOPT_REMOVE_CDIT TRUE +#define BLDOPT_REMOVE_DMI TRUE + //#define BLDOPT_REMOVE_UDIMMS_SUPPORT TRUE //#define BLDOPT_REMOVE_RDIMMS_SUPPORT TRUE #define BLDOPT_REMOVE_LRDIMMS_SUPPORT TRUE diff --git a/src/mainboard/amd/parmer/buildOpts.c b/src/mainboard/amd/parmer/buildOpts.c index d022ae7..9c4d17d 100644 --- a/src/mainboard/amd/parmer/buildOpts.c +++ b/src/mainboard/amd/parmer/buildOpts.c @@ -58,6 +58,9 @@ #define INSTALL_FM2_SOCKET_SUPPORT FALSE +/* remove DMI table */ +#define BLDOPT_REMOVE_DMI TRUE + //#define BLDOPT_REMOVE_UDIMMS_SUPPORT TRUE //#define BLDOPT_REMOVE_RDIMMS_SUPPORT TRUE #define BLDOPT_REMOVE_LRDIMMS_SUPPORT TRUE diff --git a/src/mainboard/amd/thatcher/buildOpts.c b/src/mainboard/amd/thatcher/buildOpts.c index aace5fd..fb709df 100644 --- a/src/mainboard/amd/thatcher/buildOpts.c +++ b/src/mainboard/amd/thatcher/buildOpts.c @@ -58,6 +58,9 @@ #define INSTALL_FM2_SOCKET_SUPPORT FALSE +/* remove DMI table */ +#define BLDOPT_REMOVE_DMI TRUE + //#define BLDOPT_REMOVE_UDIMMS_SUPPORT TRUE //#define BLDOPT_REMOVE_RDIMMS_SUPPORT TRUE #define BLDOPT_REMOVE_LRDIMMS_SUPPORT TRUE diff --git a/src/mainboard/asrock/imb-a180/buildOpts.c b/src/mainboard/asrock/imb-a180/buildOpts.c index d0aae25..965c3d1 100644 --- a/src/mainboard/asrock/imb-a180/buildOpts.c +++ b/src/mainboard/asrock/imb-a180/buildOpts.c @@ -61,6 +61,10 @@ #endif #endif +/* remove CDIT and DMI table */ +#define BLDOPT_REMOVE_CDIT TRUE +#define BLDOPT_REMOVE_DMI TRUE + //#define BLDOPT_REMOVE_UDIMMS_SUPPORT TRUE //#define BLDOPT_REMOVE_RDIMMS_SUPPORT TRUE #define BLDOPT_REMOVE_LRDIMMS_SUPPORT TRUE diff --git a/src/mainboard/asus/f2a85-m/buildOpts.c b/src/mainboard/asus/f2a85-m/buildOpts.c index 7f893f9..5e2de39 100644 --- a/src/mainboard/asus/f2a85-m/buildOpts.c +++ b/src/mainboard/asus/f2a85-m/buildOpts.c @@ -58,6 +58,9 @@ #define INSTALL_FM2_SOCKET_SUPPORT TRUE +/* remove DMI table */ +#define BLDOPT_REMOVE_DMI TRUE + //#define BLDOPT_REMOVE_UDIMMS_SUPPORT TRUE #define BLDOPT_REMOVE_SODIMMS_SUPPORT TRUE #define BLDOPT_REMOVE_RDIMMS_SUPPORT TRUE

1 0

New patch to review for coreboot: 05373f6 cbfstool: add a constant for the aarch64
by Ronald G. Minnich 17 Nov '13

17 Nov '13

Ronald G. Minnich (rminnich(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4091 -gerrit commit 05373f66cb27fa84fe9808c39c59f95e5bc81ace Author: Ronald G. Minnich <rminnich(a)google.com> Date: Sun Nov 17 13:49:42 2013 -0800 cbfstool: add a constant for the aarch64 Change-Id: Ide2c8b778447de66d95bd8c55b378aa2051ac2a0 Signed-off-by: Ronald G. Minnich <rminnich(a)google.com> --- util/cbfstool/elf.h | 1 + 1 file changed, 1 insertion(+) diff --git a/util/cbfstool/elf.h b/util/cbfstool/elf.h index 01af819..9ec8c16 100644 --- a/util/cbfstool/elf.h +++ b/util/cbfstool/elf.h @@ -243,6 +243,7 @@ typedef struct #define EM_ARC_A5 93 /* ARC Cores Tangent-A5 */ #define EM_XTENSA 94 /* Tensilica Xtensa Architecture */ #define EM_NUM 95 +#define EM_AARCH64 183 /* ARM AARCH64 */ /* If it is necessary to assign new unofficial EM_* values, please pick large random numbers (0x8523, 0xa7f2, etc.) to minimize the

1 0

New patch to review for coreboot: 64f7858 cbfs: remove unused code and prototype
by Ronald G. Minnich 17 Nov '13

17 Nov '13

Ronald G. Minnich (rminnich(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4090 -gerrit commit 64f78585f2e0921a689e585d189d157735491143 Author: Ronald G. Minnich <rminnich(a)google.com> Date: Sun Nov 17 11:07:25 2013 -0800 cbfs: remove unused code and prototype The code is wrong (it's calling ntohl on an entry point that is actually already le due to an old cbfs bug) and nothing calls it any more anyway. Change-Id: Ief2c33faf99e3d2fc410524a5aae7bde378f088b Signed-off-by: Ronald G. Minnich <rminnich(a)google.com> --- src/include/cbfs.h | 1 - src/lib/cbfs.c | 19 ------------------- 2 files changed, 20 deletions(-) diff --git a/src/include/cbfs.h b/src/include/cbfs.h index c0098ea..c05566d 100644 --- a/src/include/cbfs.h +++ b/src/include/cbfs.h @@ -52,7 +52,6 @@ #include <cbfs_core.h> -int cbfs_execute_stage(struct cbfs_media *media, const char *name); void *cbfs_load_optionrom(struct cbfs_media *media, uint16_t vendor, uint16_t device, void * dest); void *cbfs_load_payload(struct cbfs_media *media, const char *name); diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c index 4ccc9e6..23e1600 100644 --- a/src/lib/cbfs.c +++ b/src/lib/cbfs.c @@ -292,25 +292,6 @@ void * cbfs_load_stage(struct cbfs_media *media, const char *name) } #endif /* CONFIG_RELOCATABLE_RAMSTAGE */ -int cbfs_execute_stage(struct cbfs_media *media, const char *name) -{ - struct cbfs_stage *stage = (struct cbfs_stage *) - cbfs_get_file_content(media, name, CBFS_TYPE_STAGE); - - if (stage == NULL) - return 1; - - if (ntohl(stage->compression) != CBFS_COMPRESS_NONE) { - LOG("Unable to run %s: Compressed file" - "Not supported for in-place execution\n", name); - return 1; - } - - /* FIXME: This isn't right */ - LOG("run @ %p\n", (void *) ntohl((uint32_t) stage->entry)); - return run_address((void *)(uintptr_t)ntohll(stage->entry)); -} - #if !CONFIG_ALT_CBFS_LOAD_PAYLOAD void *cbfs_load_payload(struct cbfs_media *media, const char *name) {

1 0

Patch set updated for coreboot: 8a8d82f cbfs: 64-bit cleanups
by Ronald G. Minnich 17 Nov '13

17 Nov '13

Ronald G. Minnich (rminnich(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4037 -gerrit commit 8a8d82f72d6c62070a59a996ff1a1e33203ec536 Author: Ronald G. Minnich <rminnich(a)google.com> Date: Mon Nov 11 10:36:28 2013 -0800 cbfs: 64-bit cleanups cbfs used u32 in a number of cases where uintptr_t was correct. This change builds for both 64-bit and 32-bit boards. Also, add a function to convert 64-bit struct members to a void *. Note that it accomodates the incorrect byte ordering from cbfs -- which has been prevalent in coreboot since the beginning, and which we will not fix this time around. People might be upset if they suddenly can't read their flash images with cbfs. Change-Id: If42c722a8a9e8d565d3827f65ed6c2cb8e90ba60 Signed-off-by: Ronald G. Minnich <rminnich(a)google.com> --- src/lib/cbfs.c | 42 ++++++++++++++++++++++++++++++++---------- src/lib/cbmem.c | 2 +- src/lib/selfboot.c | 9 +++++---- 3 files changed, 38 insertions(+), 15 deletions(-) diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c index 4ccc9e6..1b9732c 100644 --- a/src/lib/cbfs.c +++ b/src/lib/cbfs.c @@ -254,13 +254,33 @@ void * cbfs_load_stage(struct cbfs_media *media, const char *name) #else +static void *cbfs_pointer(u64 value) +{ + void *v; + + /* While the goal was that cbfs data was bigendian, + * these fields are in fact little endian. It's a bug. + * But fixing it won't be simple as it will break + * backwards compatibility with already built images. + * For now, go with what works: use . + */ + /* there has to be a better way to do this. Do we need + * CONFIG_WORD_SIZE or something? + */ +#if (CONFIG_ARCH_X86 == 1) || (CONFIG_ARCH_ARMV7 == 1) + v = (void *)le32_to_cpu(value); +#else + v = (void *)le64_to_cpu(value); +#endif + return v; +} + void * cbfs_load_stage(struct cbfs_media *media, const char *name) { struct cbfs_stage *stage = (struct cbfs_stage *) cbfs_get_file_content(media, name, CBFS_TYPE_STAGE); - /* this is a mess. There is no ntohll. */ - /* for now, assume compatible byte order until we solve this. */ - uint32_t entry; + + void *load, *entry; uint32_t final_size; if (stage == NULL) @@ -271,29 +291,30 @@ void * cbfs_load_stage(struct cbfs_media *media, const char *name) (uint32_t) stage->load, stage->memlen, stage->entry); + load = cbfs_pointer(stage->load); final_size = cbfs_decompress(stage->compression, ((unsigned char *) stage) + sizeof(struct cbfs_stage), - (void *) (uint32_t) stage->load, + load, stage->len); if (!final_size) return (void *) -1; /* Stages rely the below clearing so that the bss is initialized. */ - memset((void *)((uintptr_t)stage->load + final_size), 0, + memset((load + final_size), 0, stage->memlen - final_size); DEBUG("stage loaded.\n"); - entry = stage->entry; - // entry = ntohll(stage->entry); + entry = cbfs_pointer(stage->entry); - return (void *) entry; + return entry; } #endif /* CONFIG_RELOCATABLE_RAMSTAGE */ int cbfs_execute_stage(struct cbfs_media *media, const char *name) { + void * entry; struct cbfs_stage *stage = (struct cbfs_stage *) cbfs_get_file_content(media, name, CBFS_TYPE_STAGE); @@ -307,8 +328,9 @@ int cbfs_execute_stage(struct cbfs_media *media, const char *name) } /* FIXME: This isn't right */ - LOG("run @ %p\n", (void *) ntohl((uint32_t) stage->entry)); - return run_address((void *)(uintptr_t)ntohll(stage->entry)); + entry = cbfs_pointer(stage->entry); + LOG("run @ %p\n", entry); + return run_address(entry); } #if !CONFIG_ALT_CBFS_LOAD_PAYLOAD diff --git a/src/lib/cbmem.c b/src/lib/cbmem.c index de49816..6449b55 100644 --- a/src/lib/cbmem.c +++ b/src/lib/cbmem.c @@ -200,7 +200,7 @@ void *cbmem_add(u32 id, u64 size) cbmem_toc[0].base += size; cbmem_toc[0].size -= size; - return (void *)(u32)cbmem_toc[i].base; + return (void *)(uintptr_t)cbmem_toc[i].base; } void *cbmem_find(u32 id) diff --git a/src/lib/selfboot.c b/src/lib/selfboot.c index f69ad14..222eae2 100644 --- a/src/lib/selfboot.c +++ b/src/lib/selfboot.c @@ -305,7 +305,7 @@ static int relocate_segment(unsigned long buffer, struct segment *seg) static int build_self_segment_list( struct segment *head, struct lb_memory *mem, - struct cbfs_payload *payload, u32 *entry) + struct cbfs_payload *payload, uintptr_t *entry) { struct segment *new; struct segment *ptr; @@ -332,8 +332,9 @@ static int build_self_segment_list( new->s_memsz = ntohl(segment->mem_len); new->compression = ntohl(segment->compression); - new->s_srcaddr = (u32) ((unsigned char *)first_segment) - + ntohl(segment->offset); + new->s_srcaddr = (uintptr_t) + ((unsigned char *)first_segment) + + ntohl(segment->offset); new->s_filesz = ntohl(segment->len); printk(BIOS_DEBUG, " New segment dstaddr 0x%lx memsize 0x%lx srcaddr 0x%lx filesize 0x%lx\n", new->s_dstaddr, new->s_memsz, new->s_srcaddr, new->s_filesz); @@ -504,7 +505,7 @@ static int load_self_segments( void *selfload(struct lb_memory *mem, struct cbfs_payload *payload) { - u32 entry=0; + uintptr_t entry = 0; struct segment head; /* Preprocess the self segments */

1 0

Patch merged into coreboot/master: a4affe1 board_status.sh: trivial cosmetic changes toward the end
by gerrit＠coreboot.org 17 Nov '13

17 Nov '13

the following patch was just integrated into master: commit a4affe17f1a31946841b6fa425d0ef4b3ea00855 Author: David Hendricks <dhendrix(a)chromium.org> Date: Tue Nov 12 18:17:19 2013 -0800 board_status.sh: trivial cosmetic changes toward the end This moves an ugly comment closer to where it is applicable and also adds a visual break between the commands which gather data and the part of the script that finishes up. I'm usually not fan of banner comments, but it seemed to help in my totally subjective opinion. I was thinking about how to break the part that uploads results into a separate function, but there are enough variables that are re-used from earlier parts that the tradeoff probably isn't worth it. Change-Id: If888329911c4de3b907cdf5973695c707bbb02fe Signed-off-by: David Hendricks <dhendrix(a)chromium.org> Reviewed-on: http://review.coreboot.org/4051 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> See http://review.coreboot.org/4051 for details. -gerrit

1 0

Patch merged into coreboot/master: 406ce8a board_status.sh: pass filename as an arg to command wrappers
by gerrit＠coreboot.org 17 Nov '13

17 Nov '13

the following patch was just integrated into master: commit 406ce8a06e82dc17c7153c02585aa3e8f885561f Author: David Hendricks <dhendrix(a)chromium.org> Date: Tue Nov 12 18:10:23 2013 -0800 board_status.sh: pass filename as an arg to command wrappers This allows the command wrappers to delete files if the command fails. In particular, it delets empty or otherwise useless files that are generated if a non-fatal command fails. Change-Id: If26d7b4d7500f160edd1cc2a8b6218792fefae8b Signed-off-by: David Hendricks <dhendrix(a)chromium.org> Reviewed-on: http://review.coreboot.org/4050 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> See http://review.coreboot.org/4050 for details. -gerrit

1 0

Patch merged into coreboot/master: f8b90e4 board_status.sh: add support for non-fatal commands
by gerrit＠coreboot.org 17 Nov '13

17 Nov '13

the following patch was just integrated into master: commit f8b90e4622533947dbc21c55b21ea932eb7420c7 Author: David Hendricks <dhendrix(a)chromium.org> Date: Tue Nov 12 17:24:42 2013 -0800 board_status.sh: add support for non-fatal commands This adds cmd_nonfatal() for commands which are considered non-essential and can be expected to fail safely. This can be used, for example, to gather data that is generated when using non-standard utilities or coreboot config options. Change-Id: Ie43944d2eb73f9aae1c30c3a204cfc413e11d286 Signed-off-by: David Hendricks <dhendrix(a)chromium.org> Reviewed-on: http://review.coreboot.org/4049 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich <rminnich(a)gmail.com> See http://review.coreboot.org/4049 for details. -gerrit

1 0

← Newer
1
...
59
60
61
62
63
64
65
...
86
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2013