Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32172
Change subject: mb/asrock/h110m: Set PEG as primary GFX device ......................................................................
mb/asrock/h110m: Set PEG as primary GFX device
If an external graphics card is inserted in the PEG, it will be used as the primary display device (as in the AMI BIOS)
Change-Id: Iea846179fc309c2b98093de37c05ceb332081f4f Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/32172/1
diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb index 397da37..b0756ca 100644 --- a/src/mainboard/asrock/h110m/devicetree.cb +++ b/src/mainboard/asrock/h110m/devicetree.cb @@ -46,6 +46,7 @@ register "ScsSdCardEnabled" = "0" register "HeciEnabled" = "0" register "SkipExtGfxScan" = "0" + register "PrimaryDisplay" = "Display_PEG" register "Device4Enable" = "1" register "SaGv" = "SaGv_Enabled" register "PmTimerDisabled" = "0"
Maxim Polyakov has removed build bot (Jenkins) from this change. ( https://review.coreboot.org/c/coreboot/+/32172 )
Change subject: mb/asrock/h110m: Set PEG as primary GFX device ......................................................................
Removed reviewer build bot (Jenkins) with the following votes:
* Verified+1 by build bot (Jenkins) no-reply@coreboot.org
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32172 )
Change subject: mb/asrock/h110m: Set PEG as primary GFX device ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32172 )
Change subject: mb/asrock/h110m: Set PEG as primary GFX device ......................................................................
Patch Set 1:
I would still prefer that this is somehow sync'ed with the existing Kconfig option. But it's not very easy I guess, because usually we only have onboard vs external and for these FSP platforms three choices PEG, PCH and internal. And that only makes sense if FSP does the expected thing, i.e. route the legacy VGA resources to the "PrimaryDisplay".
One way would be to disable coreboot's code for this on these platforms (i.e. if we know FSP already took care of it, skip it in coreboot). But, yeah, maybe it's not worth the effort.
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32172 )
Change subject: mb/asrock/h110m: Set PEG as primary GFX device ......................................................................
Patch Set 1:
Patch Set 1:
I would still prefer that this is somehow sync'ed with the existing Kconfig option. But it's not very easy I guess, because usually we only have onboard vs external and for these FSP platforms three choices PEG, PCH and internal. And that only makes sense if FSP does the expected thing, i.e. route the legacy VGA resources to the "PrimaryDisplay".
One way would be to disable coreboot's code for this on these platforms (i.e. if we know FSP already took care of it, skip it in coreboot). But, yeah, maybe it's not worth the effort.
Hi, Nico! Correct me if I'm wrong, but maybe we need to skip the function set_vga_bridge_bits() ( in https://github.com/coreboot/coreboot/blob/5d1f9a009647c741e8587015b14f1e852e... ) if we use any of the FSP (1.1, 2.0, 2.1).
and add dependency in console/Kconfig:
config ONBOARD_VGA_IS_PRIMARY bool "Use onboard VGA as primary video device" default n - depends on PCI + depends on PCI && !PLATFORM_USES_FSP1_1 && \ + !PLATFORM_USES_FSP2_0 && PLATFORM_USES_FSP2_1
Can I do this in a separate patch?
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32172 )
Change subject: mb/asrock/h110m: Set PEG as primary GFX device ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
I would still prefer that this is somehow sync'ed with the existing Kconfig option. But it's not very easy I guess, because usually we only have onboard vs external and for these FSP platforms three choices PEG, PCH and internal. And that only makes sense if FSP does the expected thing, i.e. route the legacy VGA resources to the "PrimaryDisplay".
One way would be to disable coreboot's code for this on these platforms (i.e. if we know FSP already took care of it, skip it in coreboot). But, yeah, maybe it's not worth the effort.
Hi, Nico! Correct me if I'm wrong, but maybe we need to skip the function set_vga_bridge_bits() ( in https://github.com/coreboot/coreboot/blob/5d1f9a009647c741e8587015b14f1e852e... ) if we use any of the FSP (1.1, 2.0, 2.1).
I have never used anything beside the IGD with FSP, so I have no idea how the FSP versions behave. I would say, we'd have to test for each FSP version (or maybe even platform) if FSP does set those VGA bridge bits.
and add dependency in console/Kconfig:
config ONBOARD_VGA_IS_PRIMARY bool "Use onboard VGA as primary video device" default n
depends on PCI
depends on PCI && !PLATFORM_USES_FSP1_1 && \!PLATFORM_USES_FSP2_0 && PLATFORM_USES_FSP2_1Can I do this in a separate patch?
Sure. But you don't have to, I guess. It works already and changing these bits later shouldn't hurt (as long as no program already runs that makes use of legacy VGA, and it shouldn't).
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32172 )
Change subject: mb/asrock/h110m: Set PEG as primary GFX device ......................................................................
mb/asrock/h110m: Set PEG as primary GFX device
If an external graphics card is inserted in the PEG, it will be used as the primary display device (as in the AMI BIOS)
Change-Id: Iea846179fc309c2b98093de37c05ceb332081f4f Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32172 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/asrock/h110m/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb index 397da37..b0756ca 100644 --- a/src/mainboard/asrock/h110m/devicetree.cb +++ b/src/mainboard/asrock/h110m/devicetree.cb @@ -46,6 +46,7 @@ register "ScsSdCardEnabled" = "0" register "HeciEnabled" = "0" register "SkipExtGfxScan" = "0" + register "PrimaryDisplay" = "Display_PEG" register "Device4Enable" = "1" register "SaGv" = "SaGv_Enabled" register "PmTimerDisabled" = "0"
-
Maxim Polyakov (Code Review) -
Nico Huber (Code Review)