Patch Set 1:

Patch Set 1:

I would still prefer that this is somehow sync'ed
with the existing Kconfig option. But it's not very
easy I guess, because usually we only have onboard
vs external and for these FSP platforms three choices
PEG, PCH and internal. And that only makes sense if
FSP does the expected thing, i.e. route the legacy
VGA resources to the "PrimaryDisplay".

One way would be to disable coreboot's code for this
on these platforms (i.e. if we know FSP already took
care of it, skip it in coreboot). But, yeah, maybe it's
not worth the effort.

Hi, Nico!
Correct me if I'm wrong, but maybe we need to skip the function set_vga_bridge_bits()
( in https://github.com/coreboot/coreboot/blob/5d1f9a009647c741e8587015b14f1e852e1c489e/src/device/device.c#L1024 ) if we use any of the FSP (1.1, 2.0, 2.1).

I have never used anything beside the IGD with FSP, so
I have no idea how the FSP versions behave. I would say,
we'd have to test for each FSP version (or maybe even
platform) if FSP does set those VGA bridge bits.

and add dependency in console/Kconfig:

 config ONBOARD_VGA_IS_PRIMARY
        bool "Use onboard VGA as primary video device"
        default n
-       depends on PCI
+       depends on PCI && !PLATFORM_USES_FSP1_1 && \
+               !PLATFORM_USES_FSP2_0 && PLATFORM_USES_FSP2_1

Can I do this in a separate patch?

Sure. But you don't have to, I guess. It works already
and changing these bits later shouldn't hurt (as long as
no program already runs that makes use of legacy VGA,
and it shouldn't).

View Change

To view, visit change 32172. To unsubscribe, or for help writing mail filters, visit settings.