Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32172 )
Change subject: mb/asrock/h110m: Set PEG as primary GFX device
......................................................................
Patch Set 1:
I would still prefer that this is somehow sync'ed
with the existing Kconfig option. But it's not very
easy I guess, because usually we only have onboard
vs external and for these FSP platforms three choices
PEG, PCH and internal. And that only makes sense if
FSP does the expected thing, i.e. route the legacy
VGA resources to the "PrimaryDisplay".
One way would be to disable coreboot's code for this
on these platforms (i.e. if we know FSP already took
care of it, skip it in coreboot). But, yeah, maybe it's
not worth the effort.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32172
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea846179fc309c2b98093de37c05ceb332081f4f
Gerrit-Change-Number: 32172
Gerrit-PatchSet: 1
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 05 Apr 2019 16:12:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment