Patch Set 1:
I would still prefer that this is somehow sync'ed
with the existing Kconfig option. But it's not very
easy I guess, because usually we only have onboard
vs external and for these FSP platforms three choices
PEG, PCH and internal. And that only makes sense if
FSP does the expected thing, i.e. route the legacy
VGA resources to the "PrimaryDisplay".One way would be to disable coreboot's code for this
on these platforms (i.e. if we know FSP already took
care of it, skip it in coreboot). But, yeah, maybe it's
not worth the effort.
Hi, Nico!
Correct me if I'm wrong, but maybe we need to skip the function set_vga_bridge_bits()
( in https://github.com/coreboot/coreboot/blob/5d1f9a009647c741e8587015b14f1e852e1c489e/src/device/device.c#L1024 ) if we use any of the FSP (1.1, 2.0, 2.1).
and add dependency in console/Kconfig:
config ONBOARD_VGA_IS_PRIMARY
bool "Use onboard VGA as primary video device"
default n
- depends on PCI
+ depends on PCI && !PLATFORM_USES_FSP1_1 && \
+ !PLATFORM_USES_FSP2_0 && PLATFORM_USES_FSP2_1
Can I do this in a separate patch?
To view, visit change 32172. To unsubscribe, or for help writing mail filters, visit settings.