Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37619 )
Change subject: [WIP] asus/f2a85-m: Fix f2a85-m_pro devicetree ......................................................................
[WIP] asus/f2a85-m: Fix f2a85-m_pro devicetree
Change-Id: I3a4a6aca7058e2576e0e6046c8397c03f1222830 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb 1 file changed, 45 insertions(+), 64 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/37619/1
diff --git a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb index f13e3e8..3f08015 100644 --- a/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb +++ b/src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb @@ -65,83 +65,64 @@ device pnp 2e.5 off end # Keyboard device pnp 2e.6 off end # CIR device pnp 2e.7 on # GPIO6, GPIO7, GPIO8 - io 0xe0 = 0x7f - io 0xe1 = 0x10 - io 0xe2 = 0x00 - io 0xe3 = 0x00 - io 0xe4 = 0xff - io 0xe5 = 0xff - io 0xe6 = 0xff - io 0xe7 = 0xff - io 0xec = 0x00 - io 0xed = 0xff - io 0xf4 = 0xff - io 0xf5 = 0xff - io 0xf6 = 0x00 - io 0xf7 = 0x00 - io 0xf8 = 0x00 + irq 0xe0 = 0x7f + irq 0xe1 = 0x10 + irq 0xe2 = 0x00 + irq 0xe3 = 0x00 + irq 0xe4 = 0xff + irq 0xe5 = 0xff + irq 0xe6 = 0xff + irq 0xe7 = 0xff + irq 0xec = 0x00 + irq 0xed = 0xff + irq 0xf4 = 0xff + irq 0xf5 = 0xff + irq 0xf6 = 0x00 + irq 0xf7 = 0x00 + irq 0xf8 = 0x00 end - device pnp 2e.8 on # WDT1, GPIO0, GPIO1 - io 0x30 = 0x00 - io 0x60 = 0x00 - io 0x61 = 0x00 - io 0xe0 = 0xff - io 0xe1 = 0xff - io 0xe2 = 0xff - io 0xe3 = 0xff - io 0xe4 = 0xff - io 0xf0 = 0xff - io 0xf1 = 0x28 - io 0xf2 = 0x00 - io 0xf3 = 0x00 - io 0xf4 = 0x08 - io 0xf5 = 0xff - io 0xf6 = 0x00 - io 0xf7 = 0xff - end + device pnp 2e.8 off end # WDT1, GPIO0, GPIO1 device pnp 2e.9 on # GPIO1, GPIO2, GPIO3, GPIO4, GPIO5, GPIO6, GPIO7, GPIO8 io 0x30 = 0xfe - io 0xe0 = 0xff - io 0xe1 = 0x90 - io 0xe2 = 0x00 - io 0xe3 = 0x00 - io 0xe4 = 0x7f - io 0xe5 = 0x76 - io 0xe6 = 0x00 - io 0xe7 = 0x00 - io 0xe8 = 0x00 - io 0xe9 = 0x00 - io 0xea = 0x00 - io 0xeb = 0x00 - io 0xee = 0x00 - io 0xf0 = 0xff - io 0xf1 = 0x7b - io 0xf2 = 0x00 - io 0xf4 = 0xff - io 0xf5 = 0xef - io 0xf6 = 0x00 - io 0xf7 = 0x00 - io 0xfe = 0x00 + irq 0xe0 = 0xff + irq 0xe1 = 0x90 + irq 0xe2 = 0x00 + irq 0xe3 = 0x00 + irq 0xe4 = 0x7f + irq 0xe5 = 0x76 + irq 0xe6 = 0x00 + irq 0xe7 = 0x00 + irq 0xe8 = 0x00 + irq 0xe9 = 0x00 + irq 0xea = 0x00 + irq 0xeb = 0x00 + irq 0xee = 0x00 + irq 0xf0 = 0xff + irq 0xf1 = 0x7b + irq 0xf2 = 0x00 + irq 0xf4 = 0xff + irq 0xf5 = 0xef + irq 0xf6 = 0x00 + irq 0xf7 = 0x00 + irq 0xfe = 0x00 end device pnp 2e.a on # ACPI - io 0xe6 = 0x4c - io 0xe7 = 0x11 - io 0xf2 = 0x5d + irq 0xe6 = 0x4c + irq 0xe7 = 0x11 + irq 0xf2 = 0x5d end device pnp 2e.b on # Hardware Monitor, Front Panel LED - io 0x30 = 0x01 - io 0x60 = 0x02 - io 0x61 = 0x90 - io 0xe2 = 0x7f - io 0xe4 = 0xf1 + io 0x60 = 0x0290 + irq 0xe2 = 0x7f + irq 0xe4 = 0xf1 end device pnp 2e.d off end # WDT1 device pnp 2e.e off end # CIR WAKE-UP device pnp 2e.f off # GPIO Push-pull/Open-drain selection - io 0xe6 = 7f + irq 0xe6 = 0x7f end device pnp 2e.14 off # PORT80 UART - io 0xe0 = 0x00 + irq 0xe0 = 0x00 end device pnp 2e.16 off end # Deep Sleep end
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37619 )
Change subject: [WIP] asus/f2a85-m: Fix f2a85-m_pro devicetree ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37619/1/src/mainboard/asus/f2a85-m/... File src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb:
https://review.coreboot.org/c/coreboot/+/37619/1/src/mainboard/asus/f2a85-m/... PS1, Line 86: io 0x30 = 0xfe this is still wrong. there should be a virtual LDN for each GPIO dev, I guess?
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37619 )
Change subject: [WIP] asus/f2a85-m: Fix f2a85-m_pro devicetree ......................................................................
Patch Set 1:
See CB:35855, I think wrong hash was reported as bisect result
2f8192b asus/f2a85m_pro: Fix superio type in devicetree 51b75ae device: Use scan_static_bus() over scan_lpc_bus()
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37619 )
Change subject: [WIP] asus/f2a85-m: Fix f2a85-m_pro devicetree ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37619/1/src/mainboard/asus/f2a85-m/... File src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb:
https://review.coreboot.org/c/coreboot/+/37619/1/src/mainboard/asus/f2a85-m/... PS1, Line 67: device pnp 2e.7 on # GPIO6, GPIO7, GPIO8 Is there a single enable bit for GPIO6-8 ?
https://review.coreboot.org/c/coreboot/+/37619/1/src/mainboard/asus/f2a85-m/... PS1, Line 86: io 0x30 = 0xfe
this is still wrong. […]
Probably. GPIO1 is also already listed for 2e.8 and GPIO6,7,8 for 2e.7.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37619 )
Change subject: [WIP] asus/f2a85-m: Fix f2a85-m_pro devicetree ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37619/1/src/mainboard/asus/f2a85-m/... File src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb:
https://review.coreboot.org/c/coreboot/+/37619/1/src/mainboard/asus/f2a85-m/... PS1, Line 86: io 0x30 = 0xfe
Probably. GPIO1 is also already listed for 2e.8 and GPIO6,7,8 for 2e.7.
Looking at `superio/nuvoton/nct6779d/nct6779d.h`, GPIO0 enable is bit 1 of 2e.8, and all the other GPIOs have bits in 2e.9. This would also explain why there was no 0x30 setting for 2e.7 above.
https://review.coreboot.org/c/coreboot/+/37619/1/src/mainboard/asus/f2a85-m/... PS1, Line 122: irq 0xe6 = 0x7f Do we run .set_resources for disabled devices?
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37619 )
Change subject: [WIP] asus/f2a85-m: Fix f2a85-m_pro devicetree ......................................................................
Patch Set 1:
Denis, ping.
Kyösti Mälkki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37619 )
Change subject: [WIP] asus/f2a85-m: Fix f2a85-m_pro devicetree ......................................................................
Abandoned
-
Kyösti Mälkki (Code Review) -
Nico Huber (Code Review)