Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37619 )
Change subject: [WIP] asus/f2a85-m: Fix f2a85-m_pro devicetree
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37619/1/src/mainboard/asus/f2a85-m/...
File src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb:
https://review.coreboot.org/c/coreboot/+/37619/1/src/mainboard/asus/f2a85-m/...
PS1, Line 67: device pnp 2e.7 on # GPIO6, GPIO7, GPIO8
Is there a single enable bit for GPIO6-8 ?
https://review.coreboot.org/c/coreboot/+/37619/1/src/mainboard/asus/f2a85-m/...
PS1, Line 86: io 0x30 = 0xfe
this is still wrong. […]
Probably. GPIO1 is also already listed for 2e.8 and GPIO6,7,8 for 2e.7.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37619
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a4a6aca7058e2576e0e6046c8397c03f1222830
Gerrit-Change-Number: 37619
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Denis 'GNUtoo' Carikli
GNUtoo@cyberdimension.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Dec 2019 08:15:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment