Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37619 )
Change subject: [WIP] asus/f2a85-m: Fix f2a85-m_pro devicetree ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37619/1/src/mainboard/asus/f2a85-m/... File src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb:
https://review.coreboot.org/c/coreboot/+/37619/1/src/mainboard/asus/f2a85-m/... PS1, Line 86: io 0x30 = 0xfe
Probably. GPIO1 is also already listed for 2e.8 and GPIO6,7,8 for 2e.7.
Looking at `superio/nuvoton/nct6779d/nct6779d.h`, GPIO0 enable is bit 1 of 2e.8, and all the other GPIOs have bits in 2e.9. This would also explain why there was no 0x30 setting for 2e.7 above.
https://review.coreboot.org/c/coreboot/+/37619/1/src/mainboard/asus/f2a85-m/... PS1, Line 122: irq 0xe6 = 0x7f Do we run .set_resources for disabled devices?