Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39361 )
Change subject: lib/spd_bin: Fix grammar mistake in a comment ......................................................................
lib/spd_bin: Fix grammar mistake in a comment
Change-Id: I0a9ec0f9605282cbf4fd0ac05070278a3331b6fa Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/lib/spd_bin.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/39361/1
diff --git a/src/lib/spd_bin.c b/src/lib/spd_bin.c index 9e625b5..25eb552 100644 --- a/src/lib/spd_bin.c +++ b/src/lib/spd_bin.c @@ -55,7 +55,7 @@ static const int ddr4_banks[10] = { 4, 8, -1, -1, 8, 16, -1, -1, 16, 32 }; int index = (spd[SPD_DENSITY_BANKS] >> 4) & 0xf; switch (dram_type) { - /* DDR3 and LPDDR3 has the same bank definition */ + /* DDR3 and LPDDR3 have the same bank definition */ case SPD_DRAM_DDR3: case SPD_DRAM_LPDDR3_INTEL: case SPD_DRAM_LPDDR3_JEDEC:
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39361 )
Change subject: lib/spd_bin: Fix grammar mistake in a comment ......................................................................
Patch Set 1: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39361 )
Change subject: lib/spd_bin: Fix grammar mistake in a comment ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39361 )
Change subject: lib/spd_bin: Fix grammar mistake in a comment ......................................................................
lib/spd_bin: Fix grammar mistake in a comment
Change-Id: I0a9ec0f9605282cbf4fd0ac05070278a3331b6fa Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39361 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Nico Huber nico.h@gmx.de --- M src/lib/spd_bin.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
diff --git a/src/lib/spd_bin.c b/src/lib/spd_bin.c index 9e625b5..25eb552 100644 --- a/src/lib/spd_bin.c +++ b/src/lib/spd_bin.c @@ -55,7 +55,7 @@ static const int ddr4_banks[10] = { 4, 8, -1, -1, 8, 16, -1, -1, 16, 32 }; int index = (spd[SPD_DENSITY_BANKS] >> 4) & 0xf; switch (dram_type) { - /* DDR3 and LPDDR3 has the same bank definition */ + /* DDR3 and LPDDR3 have the same bank definition */ case SPD_DRAM_DDR3: case SPD_DRAM_LPDDR3_INTEL: case SPD_DRAM_LPDDR3_JEDEC:
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39361 )
Change subject: lib/spd_bin: Fix grammar mistake in a comment ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1169 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1168 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1167
Please note: This test is under development and might not be accurate at all!