Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39274 )
Change subject: util/scripts/gerrit-rebase: Improve error message ......................................................................
util/scripts/gerrit-rebase: Improve error message
I received feedback that people were confused by "Error: foo", so replace it with something more user friendly that serves the same purpose.
Change-Id: I17b902a62020109e079437c8d9ffd7ea5979a3a1 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/scripts/gerrit-rebase 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/39274/1
diff --git a/util/scripts/gerrit-rebase b/util/scripts/gerrit-rebase index 276142d..d051103 100755 --- a/util/scripts/gerrit-rebase +++ b/util/scripts/gerrit-rebase @@ -71,7 +71,7 @@ cut -d: -f2-)"
# start rebase process, but fail immediately by enforcing an invalid todo -GIT_SEQUENCE_EDITOR="echo foo >" \ +GIT_SEQUENCE_EDITOR="echo Ignore this error, it's intentional>" \ git rebase -i --onto ${to} ${from} ${to} 2>/dev/null
# write new rebase todo
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39274 )
Change subject: util/scripts/gerrit-rebase: Improve error message ......................................................................
Patch Set 1: Code-Review+2
foo.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39274 )
Change subject: util/scripts/gerrit-rebase: Improve error message ......................................................................
util/scripts/gerrit-rebase: Improve error message
I received feedback that people were confused by "Error: foo", so replace it with something more user friendly that serves the same purpose.
Change-Id: I17b902a62020109e079437c8d9ffd7ea5979a3a1 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39274 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M util/scripts/gerrit-rebase 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/util/scripts/gerrit-rebase b/util/scripts/gerrit-rebase index 276142d..d051103 100755 --- a/util/scripts/gerrit-rebase +++ b/util/scripts/gerrit-rebase @@ -71,7 +71,7 @@ cut -d: -f2-)"
# start rebase process, but fail immediately by enforcing an invalid todo -GIT_SEQUENCE_EDITOR="echo foo >" \ +GIT_SEQUENCE_EDITOR="echo Ignore this error, it's intentional>" \ git rebase -i --onto ${to} ${from} ${to} 2>/dev/null
# write new rebase todo
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39274 )
Change subject: util/scripts/gerrit-rebase: Improve error message ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1166 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1165 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1164
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Patrick Georgi (Code Review)