Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Andrey Petrov, Julian Schroeder, Patrick Rudolph, Felix Held.
Name of user not set #1003801 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61281 )
Change subject: soc/amd/common/fsp: check fsp image revision
......................................................................
Patch Set 11:
(3 comments)
File src/soc/amd/common/fsp/fsp_validate.c:
https://review.coreboot.org/c/coreboot/+/61281/comment/9c9bf10c_2e0ec7b0
PS10, Line 12: };
since this is used to deserialize data, i'd add a __packed attribute just to be sure that the compil […]
Ack
https://review.coreboot.org/c/coreboot/+/61281/comment/6530b324_902d8549
PS10, Line 47: " build's FspmUpd.h\n");
i'd indent this line
Ack
https://review.coreboot.org/c/coreboot/+/61281/comment/449e764d_37d7b16a
PS10, Line 51: printk(BIOS_ERR, "IMAGE_REVISION_MAJOR_VERSION mismatch, halting\n");
: die("Goodbye now\n");
put the message from the printk line in the die call?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61281
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0fbf9413b0cf3e6093ee9c61ff692ff78ebefebc
Gerrit-Change-Number: 61281
Gerrit-PatchSet: 11
Gerrit-Owner: Name of user not set #1003801
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 01 Feb 2022 00:11:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment