Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Andrey Petrov, Julian Schroeder, Patrick Rudolph, Felix Held.

View Change

3 comments:

• File src/soc/amd/common/fsp/fsp_validate.c:

  • Patch Set #10, Line 12: };

    since this is used to deserialize data, i'd add a __packed attribute just to be sure that the compil […]

    Ack

  • Patch Set #10, Line 47: " build's FspmUpd.h\n");

    i'd indent this line

    Ack

  • Patch Set #10, Line 51:

    printk(BIOS_ERR, "IMAGE_REVISION_MAJOR_VERSION mismatch, halting\n");
    		die("Goodbye now\n");
    

    put the message from the printk line in the die call?

    Ack

To view, visit change 61281. To unsubscribe, or for help writing mail filters, visit settings.