[coreboot-gerrit] Change in coreboot[master]: soc/amd/common/fsp: check fsp image revision

[Name of user not set (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Andrey Petrov, Julian Schroeder, Patrick Rudolph, Felix Held.
Name of user not set #1003801 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61281 )

Change subject: soc/amd/common/fsp: check fsp image revision
......................................................................

Patch Set 11:

(3 comments)

File src/soc/amd/common/fsp/fsp_validate.c:

https://review.coreboot.org/c/coreboot/+/61281/comment/9c9bf10c_2e0ec7b0 
PS10, Line 12: };
> since this is used to deserialize data, i'd add a __packed attribute just to be sure that the compil […]

Ack

https://review.coreboot.org/c/coreboot/+/61281/comment/6530b324_902d8549 
PS10, Line 47: 		" build's FspmUpd.h\n");
> i'd indent this line

Ack

https://review.coreboot.org/c/coreboot/+/61281/comment/449e764d_37d7b16a 
PS10, Line 51: printk(BIOS_ERR, "IMAGE_REVISION_MAJOR_VERSION mismatch, halting\n");
             : 		die("Goodbye now\n");
> put the message from the printk line in the die call?

Ack