Change in coreboot[master]: vc/amd/fsp/picasso: Sync FSP-S UPD header file

[Marshall Dawson (Code Review)]

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45113 )

Change subject: vc/amd/fsp/picasso: Sync FSP-S UPD header file
......................................................................

vc/amd/fsp/picasso: Sync FSP-S UPD header file

Cq-Depend: chrome-internal:3247431
BUG=b:167421913, b:166519072, b:159664044
TEST=Boot morphius
BRANCH=Zork

Signed-off-by: Marshall Dawson 
Change-Id: Ic85e1f457c8932d933d8645738de68319dbf375a
---
M src/vendorcode/amd/fsp/picasso/FspsUpd.h
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/45113/1

diff --git a/src/vendorcode/amd/fsp/picasso/FspsUpd.h b/src/vendorcode/amd/fsp/picasso/FspsUpd.h
index 5adbb81..ccd4568 100644
--- a/src/vendorcode/amd/fsp/picasso/FspsUpd.h
+++ b/src/vendorcode/amd/fsp/picasso/FspsUpd.h
@@ -31,7 +31,10 @@
    /** Offset 0x011D**/	uint8_t                     unused3;
    /** Offset 0x011E**/	uint32_t                    xhci_oc_pin_select;
    /** Offset 0x0122**/	uint8_t                     xhci0_force_gen1;
-	/** Offset 0x0123**/	uint8_t                     UnusedUpdSpace0[45];
+	/** Offset 0x0123**/	uint8_t                     xhci_sparse_mode_enable;
+	/** Offset 0x0124**/	uint8_t                     fch_ioapic_id;
+	/** Offset 0x0125**/	uint8_t                     gnb_ioapic_id;
+	/** Offset 0x0126**/	uint8_t                     UnusedUpdSpace0[42];
    /** Offset 0x0150**/	uint16_t                    UpdTerminator;
 } FSP_S_CONFIG;

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45113 )

Change subject: vc/amd/fsp/picasso: Sync FSP-S UPD header file
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45113 )

Change subject: vc/amd/fsp/picasso: Sync FSP-S UPD header file
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45113/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45113/1//COMMIT_MSG@8 
PS1, Line 8: 
Please summarize changes in the commit message.

[Marshall Dawson (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45113

to look at the new patch set (#2).

Change subject: vc/amd/fsp/picasso: Sync FSP-S UPD header file
......................................................................

vc/amd/fsp/picasso: Sync FSP-S UPD header file

Sync the UPD definitions with the latest auto-generated files.
Definitions and usage will be updated in a subsequent FSP
Integration Guide.

Cq-Depend: chrome-internal:3247431
BUG=b:167421913, b:166519072, b:159664044
TEST=Boot morphius
BRANCH=Zork

Signed-off-by: Marshall Dawson 
Change-Id: Ic85e1f457c8932d933d8645738de68319dbf375a
---
M src/vendorcode/amd/fsp/picasso/FspsUpd.h
1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/45113/2

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45113 )

Change subject: vc/amd/fsp/picasso: Sync FSP-S UPD header file
......................................................................

Patch Set 2: Code-Review-2

Going to redo this file.

[Marshall Dawson (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45113

to look at the new patch set (#3).

Change subject: vc/amd/fsp/picasso: Sync FSP-S UPD header file
......................................................................

vc/amd/fsp/picasso: Sync FSP-S UPD header file

Sync the UPD definitions with the latest auto-generated files.
Definitions and usage will be updated in a subsequent FSP
Integration Guide.

Cq-Depend: chrome-internal:3247431
BUG=b:167421913, b:166519072, b:159664044
TEST=Boot morphius
BRANCH=Zork

Signed-off-by: Marshall Dawson 
Change-Id: Ic85e1f457c8932d933d8645738de68319dbf375a
---
M src/vendorcode/amd/fsp/picasso/FspsUpd.h
1 file changed, 5 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/45113/3

[Marshall Dawson (Code Review)]

Marshall Dawson has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/45113 )

Change subject: vc/amd/fsp/picasso: Sync FSP-S UPD header file
......................................................................

Removed Code-Review-2 by Marshall Dawson

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45113 )

Change subject: vc/amd/fsp/picasso: Sync FSP-S UPD header file
......................................................................

Patch Set 3: Code-Review+2

[Jason Glenesk (Code Review)]

Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45113 )

Change subject: vc/amd/fsp/picasso: Sync FSP-S UPD header file
......................................................................

Patch Set 3: Code-Review+1

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45113 )

Change subject: vc/amd/fsp/picasso: Sync FSP-S UPD header file
......................................................................

Patch Set 3: Code-Review+2

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45113 )

Change subject: vc/amd/fsp/picasso: Sync FSP-S UPD header file
......................................................................

Patch Set 3:

Marshall - there is still one unresolved comment. Once that is marked done, we can go ahead and merge this.

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45113 )

Change subject: vc/amd/fsp/picasso: Sync FSP-S UPD header file
......................................................................

Patch Set 3:

(1 comment)
> Patch Set 3:
>
> Marshall - there is still one unresolved comment. Once that is marked done, we can go ahead and merge this.

Thanks for the heads-up.  Missed that one.

https://review.coreboot.org/c/coreboot/+/45113/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/45113/1//COMMIT_MSG@8 
PS1, Line 8:
> Please summarize changes in the commit message.

Done

[Marshall Dawson (Code Review)]

Marshall Dawson has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45113 )

Change subject: vc/amd/fsp/picasso: Sync FSP-S UPD header file
......................................................................

vc/amd/fsp/picasso: Sync FSP-S UPD header file

Sync the UPD definitions with the latest auto-generated files.
Definitions and usage will be updated in a subsequent FSP
Integration Guide.

Cq-Depend: chrome-internal:3247431
BUG=b:167421913, b:166519072, b:159664044
TEST=Boot morphius
BRANCH=Zork

Signed-off-by: Marshall Dawson 
Change-Id: Ic85e1f457c8932d933d8645738de68319dbf375a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45113
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Jason Glenesk 
Reviewed-by: Raul Rangel 
---
M src/vendorcode/amd/fsp/picasso/FspsUpd.h
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Raul Rangel: Looks good to me, approved
  Jason Glenesk: Looks good to me, but someone else must approve

diff --git a/src/vendorcode/amd/fsp/picasso/FspsUpd.h b/src/vendorcode/amd/fsp/picasso/FspsUpd.h
index 5adbb81..34c672d 100644
--- a/src/vendorcode/amd/fsp/picasso/FspsUpd.h
+++ b/src/vendorcode/amd/fsp/picasso/FspsUpd.h
@@ -31,7 +31,11 @@
    /** Offset 0x011D**/	uint8_t                     unused3;
    /** Offset 0x011E**/	uint32_t                    xhci_oc_pin_select;
    /** Offset 0x0122**/	uint8_t                     xhci0_force_gen1;
-	/** Offset 0x0123**/	uint8_t                     UnusedUpdSpace0[45];
+	/** Offset 0x0123**/	uint8_t                     xhci_sparse_mode_enable;
+        /** Offset 0x0124**/    uint32_t                    gnb_ioapic_base;
+        /** Offset 0x0128**/    uint8_t                     gnb_ioapic_id;
+        /** Offset 0x0129**/    uint8_t                     fch_ioapic_id;
+	/** Offset 0x0126**/	uint8_t                     UnusedUpdSpace0[38];
    /** Offset 0x0150**/	uint16_t                    UpdTerminator;
 } FSP_S_CONFIG;

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45113 )

Change subject: vc/amd/fsp/picasso: Sync FSP-S UPD header file
......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 7/1/8
"QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/18654
"QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18653
"QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/18652
"QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18651
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/18650
"HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/18657
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/18656
"HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/18655

Please note: This test is under development and might not be accurate at all!