Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70162 )
Change subject: mb/google/herobrine: Only retrieve sku_id from EC once
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/herobrine/boardid.c:
https://review.coreboot.org/c/coreboot/+/70162/comment/dbef7480_57c1dc78
PS2, Line 28: printk(BIOS_INFO, "BoardID :%d - "
Also, I put in an early exit like in sku_id because I figured that it wouldn't be useful setting up […]
The compiler should be smart enough to move that array setup into the if-block to avoid extra cycles in the case where it's already cached. But no harm in making it more explicit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70162
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia787968100baf58a41ccce0cf95ed3ec9ce1758a
Gerrit-Change-Number: 70162
Gerrit-PatchSet: 4
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Doug Anderson
dianders@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-CC: Venkat Thogaru
thogaru@qualcomm.corp-partner.google.com
Gerrit-CC: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Wed, 30 Nov 2022 23:27:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment