[coreboot-gerrit] [M] Change in coreboot[master]: mb/google/herobrine: Only retrieve sku_id from EC once

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70162 )

Change subject: mb/google/herobrine: Only retrieve sku_id from EC once
......................................................................

Patch Set 4:

(1 comment)

File src/mainboard/google/herobrine/boardid.c:

https://review.coreboot.org/c/coreboot/+/70162/comment/dbef7480_57c1dc78 
PS2, Line 28: 	printk(BIOS_INFO, "BoardID :%d - "
> Also, I put in an early exit like in sku_id because I figured that it wouldn't be useful setting up  […]

The compiler should be smart enough to move that array setup into the if-block to avoid extra cycles in the case where it's already cached. But no harm in making it more explicit.