View Change

1 comment:

• File src/mainboard/google/herobrine/boardid.c:

  • Patch Set #2, Line 28: printk(BIOS_INFO, "BoardID :%d - "

    Also, I put in an early exit like in sku_id because I figured that it wouldn't be useful setting up […]

    The compiler should be smart enough to move that array setup into the if-block to avoid extra cycles in the case where it's already cached. But no harm in making it more explicit.

To view, visit change 70162. To unsubscribe, or for help writing mail filters, visit settings.