Change in coreboot[master]: mb/google/volteer: Fix world-facing camera LED is alway on issue
Daniel Kang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is alway on issue ......................................................................
mb/google/volteer: Fix world-facing camera LED is alway on issue
Volteer world-facing camera has a privacy LED and it is supposed to be turned on only when the camera is being used. But the LED is always on and this is to fix the issue.
BUG=b:160341981 BRANCH=none TEST=Build and boot volteer proto 2 board. Start a camera app and check the world-facing camera LED is only turned on only when the camera is working.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I564690baffddfdd0f998525992643aaf16ba4b02 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/42985/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index a5756626..9f7b3e0 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -163,6 +163,9 @@ CTXS(GPP_D4) #endif
+ /* Pull SNRPWR_EN high */ + STXS(GPP_H14) + /* Pull PWREN high */ STXS(GPP_H20) Sleep(2) /* reset pulse width */ @@ -196,6 +199,9 @@ /* Pull PWREN low */ CTXS(GPP_H20)
+ /* Pull SNRPWR_EN low */ + CTXS(GPP_H14) + Store(0,STA) } }
Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is alway on issue ......................................................................
Patch Set 1: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is alway on issue ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42985/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42985/1//COMMIT_MSG@11 PS1, Line 11: is always on and this is to fix the issue. Please describe, what you are changing.
What does *SNR* stand for?
Daniel H Kang has uploaded a new patch set (#2) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is alway on issue ......................................................................
mb/google/volteer: Fix world-facing camera LED is alway on issue
Volteer world-facing camera has a privacy LED and it is supposed to be turned on only when the camera is being used. But the LED is always on and this is to fix the issue. RCAM_SNR_PWR_EN (RearCAMera_SeNsoR_PoWeR_ENable) GPIO, which controls the world-facing camera LED, was not in the power up and down sequence definitions and this caused the issue.
BUG=b:160341981 BRANCH=none TEST=Build and boot volteer proto 2 board. Start a camera app and check the world-facing camera LED is only turned on only when the camera is working.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I564690baffddfdd0f998525992643aaf16ba4b02 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/42985/2
Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is alway on issue ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42985/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42985/1//COMMIT_MSG@11 PS1, Line 11: is always on and this is to fix the issue.
Please describe, what you are changing. […]
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is alway on issue ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42985/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42985/2//COMMIT_MSG@7 PS2, Line 7: alway alway*s*
https://review.coreboot.org/c/coreboot/+/42985/2//COMMIT_MSG@12 PS2, Line 12: RCAM_SNR_PWR_EN (RearCAMera_SeNsoR_PoWeR_ENable) GPIO, which controls the world-facing camera LED, was not in the power up and down sequence definitions and this caused the issue. Wrap at 72 characters
Daniel H Kang has uploaded a new patch set (#3) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is always on issue ......................................................................
mb/google/volteer: Fix world-facing camera LED is always on issue
Volteer world-facing camera has a privacy LED and it is supposed to be turned on only when the camera is being used. But the LED is always on and this is to fix the issue. RCAM_SNR_PWR_EN (RearCAMera_SeNsoR_PoWeR_ENable) GPIO, which controls the world-facing camera LED, was not in the power up and down sequence definitions and this caused the issue.
BUG=b:160341981 BRANCH=none TEST=Build and boot volteer proto 2 board. Start a camera app and check the world-facing camera LED is only turned on only when the camera is working.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I564690baffddfdd0f998525992643aaf16ba4b02 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/42985/3
Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is always on issue ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42985/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42985/2//COMMIT_MSG@7 PS2, Line 7: alway
alway*s*
Done
https://review.coreboot.org/c/coreboot/+/42985/2//COMMIT_MSG@12 PS2, Line 12: RCAM_SNR_PWR_EN (RearCAMera_SeNsoR_PoWeR_ENable) GPIO, which controls the world-facing camera LED, was not in the power up and down sequence definitions and this caused the issue.
Wrap at 72 characters
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is always on issue ......................................................................
Patch Set 3: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is always on issue ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42985/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42985/3//COMMIT_MSG@13 PS3, Line 13: power up Nit: powerup or power-up
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is always on issue ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/42985/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42985/3//COMMIT_MSG@9 PS3, Line 9: Volteer world-facing camera has a privacy LED and it is supposed Silly question: for new designs, why not just wire the LED to the same GPIO that controls the camera power? Or is there some technical limitation that prevents it?
https://review.coreboot.org/c/coreboot/+/42985/3//COMMIT_MSG@13 PS3, Line 13: power up
Nit: powerup or power-up
Not sure if it would look too good with the "and down" part that goes after it
Daniel H Kang has uploaded a new patch set (#4) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is always on issue ......................................................................
mb/google/volteer: Fix world-facing camera LED is always on issue
Volteer world-facing camera has a privacy LED and it is supposed to be turned on only when the camera is being used. But the LED is always on and this is to fix the issue. RCAM_SNR_PWR_EN (RearCAMera_SeNsoR_PoWeR_ENable) GPIO, which controls the world-facing camera LED, was not in the power-up and power-down sequence definitions and this caused the issue.
BUG=b:160341981 BRANCH=none TEST=Build and boot volteer proto 2 board. Start a camera app and check the world-facing camera LED is only turned on only when the camera is working.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I564690baffddfdd0f998525992643aaf16ba4b02 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/42985/4
Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is always on issue ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42985/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42985/3//COMMIT_MSG@9 PS3, Line 9: Volteer world-facing camera has a privacy LED and it is supposed
Silly question: for new designs, why not just wire the LED to the same GPIO that controls the camera […]
Actually, this is a long story. Wiring the LED to the power works with most cases. But during the boot, the LED will lit while the camera is being probed. This can give the users a wrong impression that camera is being used. To fix this issue, both HW/SW should be changed and my understanding is this is for the HW side change.
https://review.coreboot.org/c/coreboot/+/42985/3//COMMIT_MSG@13 PS3, Line 13: power up
Not sure if it would look too good with the "and down" part that goes after it
Done
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is always on issue ......................................................................
Patch Set 4: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is always on issue ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42985/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42985/3//COMMIT_MSG@9 PS3, Line 9: Volteer world-facing camera has a privacy LED and it is supposed
Actually, this is a long story. Wiring the LED to the power works with most cases. […]
Oh, right, that's something I didn't think of.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is always on issue ......................................................................
mb/google/volteer: Fix world-facing camera LED is always on issue
Volteer world-facing camera has a privacy LED and it is supposed to be turned on only when the camera is being used. But the LED is always on and this is to fix the issue. RCAM_SNR_PWR_EN (RearCAMera_SeNsoR_PoWeR_ENable) GPIO, which controls the world-facing camera LED, was not in the power-up and power-down sequence definitions and this caused the issue.
BUG=b:160341981 BRANCH=none TEST=Build and boot volteer proto 2 board. Start a camera app and check the world-facing camera LED is only turned on only when the camera is working.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I564690baffddfdd0f998525992643aaf16ba4b02 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42985 Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Daniel H Kang daniel.h.kang@intel.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, but someone else must approve Wonkyu Kim: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved Daniel H Kang: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index a5756626..9f7b3e0 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -163,6 +163,9 @@ CTXS(GPP_D4) #endif
+ /* Pull SNRPWR_EN high */ + STXS(GPP_H14) + /* Pull PWREN high */ STXS(GPP_H20) Sleep(2) /* reset pulse width */ @@ -196,6 +199,9 @@ /* Pull PWREN low */ CTXS(GPP_H20)
+ /* Pull SNRPWR_EN low */ + CTXS(GPP_H14) + Store(0,STA) } }
-
Angel Pons (Code Review) -
Daniel H Kang (Code Review)
-
Daniel Kang (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)
-
Wonkyu Kim (Code Review)