Change in coreboot[master]: mb/google/volteer: Change ov2740 HID to match with Windows definition

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Daniel Kang (Code Review)

2 Jul 2020 2 Jul '20

9:03 a.m.

Daniel Kang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43006 )

Change subject: mb/google/volteer: Change ov2740 HID to match with Windows definition ......................................................................

mb/google/volteer: Change ov2740 HID to match with Windows definition

Change HID of ov2740 to INT3474 so that it matches with the Windows defintion.

BUG=b:160334865 BRANCH=none TEST=User-facing camera should work with the driver which set the HID as INT3474

Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I10e98d32899f31d91c1cc7ddfa099af73d8aef37 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/43006/1

diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index 9f7b3e0..dad762a 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -495,7 +495,7 @@

Device (CAM1) { - Name (_HID, "OVTI2740") /* _HID: Hardware ID */ + Name (_HID, "INT3474") /* _HID: Hardware ID */ Name (_UID, Zero) /* _UID: Unique ID */ Name (_DDN, "Ov 2740 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Paul Menzel (Code Review)

2 Jul 2 Jul

5:57 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43006 )

Change subject: mb/google/volteer: Change ov2740 HID to match with Windows definition ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43006/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43006/1//COMMIT_MSG@15 PS1, Line 15: as INT3474 With what Microsoft Windows version did you test?

Did it work with GNU/Linux before?

Daniel H Kang (Code Review)

3 Jul 3 Jul

5:44 a.m.

Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43006 )

Change subject: mb/google/volteer: Change ov2740 HID to match with Windows definition ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/43006/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43006/1//COMMIT_MSG@15 PS1, Line 15: as INT3474

...

With what Microsoft Windows version did you test? […]

There was a review comment for ov2740 that Windows already set the HID as INT3474 and suggested to set the same thing for Chrome. So I don't test Windows side, but only Chrome. And previously, both the driver and ACPI set the same HID, OVTI2740, so it worked. Now the driver changed the HID as INT3474 so ACPI also need to set the same HID.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10e98d32899f31d91c1cc7ddfa099af73d8aef37 Gerrit-Change-Number: 43006 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Daniel H Kang daniel.h.kang@intel.corp-partner.google.com Gerrit-Reviewer: Tian Shu Qiu tian.shu.qiu@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Alex Levin levinale@google.com Gerrit-CC: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-CC: Nick Vaccaro nvaccaro@chromium.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Comment-Date: Fri, 03 Jul 2020 05:44:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Paul Menzel (Code Review)

6:25 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43006 )

Change subject: mb/google/volteer: Change ov2740 HID to match with Windows definition ......................................................................

Patch Set 1:

(1 comment)

Authors normally do not add a review score to their own change-sets.

https://review.coreboot.org/c/coreboot/+/43006/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43006/1//COMMIT_MSG@15 PS1, Line 15: as INT3474 Please mention that in the commit message.

...

And previously, both the driver and ACPI set the same HID, OVTI2740, so it worked. Now the driver changed the HID as INT3474 so ACPI also need to set the same HID.

Please always specify what driver from which OS you mean? If you mean the Linux kernel driver in Chromium OS driver, please add the URL of the commit changing the Linux driver (… further up in the commit message description).

-- To view, visit https://review.coreboot.org/c/coreboot/+/43006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10e98d32899f31d91c1cc7ddfa099af73d8aef37 Gerrit-Change-Number: 43006 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Tian Shu Qiu tian.shu.qiu@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Alex Levin levinale@google.com Gerrit-CC: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-CC: Nick Vaccaro nvaccaro@chromium.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Comment-Date: Fri, 03 Jul 2020 06:25:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Daniel H Kang daniel.h.kang@intel.corp-partner.google.com Gerrit-MessageType: comment

Daniel H Kang (Code Review)

6:34 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: Change ov2740 HID of Chrome driver to match with W...

Daniel H Kang has uploaded a new patch set (#2) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/43006 )

Change subject: mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition ......................................................................

mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition

There was a review comment for Chrome ov2740 driver that Windows already set the HID as INT3474 and suggested to have the same value for Chrome.

The upstreamed driver code has INT3474 as HID and this patch is to set the same HID in ACPI configuration.

https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2...

BUG=b:160334865 BRANCH=none TEST=User-facing camera should work with the driver which set the HID as INT3474

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/43006/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10e98d32899f31d91c1cc7ddfa099af73d8aef37 Gerrit-Change-Number: 43006 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Tian Shu Qiu tian.shu.qiu@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Alex Levin levinale@google.com Gerrit-CC: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-CC: Nick Vaccaro nvaccaro@chromium.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com Gerrit-MessageType: newpatchset

Daniel H Kang (Code Review)

6:41 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: Change ov2740 HID of Chrome driver to match with W...

Daniel H Kang has uploaded a new patch set (#3) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/43006 )

Change subject: mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition ......................................................................

mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition

There was a review comment for Chromium Linux ov2740 driver that Windows driver already set the HID as INT3474 and suggested to have the same value for Chrome.

The upstreamed Linux driver code has INT3474 as HID and this patch is to set the same HID in ACPI configuration.

https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2...

BUG=b:160334865 BRANCH=none TEST=User-facing camera should work with the driver which set the HID as INT3474

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/43006/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/43006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10e98d32899f31d91c1cc7ddfa099af73d8aef37 Gerrit-Change-Number: 43006 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Tian Shu Qiu tian.shu.qiu@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Alex Levin levinale@google.com Gerrit-CC: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-CC: Nick Vaccaro nvaccaro@chromium.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com Gerrit-MessageType: newpatchset

Daniel H Kang (Code Review)

6:42 a.m.

New subject: Change in coreboot[master]: mb/google/volteer: Change ov2740 HID of Chrome driver to match with W...

Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43006 )

Change subject: mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43006/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43006/1//COMMIT_MSG@15 PS1, Line 15: as INT3474

...

Please mention that in the commit message. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10e98d32899f31d91c1cc7ddfa099af73d8aef37 Gerrit-Change-Number: 43006 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Tian Shu Qiu tian.shu.qiu@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Alex Levin levinale@google.com Gerrit-CC: Daniel H Kang daniel.h.kang@intel.corp-partner.google.com Gerrit-CC: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-CC: Nick Vaccaro nvaccaro@chromium.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Comment-Date: Fri, 03 Jul 2020 06:42:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: Daniel H Kang daniel.h.kang@intel.corp-partner.google.com Gerrit-MessageType: comment

Daniel H Kang (Code Review)

6 Jul 6 Jul

7:28 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Change ov2740 HID of Chrome driver to match with W...

Daniel H Kang has uploaded a new patch set (#4) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/43006 )

Change subject: mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition ......................................................................

mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition

There was a review comment for Chromium Linux ov2740 driver that Windows driver already set the HID as INT3474 and suggested to have the same value for Chrome.

The upstreamed Linux driver code has INT3474 as HID and this patch is to set the same HID in ACPI configuration.

https://chromium-review.googlesource.com/c/chromiumos/third_party/ kernel/+/2051724

BUG=b:160334865 BRANCH=none TEST=User-facing camera should work with the driver which set the HID as INT3474

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/43006/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/43006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10e98d32899f31d91c1cc7ddfa099af73d8aef37 Gerrit-Change-Number: 43006 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Tian Shu Qiu tian.shu.qiu@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Alex Levin levinale@google.com Gerrit-CC: Daniel H Kang daniel.h.kang@intel.corp-partner.google.com Gerrit-CC: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-CC: Nick Vaccaro nvaccaro@chromium.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

8:23 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Change ov2740 HID of Chrome driver to match with W...

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43006 )

Change subject: mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43006/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43006/4//COMMIT_MSG@17 PS4, Line 17: https://chromium-review.googlesource.com/c/chromiumos/third_party/ I think the link to the upstream commit may be more appropriate here: https://patchwork.kernel.org/patch/11540753/

-- To view, visit https://review.coreboot.org/c/coreboot/+/43006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10e98d32899f31d91c1cc7ddfa099af73d8aef37 Gerrit-Change-Number: 43006 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Tian Shu Qiu tian.shu.qiu@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Alex Levin levinale@google.com Gerrit-CC: Daniel H Kang daniel.h.kang@intel.corp-partner.google.com Gerrit-CC: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-CC: Nick Vaccaro nvaccaro@chromium.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Comment-Date: Mon, 06 Jul 2020 20:23:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Daniel H Kang (Code Review)

8:37 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Change ov2740 HID of Chrome driver to match with W...

Daniel H Kang has uploaded a new patch set (#5) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/43006 )

Change subject: mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition ......................................................................

mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition

There was a review comment for Chromium Linux ov2740 driver that Windows driver already set the HID as INT3474 and suggested to have the same value for Chrome.

The upstreamed Linux driver code has INT3474 as HID and this patch is to set the same HID in ACPI configuration.

https://patchwork.kernel.org/patch/11540753/

BUG=b:160334865 BRANCH=none TEST=User-facing camera should work with the driver which set the HID as INT3474

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/43006/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/43006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10e98d32899f31d91c1cc7ddfa099af73d8aef37 Gerrit-Change-Number: 43006 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Tian Shu Qiu tian.shu.qiu@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Alex Levin levinale@google.com Gerrit-CC: Daniel H Kang daniel.h.kang@intel.corp-partner.google.com Gerrit-CC: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-CC: Nick Vaccaro nvaccaro@chromium.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com Gerrit-MessageType: newpatchset

Daniel H Kang (Code Review)

8:37 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Change ov2740 HID of Chrome driver to match with W...

Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43006 )

Change subject: mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43006/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/43006/4//COMMIT_MSG@17 PS4, Line 17: https://chromium-review.googlesource.com/c/chromiumos/third_party/

...

I think the link to the upstream commit may be more appropriate here: https://patchwork.kernel. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10e98d32899f31d91c1cc7ddfa099af73d8aef37 Gerrit-Change-Number: 43006 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Daniel H Kang daniel.h.kang@intel.corp-partner.google.com Gerrit-Reviewer: Tian Shu Qiu tian.shu.qiu@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Alex Levin levinale@google.com Gerrit-CC: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-CC: Nick Vaccaro nvaccaro@chromium.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Comment-Date: Mon, 06 Jul 2020 20:37:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

9:56 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Change ov2740 HID of Chrome driver to match with W...

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43006 )

Change subject: mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/43006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10e98d32899f31d91c1cc7ddfa099af73d8aef37 Gerrit-Change-Number: 43006 Gerrit-PatchSet: 5 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Daniel H Kang daniel.h.kang@intel.corp-partner.google.com Gerrit-Reviewer: Tian Shu Qiu tian.shu.qiu@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Alex Levin levinale@google.com Gerrit-CC: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-CC: Nick Vaccaro nvaccaro@chromium.org Gerrit-CC: Patrick Georgi pgeorgi@google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com Gerrit-Comment-Date: Mon, 06 Jul 2020 21:56:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

7 Jul 7 Jul

5:25 p.m.

New subject: Change in coreboot[master]: mb/google/volteer: Change ov2740 HID of Chrome driver to match with W...

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43006 )

Change subject: mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition ......................................................................

mb/google/volteer: Change ov2740 HID of Chrome driver to match with Windows definition

There was a review comment for Chromium Linux ov2740 driver that Windows driver already set the HID as INT3474 and suggested to have the same value for Chrome.

The upstreamed Linux driver code has INT3474 as HID and this patch is to set the same HID in ACPI configuration.

https://patchwork.kernel.org/patch/11540753/

BUG=b:160334865 BRANCH=none TEST=User-facing camera should work with the driver which set the HID as INT3474

Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I10e98d32899f31d91c1cc7ddfa099af73d8aef37 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43006 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Daniel H Kang daniel.h.kang@intel.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved Daniel H Kang: Looks good to me, but someone else must approve

-- To view, visit https://review.coreboot.org/c/coreboot/+/43006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10e98d32899f31d91c1cc7ddfa099af73d8aef37 Gerrit-Change-Number: 43006 Gerrit-PatchSet: 6 Gerrit-Owner: Daniel Kang daniel.h.kang@intel.com Gerrit-Reviewer: Daniel H Kang daniel.h.kang@intel.corp-partner.google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tian Shu Qiu tian.shu.qiu@intel.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-CC: Alex Levin levinale@google.com Gerrit-CC: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-CC: Nick Vaccaro nvaccaro@chromium.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com Gerrit-MessageType: merged

1412

days inactive

1417

days old

coreboot-gerrit@coreboot.org

12 comments

5 participants

tags (0)

participants (5)

Daniel H Kang (Code Review)
Daniel Kang (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
Tim Wawrzynczak (Code Review)