Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43006 )
Change subject: mb/google/volteer: Change ov2740 HID to match with Windows definition
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43006/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43006/1//COMMIT_MSG@15
PS1, Line 15: as INT3474
With what Microsoft Windows version did you test? […]
There was a review comment for ov2740 that Windows already set the HID as INT3474 and suggested to set the same thing for Chrome. So I don't test Windows side, but only Chrome. And previously, both the driver and ACPI set the same HID, OVTI2740, so it worked. Now the driver changed the HID as INT3474 so ACPI also need to set the same HID.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43006
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I10e98d32899f31d91c1cc7ddfa099af73d8aef37
Gerrit-Change-Number: 43006
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Daniel H Kang
daniel.h.kang@intel.corp-partner.google.com
Gerrit-Reviewer: Tian Shu Qiu
tian.shu.qiu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Alex Levin
levinale@google.com
Gerrit-CC: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-CC: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Comment-Date: Fri, 03 Jul 2020 05:44:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment