Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is always on issue
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/42985/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42985/3//COMMIT_MSG@9
PS3, Line 9: Volteer world-facing camera has a privacy LED and it is supposed
Silly question: for new designs, why not just wire the LED to the same GPIO that controls the camera power? Or is there some technical limitation that prevents it?
https://review.coreboot.org/c/coreboot/+/42985/3//COMMIT_MSG@13
PS3, Line 13: power up
Nit: powerup or power-up
Not sure if it would look too good with the "and down" part that goes after it
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42985
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I564690baffddfdd0f998525992643aaf16ba4b02
Gerrit-Change-Number: 42985
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alex Levin
levinale@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Daniel H Kang
daniel.h.kang@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 07 Jul 2020 13:14:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment