View Change
2 comments:
Commit Message:
Patch Set #3, Line 9: Volteer world-facing camera has a privacy LED and it is supposed
Silly question: for new designs, why not just wire the LED to the same GPIO that controls the camera […]
Actually, this is a long story. Wiring the LED to the power works with most cases. But during the boot, the LED will lit while the camera is being probed. This can give the users a wrong impression that camera is being used. To fix this issue, both HW/SW should be changed and my understanding is this is for the HW side change.
Patch Set #3, Line 13: power up
Not sure if it would look too good with the "and down" part that goes after it
Done
To view, visit change 42985. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I564690baffddfdd0f998525992643aaf16ba4b02
Gerrit-Change-Number: 42985
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Kang <daniel.h.kang@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Alex Levin <levinale@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Daniel H Kang <daniel.h.kang@intel.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh@gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 07 Jul 2020 16:33:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment