Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42985 )
Change subject: mb/google/volteer: Fix world-facing camera LED is always on issue
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42985/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42985/2//COMMIT_MSG@7
PS2, Line 7: alway
alway*s*
Done
https://review.coreboot.org/c/coreboot/+/42985/2//COMMIT_MSG@12
PS2, Line 12: RCAM_SNR_PWR_EN (RearCAMera_SeNsoR_PoWeR_ENable) GPIO, which controls the world-facing camera LED, was not in the power up and down sequence definitions and this caused the issue.
Wrap at 72 characters
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42985
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I564690baffddfdd0f998525992643aaf16ba4b02
Gerrit-Change-Number: 42985
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Alex Levin
levinale@chromium.org
Gerrit-Reviewer: Daniel H Kang
daniel.h.kang@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 06 Jul 2020 19:22:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment