Change in coreboot[master]: RFC) src/acpi: Update license headers to SPDX

[Martin Roth (Code Review)]

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36176 )

Change subject: RFC) src/acpi: Update license headers to SPDX
......................................................................

RFC) src/acpi: Update license headers to SPDX

While I was working on updating the headers to move copyrights into
the AUTHORS file, I got a request to switch to SPDX headers as well.

Linux has moved completely to SPDX headers, which are easier to
maintain, have good definitions, are very short, and can be checked
automatically.  This is completely unlike our current header situation.

Signed-off-by: Martin Roth 
Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3
---
M src/acpi/Kconfig
M src/acpi/Makefile.inc
M src/acpi/sata.c
M src/acpi/sata.h
4 files changed, 9 insertions(+), 24 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/36176/1

diff --git a/src/acpi/Kconfig b/src/acpi/Kconfig
index 72cfff5..3c6aeb1 100644
--- a/src/acpi/Kconfig
+++ b/src/acpi/Kconfig
@@ -1,3 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0-only
+# This file is part of the coreboot project.

config ACPI_SATA_GENERATOR
    bool
diff --git a/src/acpi/Makefile.inc b/src/acpi/Makefile.inc
index 53ac679..7c2092d 100644
--- a/src/acpi/Makefile.inc
+++ b/src/acpi/Makefile.inc
@@ -1 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0-only
+# This file is part of the coreboot project.
+
 ramstage-$(CONFIG_ACPI_SATA_GENERATOR) += sata.c
diff --git a/src/acpi/sata.c b/src/acpi/sata.c
index d7fcbd6..ae43e7d 100644
--- a/src/acpi/sata.c
+++ b/src/acpi/sata.c
@@ -1,15 +1,5 @@
-/*
- * This file is part of the coreboot project.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
+// SPDX-License-Identifier: GPL-2.0-only
+/* This file is part of the coreboot project. */

#include "sata.h"

diff --git a/src/acpi/sata.h b/src/acpi/sata.h
index fecf4c6..04cd80c 100644
--- a/src/acpi/sata.h
+++ b/src/acpi/sata.h
@@ -1,15 +1,5 @@
-/*
- * This file is part of the coreboot project.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
+// SPDX-License-Identifier: GPL-2.0-only
+/* This file is part of the coreboot project. */

#ifndef __ACPI_SATA_H__
 #define __ACPI_SATA_H__

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 )

Change subject: RFC) src/acpi: Update license headers to SPDX
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

I like it somehow. Though, don't remember why we decided
against it, the last time it came up.

https://review.coreboot.org/c/coreboot/+/36176/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36176/1//COMMIT_MSG@12 
PS1, Line 12: Linux has moved completely to SPDX headers
I must have missed that. Or at least the DRM drivers I visit most often
must have ;)

https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h 
File src/acpi/sata.h:

https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h@1 
PS1, Line 1: // SPDX-License-Identifier: GPL-2.0-only
No strong feelings about the SPDX. But is the C++ style // comment necessary?
I don't mind too much, but mixing the styles seems odd.

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 )

Change subject: RFC) src/acpi: Update license headers to SPDX
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h 
File src/acpi/sata.h:

https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h@1 
PS1, Line 1: // SPDX-License-Identifier: GPL-2.0-only
> No strong feelings about the SPDX. But is the C++ style // comment necessary? […]

I'm fine with either style.  This is how it is in the Linux kernel, so I copied that.  If we'd prefer C style comments instead, that works for me.

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 )

Change subject: RFC) src/acpi: Update license headers to SPDX
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h 
File src/acpi/sata.h:

https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h@1 
PS1, Line 1: // SPDX-License-Identifier: GPL-2.0-only
> I'm fine with either style.  This is how it is in the Linux kernel, so I copied that. […]

I'd go with C style, too, in a comment of its own to denote that it's a statement in itself:
/* SPDX- ... */
/* This file is part ... */

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 )

Change subject: RFC) src/acpi: Update license headers to SPDX
......................................................................

Patch Set 1:

+1. I prefer to the SPDX terseness.

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 )

Change subject: RFC) src/acpi: Update license headers to SPDX
......................................................................

Patch Set 1: Code-Review-1

(1 comment)

https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h 
File src/acpi/sata.h:

https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h@1 
PS1, Line 1: // SPDX-License-Identifier: GPL-2.0-only
> I'd go with C style, too, in a comment of its own to denote that it's a statement in itself: […]

+1 to Patrick's suggestion.

Looking around at Linux, they seem inconsistent w.r.t. C vs. C++ style comments for the SPDX line. However, they are consistent with making the SPDX line its own comment, even if it mixes the two styles (which I think is ugly). I prefer C-style for both.

[Martin Roth (Code Review)]

Hello Kyösti Mälkki, Aaron Durbin, Julius Werner, Arthur Heymans, Stefan Reinauer, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Werner Zeh, ron minnich, David Hendricks, Philipp Deppenwiese, Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36176

to look at the new patch set (#2).

Change subject: RFC) src/acpi: Update license headers to SPDX
......................................................................

RFC) src/acpi: Update license headers to SPDX

While I was working on updating the headers to move copyrights into
the AUTHORS file, I got a request to switch to SPDX headers as well.

Linux has moved completely to SPDX headers, which are easier to
maintain, have good definitions, are very short, and can be checked
automatically.  This is completely unlike our current header situation.

Signed-off-by: Martin Roth 
Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3
---
M src/acpi/Kconfig
M src/acpi/Makefile.inc
M src/acpi/sata.c
M src/acpi/sata.h
4 files changed, 9 insertions(+), 24 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/36176/2

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 )

Change subject: RFC) src/acpi: Update license headers to SPDX
......................................................................

Patch Set 2: Code-Review+1

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 )

Change subject: RFC) src/acpi: Update license headers to SPDX
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: src/acpi: Update license headers to SPDX

[Martin Roth (Code Review)]

Hello Kyösti Mälkki, Aaron Durbin, Julius Werner, Arthur Heymans, Stefan Reinauer, Paul Menzel, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Werner Zeh, ron minnich, David Hendricks, Philipp Deppenwiese, Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36176

to look at the new patch set (#3).

Change subject: src/acpi: Update license headers to SPDX
......................................................................

src/acpi: Update license headers to SPDX

While I was working on updating the headers to move copyrights into
the AUTHORS file, I got a request to switch to SPDX headers as well.

Linux has moved completely to SPDX headers, which are easier to
maintain, have good definitions, are very short, and can be checked
automatically.  This is completely unlike our current header situation.

Signed-off-by: Martin Roth 
Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3
---
M src/acpi/Kconfig
M src/acpi/Makefile.inc
M src/acpi/sata.c
M src/acpi/sata.h
4 files changed, 9 insertions(+), 24 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/36176/3

Change in coreboot[master]: src/acpi: Update license headers to SPDX

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 )

Change subject: src/acpi: Update license headers to SPDX
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: src/acpi: Update license headers to SPDX

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 )

Change subject: src/acpi: Update license headers to SPDX
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h 
File src/acpi/sata.h:

https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h@1 
PS1, Line 1: // SPDX-License-Identifier: GPL-2.0-only
> +1 to Patrick's suggestion. […]

Done

Change in coreboot[master]: src/acpi: Update license headers to SPDX

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 )

Change subject: src/acpi: Update license headers to SPDX
......................................................................

Patch Set 4: Code-Review+2

Change in coreboot[master]: src/acpi: Update license headers to SPDX

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36176 )

Change subject: src/acpi: Update license headers to SPDX
......................................................................

src/acpi: Update license headers to SPDX

While I was working on updating the headers to move copyrights into
the AUTHORS file, I got a request to switch to SPDX headers as well.

Linux has moved completely to SPDX headers, which are easier to
maintain, have good definitions, are very short, and can be checked
automatically.  This is completely unlike our current header situation.

Signed-off-by: Martin Roth 
Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36176
Tested-by: build bot (Jenkins) 
Reviewed-by: Werner Zeh 
Reviewed-by: David Hendricks 
---
M src/acpi/Kconfig
M src/acpi/Makefile.inc
M src/acpi/sata.c
M src/acpi/sata.h
4 files changed, 9 insertions(+), 24 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  David Hendricks: Looks good to me, approved
  Werner Zeh: Looks good to me, approved

diff --git a/src/acpi/Kconfig b/src/acpi/Kconfig
index 72cfff5..3c6aeb1 100644
--- a/src/acpi/Kconfig
+++ b/src/acpi/Kconfig
@@ -1,3 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0-only
+# This file is part of the coreboot project.

config ACPI_SATA_GENERATOR
    bool
diff --git a/src/acpi/Makefile.inc b/src/acpi/Makefile.inc
index 53ac679..7c2092d 100644
--- a/src/acpi/Makefile.inc
+++ b/src/acpi/Makefile.inc
@@ -1 +1,4 @@
+# SPDX-License-Identifier: GPL-2.0-only
+# This file is part of the coreboot project.
+
 ramstage-$(CONFIG_ACPI_SATA_GENERATOR) += sata.c
diff --git a/src/acpi/sata.c b/src/acpi/sata.c
index d7fcbd6..f2b3811 100644
--- a/src/acpi/sata.c
+++ b/src/acpi/sata.c
@@ -1,15 +1,5 @@
-/*
- * This file is part of the coreboot project.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
+/* SPDX-License-Identifier: GPL-2.0-only */
+/* This file is part of the coreboot project. */

#include "sata.h"

diff --git a/src/acpi/sata.h b/src/acpi/sata.h
index fecf4c6..5ca2eac 100644
--- a/src/acpi/sata.h
+++ b/src/acpi/sata.h
@@ -1,15 +1,5 @@
-/*
- * This file is part of the coreboot project.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
+/* SPDX-License-Identifier: GPL-2.0-only */
+/* This file is part of the coreboot project. */

#ifndef __ACPI_SATA_H__
 #define __ACPI_SATA_H__