Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38037 )
Change subject: lib/: Drop generic_dump_spd ......................................................................
lib/: Drop generic_dump_spd
Not built, relies on SMBUS for SPD and we do not have a globally defined spd_read_byte() prototype.
Change-Id: Ifb9d3aa31207cb5b99f475b70f52a03aca73432b Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- D src/lib/generic_dump_spd.c 1 file changed, 0 insertions(+), 80 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/38037/1
diff --git a/src/lib/generic_dump_spd.c b/src/lib/generic_dump_spd.c deleted file mode 100644 index fdde026..0000000 --- a/src/lib/generic_dump_spd.c +++ /dev/null @@ -1,80 +0,0 @@ -/* - * This code is derived from the Opteron boards' debug.c. - * It should go away either there or here, depending what fits better. - */ - -#include <console/console.h> - -static void dump_spd_registers(const struct mem_controller *ctrl) -{ - int i; - printk(BIOS_DEBUG, "\n"); - for (i = 0; i < 4; i++) { - unsigned int device; - device = ctrl->channel0[i]; - if (device) { - int j; - printk(BIOS_DEBUG, "dimm: %02x.0: %02x", i, device); - for (j = 0; j < 256; j++) { - int status; - unsigned int char byte; - if ((j & 0xf) == 0) - printk(BIOS_DEBUG, "\n%02x: ", j); - status = spd_read_byte(device, j); - if (status < 0) { - printk(BIOS_DEBUG, "bad device\n"); - break; - } - byte = status & 0xff; - printk(BIOS_DEBUG, "%02x ", byte); - } - printk(BIOS_DEBUG, "\n"); - } - device = ctrl->channel1[i]; - if (device) { - int j; - printk(BIOS_DEBUG, "dimm: %02x.1: %02x", i, device); - for (j = 0; j < 256; j++) { - int status; - unsigned int char byte; - if ((j & 0xf) == 0) - printk(BIOS_DEBUG, "\n%02x: "); - status = spd_read_byte(device, j); - if (status < 0) { - printk(BIOS_DEBUG, "bad device\n"); - break; - } - byte = status & 0xff; - printk(BIOS_DEBUG, "%02x ", byte); - } - printk(BIOS_DEBUG, "\n"); - } - } -} - -#if 0 -void dump_spd_registers(void) -{ - unsigned int device; - device = SMBUS_MEM_DEVICE_START; - printk(BIOS_DEBUG, "\n"); - while (device <= SMBUS_MEM_DEVICE_END) { - int status = 0; - int i; - printk(BIOS_DEBUG, "dimm %02x", device); - for (i = 0; (i < 256) && (status == 0); i++) { - unsigned int char byte; - if ((i % 20) == 0) - printk(BIOS_DEBUG, "\n%3d: ", i); - status = smbus_read_byte(device, i, &byte); - if (status != 0) { - printk(BIOS_DEBUG, "bad device\n"); - continue; - } - printk(BIOS_DEBUG, "%02x ", byte); - } - device += SMBUS_MEM_DEVICE_INC; - printk(BIOS_DEBUG, "\n"); - } -} -#endif
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38037 )
Change subject: lib/: Drop generic_dump_spd ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38037 )
Change subject: lib/: Drop generic_dump_spd ......................................................................
lib/: Drop generic_dump_spd
Not built, relies on SMBUS for SPD and we do not have a globally defined spd_read_byte() prototype.
Change-Id: Ifb9d3aa31207cb5b99f475b70f52a03aca73432b Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38037 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- D src/lib/generic_dump_spd.c 1 file changed, 0 insertions(+), 80 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/lib/generic_dump_spd.c b/src/lib/generic_dump_spd.c deleted file mode 100644 index fdde026..0000000 --- a/src/lib/generic_dump_spd.c +++ /dev/null @@ -1,80 +0,0 @@ -/* - * This code is derived from the Opteron boards' debug.c. - * It should go away either there or here, depending what fits better. - */ - -#include <console/console.h> - -static void dump_spd_registers(const struct mem_controller *ctrl) -{ - int i; - printk(BIOS_DEBUG, "\n"); - for (i = 0; i < 4; i++) { - unsigned int device; - device = ctrl->channel0[i]; - if (device) { - int j; - printk(BIOS_DEBUG, "dimm: %02x.0: %02x", i, device); - for (j = 0; j < 256; j++) { - int status; - unsigned int char byte; - if ((j & 0xf) == 0) - printk(BIOS_DEBUG, "\n%02x: ", j); - status = spd_read_byte(device, j); - if (status < 0) { - printk(BIOS_DEBUG, "bad device\n"); - break; - } - byte = status & 0xff; - printk(BIOS_DEBUG, "%02x ", byte); - } - printk(BIOS_DEBUG, "\n"); - } - device = ctrl->channel1[i]; - if (device) { - int j; - printk(BIOS_DEBUG, "dimm: %02x.1: %02x", i, device); - for (j = 0; j < 256; j++) { - int status; - unsigned int char byte; - if ((j & 0xf) == 0) - printk(BIOS_DEBUG, "\n%02x: "); - status = spd_read_byte(device, j); - if (status < 0) { - printk(BIOS_DEBUG, "bad device\n"); - break; - } - byte = status & 0xff; - printk(BIOS_DEBUG, "%02x ", byte); - } - printk(BIOS_DEBUG, "\n"); - } - } -} - -#if 0 -void dump_spd_registers(void) -{ - unsigned int device; - device = SMBUS_MEM_DEVICE_START; - printk(BIOS_DEBUG, "\n"); - while (device <= SMBUS_MEM_DEVICE_END) { - int status = 0; - int i; - printk(BIOS_DEBUG, "dimm %02x", device); - for (i = 0; (i < 256) && (status == 0); i++) { - unsigned int char byte; - if ((i % 20) == 0) - printk(BIOS_DEBUG, "\n%3d: ", i); - status = smbus_read_byte(device, i, &byte); - if (status != 0) { - printk(BIOS_DEBUG, "bad device\n"); - continue; - } - printk(BIOS_DEBUG, "%02x ", byte); - } - device += SMBUS_MEM_DEVICE_INC; - printk(BIOS_DEBUG, "\n"); - } -} -#endif