
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36176 ) Change subject: RFC) src/acpi: Update license headers to SPDX ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h File src/acpi/sata.h: https://review.coreboot.org/c/coreboot/+/36176/1/src/acpi/sata.h@1 PS1, Line 1: // SPDX-License-Identifier: GPL-2.0-only
I'm fine with either style. This is how it is in the Linux kernel, so I copied that. […] I'd go with C style, too, in a comment of its own to denote that it's a statement in itself: /* SPDX- ... */ /* This file is part ... */
-- To view, visit https://review.coreboot.org/c/coreboot/+/36176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie86d34f7fa7bf7434ad8a38aa1eadcfece7124b3 Gerrit-Change-Number: 36176 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Reviewer: ron minnich <rminnich@gmail.com> Gerrit-Comment-Date: Mon, 21 Oct 2019 16:14:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h@gmx.de> Comment-In-Reply-To: Martin Roth <martinroth@google.com> Gerrit-MessageType: comment