Change in coreboot[master]: drivers/intel/fsp2_0: honour FSP2_0_DISPLAY_LOGO Kconfig

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Aamir Bohra (Code Review)

12 Dec 2019 12 Dec '19

2:08 p.m.

Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37675 )

Change subject: drivers/intel/fsp2_0: honour FSP2_0_DISPLAY_LOGO Kconfig ......................................................................

drivers/intel/fsp2_0: honour FSP2_0_DISPLAY_LOGO Kconfig

The FSP logo support should only compile if board selects FSP2_0_DISPLAY_LOGO

Change-Id: Id92cc733562468a42ceee720861f5a1a4bcae9c3 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/drivers/intel/fsp2_0/silicon_init.c 1 file changed, 1 insertion(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/37675/1

diff --git a/src/drivers/intel/fsp2_0/silicon_init.c b/src/drivers/intel/fsp2_0/silicon_init.c index ebdbdbf..8cd63f2 100644 --- a/src/drivers/intel/fsp2_0/silicon_init.c +++ b/src/drivers/intel/fsp2_0/silicon_init.c @@ -57,13 +57,11 @@ /* Give SoC/mainboard a chance to populate entries */ platform_fsp_silicon_init_params_cb(upd);

-#if (CONFIG(HAVE_FSP_GOP)) - if (CONFIG(FSP2_0_DISPLAY_LOGO)) { +#if (CONFIG(FSP2_0_DISPLAY_LOGO)) upd->FspsConfig.LogoSize = 1 * MiB; logo_entry = cbmem_entry_add(CBMEM_ID_FSP_LOGO, upd->FspsConfig.LogoSize); upd->FspsConfig.LogoPtr = (UINT32)cbmem_entry_start(logo_entry); load_logo(upd); - } #endif

/* Call SiliconInit */

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

Nico Huber (Code Review)

12 Dec 12 Dec

2:27 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37675 )

Change subject: drivers/intel/fsp2_0: honour FSP2_0_DISPLAY_LOGO Kconfig ......................................................................

Patch Set 1:

(1 comment)

Please don't use preprocessor guards unless really necessary. What exactly are you trying to fix?

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... PS1, Line 60: #if (CONFIG(FSP2_0_DISPLAY_LOGO)) I think this should just be `if (CONFIG(FSP2_0_DISPLAY_LOGO))` without any preprocessor guards (Kconfig already takes care of the HAVE_FSP_GOP dependency, which should rather be RUN_FSP_GOP btw. no need to load the logo, if other means to initialize graphics are used). Garbage collection will remove the code here if the config is unset (otherwise we couldn't link, as `logo.c` is also guarded in the `Makefile.inc`).

-- To view, visit https://review.coreboot.org/c/coreboot/+/37675 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id92cc733562468a42ceee720861f5a1a4bcae9c3 Gerrit-Change-Number: 37675 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Thu, 12 Dec 2019 14:27:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Subrata Banik (Code Review)

2:53 p.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37675 )

Change subject: drivers/intel/fsp2_0: honour FSP2_0_DISPLAY_LOGO Kconfig ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... PS1, Line 60: #if (CONFIG(FSP2_0_DISPLAY_LOGO))

...

I think this should just be `if (CONFIG(FSP2_0_DISPLAY_LOGO))` without any […]

note: upd->FspsConfig.LogoPtr is not a FSP architecture UPD that mean this name can't be same across all FSP. now this is without any #if will push FSP to maintain and mandate this UPD name, which might not true.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37675 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id92cc733562468a42ceee720861f5a1a4bcae9c3 Gerrit-Change-Number: 37675 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Thu, 12 Dec 2019 14:53:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Frans Hendriks (Code Review)

2:56 p.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37675 )

Change subject: drivers/intel/fsp2_0: honour FSP2_0_DISPLAY_LOGO Kconfig ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... PS1, Line 60: #if (CONFIG(FSP2_0_DISPLAY_LOGO))

...

note: upd->FspsConfig. […]

See comment on CB:37515 The UPD specific items should be moved to SoC.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37675 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id92cc733562468a42ceee720861f5a1a4bcae9c3 Gerrit-Change-Number: 37675 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Thu, 12 Dec 2019 14:56:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Subrata Banik (Code Review)

3:05 p.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37675 )

Change subject: drivers/intel/fsp2_0: honour FSP2_0_DISPLAY_LOGO Kconfig ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... PS1, Line 60: #if (CONFIG(FSP2_0_DISPLAY_LOGO))

...

See comment on CB:37515 […]

Thanks, are you plan to do that ? if yes, can you please add me ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/37675 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id92cc733562468a42ceee720861f5a1a4bcae9c3 Gerrit-Change-Number: 37675 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-Comment-Date: Thu, 12 Dec 2019 15:05:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Nico Huber (Code Review)

3:06 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37675 )

Change subject: drivers/intel/fsp2_0: honour FSP2_0_DISPLAY_LOGO Kconfig ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... PS1, Line 60: #if (CONFIG(FSP2_0_DISPLAY_LOGO))

...

See comment on CB:37515 […]

Ack, the assignments to `upd->FspsConfig` should move. Also, if not all platforms support this, FSP2_0_DISPLAY_LOGO should have proper dependencies to reflect this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37675 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id92cc733562468a42ceee720861f5a1a4bcae9c3 Gerrit-Change-Number: 37675 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 12 Dec 2019 15:06:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Frans Hendriks (Code Review)

13 Dec 13 Dec

8:12 a.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37675 )

Change subject: drivers/intel/fsp2_0: honour FSP2_0_DISPLAY_LOGO Kconfig ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... PS1, Line 60: #if (CONFIG(FSP2_0_DISPLAY_LOGO))

...

Ack, the assignments to `upd->FspsConfig` should move. Also, if not all […]

Will work on this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37675 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id92cc733562468a42ceee720861f5a1a4bcae9c3 Gerrit-Change-Number: 37675 Gerrit-PatchSet: 1 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 13 Dec 2019 08:12:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Aamir Bohra (Code Review)

2:36 p.m.

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37675 )

Change subject: drivers/intel/fsp2_0: honour FSP2_0_DISPLAY_LOGO Kconfig ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... PS1, Line 60: #if (CONFIG(FSP2_0_DISPLAY_LOGO))

...

Will work on this.

Ok, can you give this CL a -1, to block merge.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37675 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id92cc733562468a42ceee720861f5a1a4bcae9c3 Gerrit-Change-Number: 37675 Gerrit-PatchSet: 2 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 13 Dec 2019 14:36:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Aamir Bohra (Code Review)

3:04 p.m.

New subject: Change in coreboot[master]: drivers/intel/fsp2_0: [DO NOT MERGE]honour FSP2_0_DISPLAY_LOGO Kconfig

Hello Patrick Rudolph, Subrata Banik, Frans Hendriks, Rizwan Qureshi, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37675

to look at the new patch set (#3).

Change subject: drivers/intel/fsp2_0: [DO NOT MERGE]honour FSP2_0_DISPLAY_LOGO Kconfig ......................................................................

drivers/intel/fsp2_0: [DO NOT MERGE]honour FSP2_0_DISPLAY_LOGO Kconfig

The FSP logo support should only compile if board selects FSP2_0_DISPLAY_LOGO

Change-Id: Id92cc733562468a42ceee720861f5a1a4bcae9c3 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/drivers/intel/fsp2_0/silicon_init.c 1 file changed, 1 insertion(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/37675/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/37675 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id92cc733562468a42ceee720861f5a1a4bcae9c3 Gerrit-Change-Number: 37675 Gerrit-PatchSet: 3 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Aamir Bohra (Code Review)

3:14 p.m.

New subject: Change in coreboot[master]: drivers/intel/fsp2_0: [DO NOT MERGE]honour FSP2_0_DISPLAY_LOGO Kconfig

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37675 )

Change subject: drivers/intel/fsp2_0: [DO NOT MERGE]honour FSP2_0_DISPLAY_LOGO Kconfig ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:

https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... PS1, Line 60: #if (CONFIG(FSP2_0_DISPLAY_LOGO))

...

Ok, can you give this CL a -1, to block merge.

Updated the commit message for do not merge

-- To view, visit https://review.coreboot.org/c/coreboot/+/37675 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id92cc733562468a42ceee720861f5a1a4bcae9c3 Gerrit-Change-Number: 37675 Gerrit-PatchSet: 3 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 13 Dec 2019 15:14:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com Comment-In-Reply-To: Aamir Bohra aamir.bohra@intel.com Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Frans Hendriks (Code Review)

16 Dec 16 Dec

12:46 p.m.

New subject: Change in coreboot[master]: drivers/intel/fsp2_0: [DO NOT MERGE]honour FSP2_0_DISPLAY_LOGO Kconfig

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37675 )

Change subject: drivers/intel/fsp2_0: [DO NOT MERGE]honour FSP2_0_DISPLAY_LOGO Kconfig ......................................................................

Patch Set 5: Code-Review-1

-- To view, visit https://review.coreboot.org/c/coreboot/+/37675 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id92cc733562468a42ceee720861f5a1a4bcae9c3 Gerrit-Change-Number: 37675 Gerrit-PatchSet: 5 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 16 Dec 2019 12:46:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Frans Hendriks (Code Review)

18 Dec 18 Dec

6:50 a.m.

New subject: Change in coreboot[master]: drivers/intel/fsp2_0: [DO NOT MERGE]honour FSP2_0_DISPLAY_LOGO Kconfig

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37675 )

Change subject: drivers/intel/fsp2_0: [DO NOT MERGE]honour FSP2_0_DISPLAY_LOGO Kconfig ......................................................................

Patch Set 5:

Patchset to solve the FSP logo support has been uploaded: FSP 1.0: CB:37791 FSP 2.0: CB:37792

-- To view, visit https://review.coreboot.org/c/coreboot/+/37675 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id92cc733562468a42ceee720861f5a1a4bcae9c3 Gerrit-Change-Number: 37675 Gerrit-PatchSet: 5 Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 18 Dec 2019 06:50:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Martin L Roth (Code Review)

7 Aug 7 Aug

8:19 p.m.

New subject: [XS] Change in coreboot[master]: drivers/intel/fsp2_0: [DO NOT MERGE]honour FSP2_0_DISPLAY_LOGO Kconfig

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37675?usp=email )

Change subject: drivers/intel/fsp2_0: [DO NOT MERGE]honour FSP2_0_DISPLAY_LOGO Kconfig ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37675?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id92cc733562468a42ceee720861f5a1a4bcae9c3 Gerrit-Change-Number: 37675 Gerrit-PatchSet: 5 Gerrit-Owner: Aamir Bohra aamirbohra@google.com Gerrit-Reviewer: Aamir Bohra aamirbohra@google.com Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin L Roth gaumless@gmail.com Gerrit-CC: Nico Huber nico.h@gmx.de Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

507

days inactive

1841

days old

coreboot-gerrit@coreboot.org

12 comments

5 participants

tags (0)

participants (5)

Aamir Bohra (Code Review)
Frans Hendriks (Code Review)
Martin L Roth (Code Review)
Nico Huber (Code Review)
Subrata Banik (Code Review)