Please don't use preprocessor guards unless really necessary. What
exactly are you trying to fix?
1 comment:
File src/drivers/intel/fsp2_0/silicon_init.c:
Patch Set #1, Line 60: #if (CONFIG(FSP2_0_DISPLAY_LOGO))
I think this should just be `if (CONFIG(FSP2_0_DISPLAY_LOGO))` without any
preprocessor guards (Kconfig already takes care of the HAVE_FSP_GOP dependency,
which should rather be RUN_FSP_GOP btw. no need to load the logo, if other
means to initialize graphics are used). Garbage collection will remove the
code here if the config is unset (otherwise we couldn't link, as `logo.c`
is also guarded in the `Makefile.inc`).
To view, visit change 37675. To unsubscribe, or for help writing mail filters, visit settings.