12 Dec
2019
12 Dec
'19
12:06 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37675 )
Change subject: drivers/intel/fsp2_0: honour FSP2_0_DISPLAY_LOGO Kconfig ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/37675/1/src/drivers/intel/fsp2_0/si... PS1, Line 60: #if (CONFIG(FSP2_0_DISPLAY_LOGO))
See comment on CB:37515 […]
Ack, the assignments to `upd->FspsConfig` should move. Also, if not all platforms support this, FSP2_0_DISPLAY_LOGO should have proper dependencies to reflect this.
--
To view, visit https://review.coreboot.org/c/coreboot/+/37675
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id92cc733562468a42ceee720861f5a1a4bcae9c3
Gerrit-Change-Number: 37675
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 12 Dec 2019 15:06:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subrata.banik@intel.com
Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment