Change in ...coreboot[master]: soc/intel/cannonlake: Add option for boot frquency

[Lijian Zhao (Code Review)]

Lijian Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30445


Change subject: soc/intel/cannonlake: Add option for boot frquency
......................................................................

soc/intel/cannonlake: Add option for boot frquency

Cannonlake/Coffeelake FSP have options for CPU boot up frequency
selection, expose that in coreboot side.

Signed-off-by: Lijian Zhao <[e-mail]>
Change-Id: I6bd5849122c9035bb7f448acf08e258e8c207013
---
M src/soc/intel/cannonlake/chip.h
M src/soc/intel/cannonlake/romstage/fsp_params.c
2 files changed, 7 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/30445/1

diff --git a/src/soc/intel/cannonlake/chip.h b/src/soc/intel/cannonlake/chip.h
index 3a723d2..7e50a73 100644
--- a/src/soc/intel/cannonlake/chip.h
+++ b/src/soc/intel/cannonlake/chip.h
@@ -110,6 +110,11 @@
 		SaGv_Enabled,
 	} SaGv;
 
+	/* Boot Frequency from reset vector.
+	 * 0: Maximum battery performance, 1: Maximum non-turbo performance, 2:
+	 * Maximum turbo performance @note If 2 is selected, system will start
+	 * with non-turbo mode and then switch to turbo. */
+	uint8_t bootfreq;
 
 	/* Rank Margin Tool. 1:Enable, 0:Disable */
 	uint8_t RMT;
diff --git a/src/soc/intel/cannonlake/romstage/fsp_params.c b/src/soc/intel/cannonlake/romstage/fsp_params.c
index c3a2509..0514844 100644
--- a/src/soc/intel/cannonlake/romstage/fsp_params.c
+++ b/src/soc/intel/cannonlake/romstage/fsp_params.c
@@ -54,6 +54,8 @@
 #if IS_ENABLED(CONFIG_SOC_INTEL_COFFEELAKE)
 	m_cfg->SkipMpInit = !chip_get_fsp_mp_init();
 #endif
+	m_cfg->BootFrequency = config->bootfreq;
+
 	/* If ISH is enabled, enable ISH elements */
 	if (!dev)
 		m_cfg->PchIshEnable = 0;

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30445
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6bd5849122c9035bb7f448acf08e258e8c207013
Gerrit-Change-Number: 30445
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <[e-mail]>
Gerrit-MessageType: newchange

Change in ...coreboot[master]: soc/intel/cannonlake: Add option for boot frequency

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30445 )

Change subject: soc/intel/cannonlake: Add option for boot frequency
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/30445/1/src/soc/intel/cannonlake/chip.h 
File src/soc/intel/cannonlake/chip.h:

https://review.coreboot.org/#/c/30445/1/src/soc/intel/cannonlake/chip.h@113 
PS1, Line 113: /* Boot Frequency from reset vector.
             : 	 * 0: Maximum battery performance, 1: Maximum non-turbo performance, 2:
             : 	 * Maximum turbo performance @note If 2 is selected, system will start
             : 	 * with non-turbo mode and then switch to turbo. */
             : 	uint8_t bootfreq;
> coreboots job is booting ASAP and who cares about power saving when its for a period of half a secon […]
> For SOC side, we cant' assume every mainboard usage and we will tender to leave the option open and decided by mainboard or OEM/ODM. If want to talk about a little history, one of the first workaround for nvidia bump crack was to keep processor running as slow as possible at the bios stage ......

Yes, I will add the enum here.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30445
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6bd5849122c9035bb7f448acf08e258e8c207013
Gerrit-Change-Number: 30445
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <[e-mail]>
Gerrit-Reviewer: Bora Guvendik <[e-mail]>
Gerrit-Reviewer: Duncan Laurie <[e-mail]>
Gerrit-Reviewer: Lijian Zhao <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Arthur Heymans <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Mon, 14 Jan 2019 19:22:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <[e-mail]>
Comment-In-Reply-To: Lijian Zhao <[e-mail]>
Gerrit-MessageType: comment

Change in ...coreboot[master]: soc/intel/cannonlake: Add option for boot frequency

[Lijian Zhao (Code Review)]

Hello Patrick Rudolph, Subrata Banik, Duncan Laurie, Bora Guvendik, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/30445

to look at the new patch set (#4).

Change subject: soc/intel/cannonlake: Add option for boot frequency
......................................................................

soc/intel/cannonlake: Add option for boot frequency

Cannonlake/Coffeelake FSP have options for CPU bootup frequency
selection, expose that in coreboot side.

Signed-off-by: Lijian Zhao <[e-mail]>
Change-Id: I6bd5849122c9035bb7f448acf08e258e8c207013
---
M src/soc/intel/cannonlake/chip.h
M src/soc/intel/cannonlake/romstage/fsp_params.c
2 files changed, 11 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/30445/4
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30445
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6bd5849122c9035bb7f448acf08e258e8c207013
Gerrit-Change-Number: 30445
Gerrit-PatchSet: 4
Gerrit-Owner: Lijian Zhao <[e-mail]>
Gerrit-Reviewer: Bora Guvendik <[e-mail]>
Gerrit-Reviewer: Duncan Laurie <[e-mail]>
Gerrit-Reviewer: Lijian Zhao <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Arthur Heymans <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: newpatchset

Change in ...coreboot[master]: soc/intel/cannonlake: Add option for boot frequency

[Lijian Zhao (Code Review)]

Lijian Zhao has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30445 )

Change subject: soc/intel/cannonlake: Add option for boot frequency
......................................................................


Abandoned

won't help the boot time
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30445
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6bd5849122c9035bb7f448acf08e258e8c207013
Gerrit-Change-Number: 30445
Gerrit-PatchSet: 4
Gerrit-Owner: Lijian Zhao <[e-mail]>
Gerrit-Reviewer: Bora Guvendik <[e-mail]>
Gerrit-Reviewer: Duncan Laurie <[e-mail]>
Gerrit-Reviewer: Lijian Zhao <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Arthur Heymans <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: abandon