Change in ...coreboot[master]: soc/intel/braswell: Add support for FSP MR2

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29661 )

Change subject: soc/intel/braswell: Add support for FSP MR2
......................................................................


Patch Set 5:
> Patch Set 5:
> > Why don't you use the 3rdparty/fsp repo instead, like done in https://review.coreboot.org/#/c/coreboot/+/30742/ ?
>
> IIRC, the original problem was that the current coreboot
> source is incompatible with the upstream headers (because
> UPDs were added that are unknown to Intel?).

in drivers/intel/fsp1_1/fsp_util.c FSP_IMAGE_ID is checked against the ID in the FSP binary. There is a mismatch using MR2


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29661
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id40b5d46ddda93845d9739b56aaf7ad24ee89246
Gerrit-Change-Number: 29661
Gerrit-PatchSet: 5
Gerrit-Owner: Frans Hendriks <[e-mail]>
Gerrit-Reviewer: Aaron Durbin <[e-mail]>
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: Frans Hendriks <[e-mail]>
Gerrit-Reviewer: Hannah Williams <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Matt DeVillier <[e-mail]>
Gerrit-Reviewer: Nathaniel L Desimone <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Michał Żygowski <[e-mail]>
Gerrit-CC: Nico Huber <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Fri, 01 Mar 2019 07:18:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment