Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30445 ) Change subject: soc/intel/cannonlake: Add option for boot frequency ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/30445/1/src/soc/intel/cannonlake/chip.h File src/soc/intel/cannonlake/chip.h: https://review.coreboot.org/#/c/30445/1/src/soc/intel/cannonlake/chip.h@113 PS1, Line 113: /* Boot Frequency from reset vector. : * 0: Maximum battery performance, 1: Maximum non-turbo performance, 2: : * Maximum turbo performance @note If 2 is selected, system will start : * with non-turbo mode and then switch to turbo. */ : uint8_t bootfreq;
coreboots job is booting ASAP and who cares about power saving when its for a period of half a secon […] For SOC side, we cant' assume every mainboard usage and we will tender to leave the option open and decided by mainboard or OEM/ODM. If want to talk about a little history, one of the first workaround for nvidia bump crack was to keep processor running as slow as possible at the bios stage ......
Yes, I will add the enum here. -- To view, visit https://review.coreboot.org/c/coreboot/+/30445 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6bd5849122c9035bb7f448acf08e258e8c207013 Gerrit-Change-Number: 30445 Gerrit-PatchSet: 1 Gerrit-Owner: Lijian Zhao <lijian.zhao@intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik@intel.com> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> Gerrit-Reviewer: Lijian Zhao <lijian.zhao@intel.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Mon, 14 Jan 2019 19:22:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur@aheymans.xyz> Comment-In-Reply-To: Lijian Zhao <lijian.zhao@intel.com> Gerrit-MessageType: comment