Change in ...coreboot[master]: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32042

Change subject: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'
......................................................................

console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'

This has nothing to do with console options.

This also improves the help text to reflect what it actually does.

Change-Id: I039f4f6bbe144769d6a362192b225838ed3d9d43
Signed-off-by: Arthur Heymans 
---
M src/console/Kconfig
M src/device/Kconfig
2 files changed, 10 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/32042/1

diff --git a/src/console/Kconfig b/src/console/Kconfig
index 61ba667..fb87e67 100644
--- a/src/console/Kconfig
+++ b/src/console/Kconfig
@@ -176,13 +176,6 @@

# TODO: Deps?
 # TODO: Improve description.
-config ONBOARD_VGA_IS_PRIMARY
-	bool "Use onboard VGA as primary video device"
-	default n
-	depends on PCI
-	help
-	  If not selected, the last adapter found will be used.
-
 config CONSOLE_NE2K
    bool "Network console over NE2000 compatible Ethernet adapter"
    default n
diff --git a/src/device/Kconfig b/src/device/Kconfig
index 8001b43..2da12bc 100644
--- a/src/device/Kconfig
+++ b/src/device/Kconfig
@@ -683,4 +683,14 @@
      I2C controller is not (yet) available. The platform code needs to
      provide bindings to manually toggle I2C lines.

+config ONBOARD_VGA_IS_PRIMARY
+	bool "Use onboard VGA as primary video device"
+	default n
+	depends on PCI
+	help
+	  This option lets you select which VGA device will be used
+	  to decode legacy VGA cycles. Not all chipsets implement this
+	  however. If not selected, the last adapter found will be used,
+	  else the onboard adapter is used.
+
 endmenu

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32042 )

Change subject: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/32042/1/src/device/Kconfig 
File src/device/Kconfig:

https://review.coreboot.org/#/c/32042/1/src/device/Kconfig@694 
PS1, Line 694: 	  else the onboard adapter is used.
Probably better placed with the other video
options, e.g. above the Display menu?

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32042 )

Change subject: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32042/1/src/device/Kconfig 
File src/device/Kconfig:

https://review.coreboot.org/#/c/32042/1/src/device/Kconfig@694 
PS1, Line 694: 	  else the onboard adapter is used.
> Probably better placed with the other video […]

Btw is meaningful on non-x86?

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32042 )

Change subject: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32042/1/src/device/Kconfig 
File src/device/Kconfig:

https://review.coreboot.org/#/c/32042/1/src/device/Kconfig@694 
PS1, Line 694: 	  else the onboard adapter is used.
> Btw is meaningful on non-x86?

Yes, on PowerPC for sure, I guess OpenPower too. Generally it's
technically possible for anything with port i/o and PCI. Not sure
if we have a Kconfig flag for the former.

Change in coreboot[master]: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'

[Arthur Heymans (Code Review)]

Hello build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32042

to look at the new patch set (#2).

Change subject: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'
......................................................................

console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'

This has nothing to do with console options.

This also improves the help text to reflect what it actually does.

Change-Id: I039f4f6bbe144769d6a362192b225838ed3d9d43
Signed-off-by: Arthur Heymans 
---
M src/console/Kconfig
M src/device/Kconfig
2 files changed, 10 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/32042/2

Change in coreboot[master]: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32042 )

Change subject: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32042 )

Change subject: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'
......................................................................

Patch Set 2: Code-Review+1

Change in coreboot[master]: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32042 )

Change subject: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/32042/1/src/device/Kconfig 
File src/device/Kconfig:

https://review.coreboot.org/c/coreboot/+/32042/1/src/device/Kconfig@694 
PS1, Line 694: 	  else the onboard adapter is used.
> Yes, on PowerPC for sure, I guess OpenPower too. Generally it's […]

Ack

Change in coreboot[master]: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/32042 )

Change subject: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'
......................................................................

console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'

This has nothing to do with console options.

This also improves the help text to reflect what it actually does.

Change-Id: I039f4f6bbe144769d6a362192b225838ed3d9d43
Signed-off-by: Arthur Heymans 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32042
Tested-by: build bot (Jenkins) 
Reviewed-by: Nico Huber 
Reviewed-by: Paul Menzel 
---
M src/console/Kconfig
M src/device/Kconfig
2 files changed, 10 insertions(+), 7 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve

diff --git a/src/console/Kconfig b/src/console/Kconfig
index 5d505d2..e767edd 100644
--- a/src/console/Kconfig
+++ b/src/console/Kconfig
@@ -176,13 +176,6 @@

# TODO: Deps?
 # TODO: Improve description.
-config ONBOARD_VGA_IS_PRIMARY
-	bool "Use onboard VGA as primary video device"
-	default n
-	depends on PCI
-	help
-	  If not selected, the last adapter found will be used.
-
 config CONSOLE_NE2K
    bool "Network console over NE2000 compatible Ethernet adapter"
    default n
diff --git a/src/device/Kconfig b/src/device/Kconfig
index a62eac8..7f00c0b 100644
--- a/src/device/Kconfig
+++ b/src/device/Kconfig
@@ -116,6 +116,16 @@

endchoice

+config ONBOARD_VGA_IS_PRIMARY
+	bool "Use onboard VGA as primary video device"
+	default n
+	depends on PCI
+	help
+	  This option lets you select which VGA device will be used
+	  to decode legacy VGA cycles. Not all chipsets implement this
+	  however. If not selected, the last adapter found will be used,
+	  else the onboard adapter is used.
+
 config S3_VGA_ROM_RUN
    bool "Re-run VGA Option ROMs on S3 resume"
    default y