Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve
console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'

This has nothing to do with console options.

This also improves the help text to reflect what it actually does.

Change-Id: I039f4f6bbe144769d6a362192b225838ed3d9d43
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32042
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
M src/console/Kconfig
M src/device/Kconfig
2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/src/console/Kconfig b/src/console/Kconfig
index 5d505d2..e767edd 100644
--- a/src/console/Kconfig
+++ b/src/console/Kconfig
@@ -176,13 +176,6 @@

# TODO: Deps?
# TODO: Improve description.
-config ONBOARD_VGA_IS_PRIMARY
- bool "Use onboard VGA as primary video device"
- default n
- depends on PCI
- help
- If not selected, the last adapter found will be used.
-
config CONSOLE_NE2K
bool "Network console over NE2000 compatible Ethernet adapter"
default n
diff --git a/src/device/Kconfig b/src/device/Kconfig
index a62eac8..7f00c0b 100644
--- a/src/device/Kconfig
+++ b/src/device/Kconfig
@@ -116,6 +116,16 @@

endchoice

+config ONBOARD_VGA_IS_PRIMARY
+ bool "Use onboard VGA as primary video device"
+ default n
+ depends on PCI
+ help
+ This option lets you select which VGA device will be used
+ to decode legacy VGA cycles. Not all chipsets implement this
+ however. If not selected, the last adapter found will be used,
+ else the onboard adapter is used.
+
config S3_VGA_ROM_RUN
bool "Re-run VGA Option ROMs on S3 resume"
default y

To view, visit change 32042. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I039f4f6bbe144769d6a362192b225838ed3d9d43
Gerrit-Change-Number: 32042
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged