Change in coreboot[master]: mb/apple/macbook21: Use DEBUG_RAM_SETUP

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36496 )

Change subject: mb/apple/macbook21: Use DEBUG_RAM_SETUP
......................................................................

mb/apple/macbook21: Use DEBUG_RAM_SETUP

Also, the loglevel is never set to value of > 8.

Change-Id: Ief29e07be6ac075956bf0f9aee85b14eb89af44c
Signed-off-by: Elyes HAOUAS 
---
M src/mainboard/apple/macbook21/romstage.c
1 file changed, 2 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/36496/1

diff --git a/src/mainboard/apple/macbook21/romstage.c b/src/mainboard/apple/macbook21/romstage.c
index ee5ba80..34cd378 100644
--- a/src/mainboard/apple/macbook21/romstage.c
+++ b/src/mainboard/apple/macbook21/romstage.c
@@ -226,9 +226,8 @@
    /* Enable SPD ROMs and DDR-II DRAM */
    enable_smbus();

-#if CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8
-	dump_spd_registers();
-#endif
+	if (CONFIG(DEBUG_RAM_SETUP))
+		dump_spd_registers();

sdram_initialize(s3resume ? 2 : 0, spd_addrmap);

[Evgeny Zinoviev (Code Review)]

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36496 )

Change subject: mb/apple/macbook21: Use DEBUG_RAM_SETUP
......................................................................

Patch Set 1: Code-Review+1

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36496 )

Change subject: mb/apple/macbook21: Use DEBUG_RAM_SETUP
......................................................................

Patch Set 1: Code-Review+1

Nice.

PS: Looks like some romstage code can be factored into a common romstage.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36496 )

Change subject: mb/apple/macbook21: Use DEBUG_RAM_SETUP
......................................................................

Patch Set 1: Code-Review+2

[Evgeny Zinoviev (Code Review)]

Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36496 )

Change subject: mb/apple/macbook21: Use DEBUG_RAM_SETUP
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36496 )

Change subject: mb/apple/macbook21: Use DEBUG_RAM_SETUP
......................................................................

mb/apple/macbook21: Use DEBUG_RAM_SETUP

Also, the loglevel is never set to value of > 8.

Change-Id: Ief29e07be6ac075956bf0f9aee85b14eb89af44c
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36496
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Angel Pons 
Reviewed-by: Evgeny Zinoviev 
---
M src/mainboard/apple/macbook21/romstage.c
1 file changed, 2 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved
  Evgeny Zinoviev: Looks good to me, approved

diff --git a/src/mainboard/apple/macbook21/romstage.c b/src/mainboard/apple/macbook21/romstage.c
index ee5ba80..34cd378 100644
--- a/src/mainboard/apple/macbook21/romstage.c
+++ b/src/mainboard/apple/macbook21/romstage.c
@@ -226,9 +226,8 @@
    /* Enable SPD ROMs and DDR-II DRAM */
    enable_smbus();

-#if CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8
-	dump_spd_registers();
-#endif
+	if (CONFIG(DEBUG_RAM_SETUP))
+		dump_spd_registers();

sdram_initialize(s3resume ? 2 : 0, spd_addrmap);