Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45172 )
Change subject: drivers/intel/mipi_camera: Add support for dynamic SSDT generation
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45172/8/src/drivers/intel/mipi_came...
File src/drivers/intel/mipi_camera/camera_sku.c:
https://review.coreboot.org/c/coreboot/+/45172/8/src/drivers/intel/mipi_came...
PS8, Line 36: /* By default device will be set to enabled in alloc_dev. So calling dev_set_enabled
: is not making call to chip_ops->enable_dev as device is already enabled */
: dev_set_enabled(sensor, 0);
: dev_set_enabled(sensor, 1);
: }
This is a little confusing. You say that it's already enabled, and then you disable and re-enable it without explaining why you have to do that. Maybe reword the comment to explain why you have to disable it first, something like this?
"Disable and re-enable the device so that chip_ops->enable_dev will always get called."
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45172
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a5aa6c313c026871e55bc6d067b44de4c1f1afe
Gerrit-Change-Number: 45172
Gerrit-PatchSet: 8
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Andy Yeh
andy.yeh@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Chiasheng Lee
chiasheng.lee@intel.com
Gerrit-Reviewer: Jett Rink
jettrink@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: ShawnX Tu
shawnx.tu@intel.com
Gerrit-Reviewer: Tomasz Figa
tfiga@google.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-CC: Henry Sun
henrysun@google.com
Gerrit-CC: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Sep 2020 17:52:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment