HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45403 )
Change subject: src: Remove redundant <pnp_type.h> ......................................................................
src: Remove redundant <pnp_type.h>
When <device/pnp.h> is needed, supposed to provide <device/pnp_type.h>.
Change-Id: I0e479e2abdb6cfb8633840db2222ce5397fe7d55 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/device/pnp.h M src/include/device/pnp_ops.h M src/superio/nuvoton/nct5104d/early_init.c 3 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/45403/1
diff --git a/src/include/device/pnp.h b/src/include/device/pnp.h index bbd0498..cf809d0 100644 --- a/src/include/device/pnp.h +++ b/src/include/device/pnp.h @@ -3,7 +3,7 @@
#include <stdint.h> #include <device/device.h> -/* When <device/pnp.h> is needed, it supposed to provide <device/pnp_def.h> */ +/* When <device/pnp.h> is needed, it supposed to provide <device/pnp_{def,type}.h> */ #include <device/pnp_def.h> #include <device/pnp_type.h> #include <arch/io.h> diff --git a/src/include/device/pnp_ops.h b/src/include/device/pnp_ops.h index 0d63f1b..15acf36 100644 --- a/src/include/device/pnp_ops.h +++ b/src/include/device/pnp_ops.h @@ -6,7 +6,6 @@ #include <stdint.h> #include <arch/io.h> #include <device/pnp.h> -#include <device/pnp_type.h>
#if ENV_PNP_SIMPLE_DEVICE
diff --git a/src/superio/nuvoton/nct5104d/early_init.c b/src/superio/nuvoton/nct5104d/early_init.c index 5ed4c5c..c5e9388 100644 --- a/src/superio/nuvoton/nct5104d/early_init.c +++ b/src/superio/nuvoton/nct5104d/early_init.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <arch/io.h> -#include <device/pnp_type.h> #include <device/pnp.h> #include <stdint.h> #include "nct5104d.h"
Hello Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45403
to look at the new patch set (#2).
Change subject: src: Remove redundant <pnp_type.h> ......................................................................
src: Remove redundant <pnp_type.h>
When <device/pnp.h> is needed, it is supposed to provide <device/pnp_type.h>.
Change-Id: I0e479e2abdb6cfb8633840db2222ce5397fe7d55 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/device/pnp.h M src/include/device/pnp_ops.h M src/superio/nuvoton/nct5104d/early_init.c 3 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/45403/2
Hello build bot (Jenkins), Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45403
to look at the new patch set (#4).
Change subject: src: Remove redundant <device/pnp_type.h> ......................................................................
src: Remove redundant <device/pnp_type.h>
When <device/pnp.h> is needed, it is supposed to provide <device/pnp_type.h>.
Change-Id: I0e479e2abdb6cfb8633840db2222ce5397fe7d55 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/device/pnp.h M src/include/device/pnp_ops.h M src/superio/nuvoton/nct5104d/early_init.c 3 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/45403/4
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45403 )
Change subject: src: Remove redundant <device/pnp_type.h> ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45403/4/src/include/device/pnp.h File src/include/device/pnp.h:
https://review.coreboot.org/c/coreboot/+/45403/4/src/include/device/pnp.h@6 PS4, Line 6: /* When <device/pnp.h> is needed, it supposed to provide <device/pnp_{def,type}.h> */ move the change of this line in the patch before?
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45403 )
Change subject: src: Remove redundant <device/pnp_type.h> ......................................................................
Patch Set 5: Code-Review+2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45403 )
Change subject: src: Remove redundant <device/pnp_type.h> ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45403/4/src/include/device/pnp.h File src/include/device/pnp.h:
https://review.coreboot.org/c/coreboot/+/45403/4/src/include/device/pnp.h@6 PS4, Line 6: /* When <device/pnp.h> is needed, it supposed to provide <device/pnp_{def,type}.h> */
move the change of this line in the patch before?
Done
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45403 )
Change subject: src: Remove redundant <device/pnp_type.h> ......................................................................
src: Remove redundant <device/pnp_type.h>
When <device/pnp.h> is needed, it is supposed to provide <device/pnp_type.h>.
Change-Id: I0e479e2abdb6cfb8633840db2222ce5397fe7d55 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/45403 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/device/pnp_ops.h M src/superio/nuvoton/nct5104d/early_init.c 2 files changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/include/device/pnp_ops.h b/src/include/device/pnp_ops.h index 0d63f1b..15acf36 100644 --- a/src/include/device/pnp_ops.h +++ b/src/include/device/pnp_ops.h @@ -6,7 +6,6 @@ #include <stdint.h> #include <arch/io.h> #include <device/pnp.h> -#include <device/pnp_type.h>
#if ENV_PNP_SIMPLE_DEVICE
diff --git a/src/superio/nuvoton/nct5104d/early_init.c b/src/superio/nuvoton/nct5104d/early_init.c index 5ed4c5c..c5e9388 100644 --- a/src/superio/nuvoton/nct5104d/early_init.c +++ b/src/superio/nuvoton/nct5104d/early_init.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */
#include <arch/io.h> -#include <device/pnp_type.h> #include <device/pnp.h> #include <stdint.h> #include "nct5104d.h"
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45403 )
Change subject: src: Remove redundant <device/pnp_type.h> ......................................................................
Patch Set 6:
Automatic boot test returned (PASS/FAIL/TOTAL): 8/1/9 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19714 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19713 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/19712 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19711 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/19710 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19718 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/19717 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/19716 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/19715
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Felix Held (Code Review)
-
HAOUAS Elyes (Code Review)