View Change

1 comment:

• File src/drivers/intel/mipi_camera/camera_sku.c:

  • Patch Set #8, Line 36:

    	/* By default device will be set to enabled in alloc_dev. So calling dev_set_enabled
    	is not making call to chip_ops->enable_dev as device is already enabled */
    	dev_set_enabled(sensor, 0);
    	dev_set_enabled(sensor, 1);
    }
    

    This is a little confusing. You say that it's already enabled, and then you disable and re-enable it without explaining why you have to do that. Maybe reword the comment to explain why you have to disable it first, something like this?
    "Disable and re-enable the device so that chip_ops->enable_dev will always get called."

To view, visit change 45172. To unsubscribe, or for help writing mail filters, visit settings.