Alex Levin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45279 )
Change subject: mb/google/volteer/variants/volteer2: route GPP_F14 via APIC ......................................................................
mb/google/volteer/variants/volteer2: route GPP_F14 via APIC
GPP_F14 should be configured to be routed via APIC and not SCI.
BUG=b:162528549 TEST=verified on a volteer2
Signed-off-by: Alex Levin levinale@google.com Change-Id: I7f2c7af230dd75b3cb3806e2b186725d49da9e68 --- M src/mainboard/google/volteer/variants/volteer2/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/45279/1
diff --git a/src/mainboard/google/volteer/variants/volteer2/gpio.c b/src/mainboard/google/volteer/variants/volteer2/gpio.c index c7fa706..7255423 100644 --- a/src/mainboard/google/volteer/variants/volteer2/gpio.c +++ b/src/mainboard/google/volteer/variants/volteer2/gpio.c @@ -125,7 +125,7 @@ /* F13 : GSXDOUT ==> WiFi_DISABLE_L */ PAD_CFG_GPO(GPP_F13, 1, DEEP), /* F14 : GSXDIN ==> SAR0_INT_L */ - PAD_CFG_GPI_SCI_LOW(GPP_F14, NONE, PLTRST, EDGE_SINGLE), + PAD_CFG_GPI_APIC(GPP_F14, NONE, PLTRST, LEVEL, NONE), /* F15 : GSXSRESET# ==> RCAM_RST_L */ PAD_CFG_GPO(GPP_F15, 1, DEEP), /* F16 : GSXCLK ==> WWAN_DPR_SAR_ODL */
Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45279 )
Change subject: mb/google/volteer/variants/volteer2: route GPP_F14 via APIC ......................................................................
Patch Set 1:
I didn't change the gpio setting for Volteer2 in the first commit - apologies for the extra review
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45279 )
Change subject: mb/google/volteer/variants/volteer2: route GPP_F14 via APIC ......................................................................
Patch Set 1: Code-Review+2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45279 )
Change subject: mb/google/volteer/variants/volteer2: route GPP_F14 via APIC ......................................................................
Patch Set 1:
Submitting early because this is required for a build and the change is limited to volteer board, so impact is minimal.
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45279 )
Change subject: mb/google/volteer/variants/volteer2: route GPP_F14 via APIC ......................................................................
mb/google/volteer/variants/volteer2: route GPP_F14 via APIC
GPP_F14 should be configured to be routed via APIC and not SCI.
BUG=b:162528549 TEST=verified on a volteer2
Signed-off-by: Alex Levin levinale@google.com Change-Id: I7f2c7af230dd75b3cb3806e2b186725d49da9e68 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45279 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/volteer2/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/volteer2/gpio.c b/src/mainboard/google/volteer/variants/volteer2/gpio.c index c7fa706..7255423 100644 --- a/src/mainboard/google/volteer/variants/volteer2/gpio.c +++ b/src/mainboard/google/volteer/variants/volteer2/gpio.c @@ -125,7 +125,7 @@ /* F13 : GSXDOUT ==> WiFi_DISABLE_L */ PAD_CFG_GPO(GPP_F13, 1, DEEP), /* F14 : GSXDIN ==> SAR0_INT_L */ - PAD_CFG_GPI_SCI_LOW(GPP_F14, NONE, PLTRST, EDGE_SINGLE), + PAD_CFG_GPI_APIC(GPP_F14, NONE, PLTRST, LEVEL, NONE), /* F15 : GSXSRESET# ==> RCAM_RST_L */ PAD_CFG_GPO(GPP_F15, 1, DEEP), /* F16 : GSXCLK ==> WWAN_DPR_SAR_ODL */
-
Alex Levin (Code Review) -
Furquan Shaikh (Code Review)