Change in ...coreboot[master]: src/cpu/x86 STM Support

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in ...coreboot[master]:...

Name of user not set (Code Review)

5 Jun 2019 5 Jun '19

11:01 p.m.

Name of user not set #1002358 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33236

Change subject: src/cpu/x86 STM Support ......................................................................

src/cpu/x86 STM Support

STM initialization

Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb --- M src/cpu/x86/mp_init.c 1 file changed, 25 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33236/1

diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index 3889c7d..881d8a2 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -37,8 +37,12 @@ #include <symbols.h> #include <thread.h>

+#include <security/intel/stm/StmApi.h> + #define MAX_APIC_IDS 256

+extern int LoadStmImage(uint32_t mseg); + struct mp_callback { void (*func)(void *); void *arg; @@ -823,6 +827,10 @@ { size_t smm_save_state_size = mp_state.smm_save_state_size;

+#ifdef CONFIG_STM + uint32_t mseg; +#endif + /* Do nothing if SMM is disabled.*/ if (!is_smm_enabled()) return; @@ -839,6 +847,14 @@ printk(BIOS_ERR, "Unable to install SMM permanent handler.\n"); smm_disable(); } +#ifdef CONFIG_STM + + /* Calculate mseg location*/ + mseg = mp_state.perm_smbase + (mp_state.perm_smsize - CONFIG_MSEG_SIZE); + + /* Load the STM into the MSEG */ + LoadStmImage(mseg); +#endif

/* Ensure the SMM handlers hit DRAM before performing first SMI. */ wbinvd(); @@ -1023,6 +1039,15 @@ if (ops->get_smm_info != NULL) ops->get_smm_info(&state->perm_smbase, &state->perm_smsize, &state->smm_save_state_size); +#ifdef CONFIG_STM + + /* Currently, the CPU SMM save state size is based on a simplistic + * algorithm. (set it to 1K) + * note: In the future, this will need to handle newer x86 processors + * that require 32k alignment of the save state on 32K boundries.*/ + state->smm_save_state_size += (sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR) + 0x1000) & 0xfffff000; + +#endif /* CONFIG_STM */

/* * Default to smm_initiate_relocation() if trigger callback isn't

Attachments:

attachment.htm (text/html — 5.0 KB)

Show replies by date

build bot (Jenkins) (Code Review)

5 Jun 5 Jun

11:02 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )

Change subject: src/cpu/x86 STM Support ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@1046 PS1, Line 1046: * note: In the future, this will need to handle newer x86 processors trailing whitespace

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@1048 PS1, Line 1048: state->smm_save_state_size += (sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR) + 0x1000) & 0xfffff000; line over 80 characters

Paul Menzel (Code Review)

6 Jun 6 Jun

11:29 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )

Change subject: src/cpu/x86 STM Support ......................................................................

Patch Set 1:

(6 comments)

https://review.coreboot.org/#/c/33236/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/33236/1//COMMIT_MSG@4 PS1, Line 4: EugeneDMyers Eugene D Myers

git commit --amend --author="Eugene D Myers cedarhouse1@comcast.net"

https://review.coreboot.org/#/c/33236/1//COMMIT_MSG@7 PS1, Line 7: src/cpu/x86 STM Support Please use:

...

cpu/x86: Add STM support

See `git log --oneline` how summaries should be done.

https://review.coreboot.org/#/c/33236/1//COMMIT_MSG@9 PS1, Line 9: STM initialization Please elaborate.

https://review.coreboot.org/#/c/33236/1//COMMIT_MSG@11 PS1, Line 11: Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Please add your Signed-off-by line below.

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@1047 PS1, Line 1047: * that require 32k alignment of the save state on 32K boundries.*/ Please add a space before `*/`.

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@1044 PS1, Line 1044: /* Currently, the CPU SMM save state size is based on a simplistic : * algorithm. (set it to 1K) : * note: In the future, this will need to handle newer x86 processors : * that require 32k alignment of the save state on 32K boundries.*/ Please see the coding style about how to format multi-line comments.

/* * … * /

or for concise style:

/* … … */

Patrick Rudolph (Code Review)

6:55 p.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )

Change subject: src/cpu/x86 STM Support ......................................................................

Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@44 PS1, Line 44: extern int LoadStmImage(uint32_t mseg); don't use extern

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@831 PS1, Line 831: uint32_t mseg; uintptr_t

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@1042 PS1, Line 1042: #ifdef CONFIG_STM no need for preprocessor directives

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@1048 PS1, Line 1048: state->smm_save_state_size += (sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR) + 0x1000) & 0xfffff000; use one of the macros: ALIGN_UP and ALIGN_DOWN

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 06 Jun 2019 16:55:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Name of user not set (Code Review)

9:49 p.m.

New subject: Change in ...coreboot[master]: cpu/x86: Add STM Support

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33236

to look at the new patch set (#2).

Change subject: cpu/x86: Add STM Support ......................................................................

cpu/x86: Add STM Support

STM Setup - The STM needs to be loaded into the MSEG during BIOS initialization and the SMM Monitor Control MSR be set to indicate that an STM is in the system.

Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Signed-off-by: Eugene D Myers cedarhouse1@comcast.net --- M src/cpu/x86/mp_init.c 1 file changed, 21 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33236/2

build bot (Jenkins) (Code Review)

9:50 p.m.

New subject: Change in ...coreboot[master]: cpu/x86: Add STM Support

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )

Change subject: cpu/x86: Add STM Support ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/33236/2/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:

https://review.coreboot.org/#/c/33236/2/src/cpu/x86/mp_init.c@854 PS2, Line 854: LoadStmImage(mseg); trailing whitespace

https://review.coreboot.org/#/c/33236/2/src/cpu/x86/mp_init.c@1045 PS2, Line 1045: state->smm_save_state_size += trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 2 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 06 Jun 2019 19:50:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Name of user not set (Code Review)

9:54 p.m.

New subject: Change in ...coreboot[master]: cpu/x86: Add STM Support

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33236

to look at the new patch set (#3).

Change subject: cpu/x86: Add STM Support ......................................................................

cpu/x86: Add STM Support

STM Setup - The STM needs to be loaded into the MSEG during BIOS initialization and the SMM Monitor Control MSR be set to indicate that an STM is in the system.

Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Signed-off-by: Eugene D Myers cedarhouse1@comcast.net --- M src/cpu/x86/mp_init.c 1 file changed, 21 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33236/3

Name of user not set (Code Review)

10:35 p.m.

New subject: Change in ...coreboot[master]: cpu/x86: Add STM Support

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33236

to look at the new patch set (#5).

Change subject: cpu/x86: Add STM Support ......................................................................

cpu/x86: Add STM Support

STM Setup - The STM needs to be loaded into the MSEG during BIOS initialization and the SMM Monitor Control MSR be set to indicate that an STM is in the system.

Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Signed-off-by: Eugene D Myers cedarhouse1@comcast.net --- M src/cpu/x86/mp_init.c 1 file changed, 21 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33236/5

Name of user not set (Code Review)

10:42 p.m.

New subject: Change in ...coreboot[master]: cpu/x86: Add STM Support

Name of user not set #1002358 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )

Change subject: cpu/x86: Add STM Support ......................................................................

Patch Set 6:

(11 comments)

https://review.coreboot.org/#/c/33236/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/33236/1//COMMIT_MSG@4 PS1, Line 4: EugeneDMyers

...

Eugene D Myers […]

Done

https://review.coreboot.org/#/c/33236/1//COMMIT_MSG@7 PS1, Line 7: src/cpu/x86 STM Support

...

Please use: […]

Done

https://review.coreboot.org/#/c/33236/1//COMMIT_MSG@9 PS1, Line 9: STM initialization

...

Please elaborate.

Done

https://review.coreboot.org/#/c/33236/1//COMMIT_MSG@11 PS1, Line 11: Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb

...

Please add your Signed-off-by line below.

Done

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@44 PS1, Line 44: extern int LoadStmImage(uint32_t mseg);

...

don't use extern

Done

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@831 PS1, Line 831: uint32_t mseg;

...

uintptr_t

Done

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@1042 PS1, Line 1042: #ifdef CONFIG_STM

...

no need for preprocessor directives

Done

...

Please see the coding style about how to format multi-line comments. […]

Done

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@1047 PS1, Line 1047: * that require 32k alignment of the save state on 32K boundries.*/

...

Please add a space before `*/`.

Done

...

Done

Done

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@1048 PS1, Line 1048: state->smm_save_state_size += (sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR) + 0x1000) & 0xfffff000;

...

use one of the macros: ALIGN_UP and ALIGN_DOWN

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 6 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 06 Jun 2019 20:42:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph patrick.rudolph@9elements.com Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Rudolph (Code Review)

7 Jun 7 Jun

7:05 a.m.

New subject: Change in ...coreboot[master]: cpu/x86: Add STM Support

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )

Change subject: cpu/x86: Add STM Support ......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:

https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@1042 PS1, Line 1042: #ifdef CONFIG_STM

...

Done

Sorry, I should have been more precise: In coreboot we generally use if(CONFIG(STM)) { over #if CONFIG(STM). That allows to compile all code regardless of the Kconfig settings and the linker will remove the dead code anyway.

it applies to all commits and all files and all occurences

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 10 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Comment-Date: Fri, 07 Jun 2019 05:05:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph patrick.rudolph@9elements.com Comment-In-Reply-To: Name of user not set #1002358 Gerrit-MessageType: comment

Paul Menzel (Code Review)

20 Jun 20 Jun

12:50 p.m.

New subject: Change in ...coreboot[master]: cpu/x86: Add STM Support

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )

Change subject: cpu/x86: Add STM Support ......................................................................

Patch Set 10:

(2 comments)

Can this be squashed into the other commits?

How can this be tested? With QEMU?

https://review.coreboot.org/#/c/33236/10//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/33236/10//COMMIT_MSG@7 PS10, Line 7: cpu/x86: Add STM Support Please use only one space after the colon.

https://review.coreboot.org/#/c/33236/10/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:

https://review.coreboot.org/#/c/33236/10/src/cpu/x86/mp_init.c@1041 PS10, Line 1041: /* Currently, the CPU SMM save state size is based on a simplistic : * algorithm. (set it to 1K) : * note: In the future, this will need to handle newer x86 processors : * that require 32k alignment of the save state on 32K boundries. */ Please reformat to use the comment style described in the coding style.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 10 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Comment-Date: Thu, 20 Jun 2019 10:50:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Name of user not set (Code Review)

26 Jun 26 Jun

10:13 p.m.

New subject: Change in ...coreboot[master]: cpu/x86: Add STM Support

Name of user not set #1002358 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )

Change subject: cpu/x86: Add STM Support ......................................................................

Patch Set 10:

(3 comments)

https://review.coreboot.org/#/c/33236/10//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/33236/10//COMMIT_MSG@7 PS10, Line 7: cpu/x86: Add STM Support

...

Please use only one space after the colon.

Done

https://review.coreboot.org/#/c/33236/10/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:

...

Done

Done

...

Please reformat to use the comment style described in the coding style.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 10 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-CC: ron minnich rminnich@gmail.com Gerrit-Comment-Date: Wed, 26 Jun 2019 20:13:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Name of user not set #1002358 Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Name of user not set (Code Review)

28 Jun 28 Jun

10:36 p.m.

New subject: Change in ...coreboot[master]: cpu/x86: Add STM Support

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33236

to look at the new patch set (#11).

Change subject: cpu/x86: Add STM Support ......................................................................

cpu/x86: Add STM Support

STM Set up - The STM needs to be loaded into the MSEG during BIOS initialization and the SMM Monitor Control MSR be set to indicate that an STM is in the system.

Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Signed-off-by: Eugene D. Myers edmyers@tycho.nsa.gov --- M src/cpu/x86/mp_init.c M src/include/cpu/x86/msr.h 2 files changed, 24 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33236/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 11 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-CC: ron minnich rminnich@gmail.com Gerrit-MessageType: newpatchset

Name of user not set (Code Review)

11:36 p.m.

New subject: Change in ...coreboot[master]: cpu/x86: Add STM Support

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33236

to look at the new patch set (#14).

Change subject: cpu/x86: Add STM Support ......................................................................

cpu/x86: Add STM Support

STM Set up - The STM needs to be loaded into the MSEG during BIOS initialization and the SMM Monitor Control MSR be set to indicate that an STM is in the system.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33236/14

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 14 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-CC: ron minnich rminnich@gmail.com Gerrit-MessageType: newpatchset

Name of user not set (Code Review)

3 Jul 3 Jul

1:40 a.m.

New subject: Change in ...coreboot[master]: cpu/x86: Add STM Support

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33236

to look at the new patch set (#16).

Change subject: cpu/x86: Add STM Support ......................................................................

cpu/x86: Add STM Support

STM Set up - The STM needs to be loaded into the MSEG during BIOS initialization and the SMM Monitor Control MSR be set to indicate that an STM is in the system.

Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Signed-off-by: Eugene D. Myers edmyers@tycho.nsa.gov --- M src/cpu/x86/mp_init.c 1 file changed, 20 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33236/16

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 16 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-CC: ron minnich rminnich@gmail.com Gerrit-MessageType: newpatchset

Name of user not set (Code Review)

13 Dec 13 Dec

10:36 p.m.

New subject: Change in coreboot[master]: cpu/x86: Add STM Support

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33236

to look at the new patch set (#17).

Change subject: cpu/x86: Add STM Support ......................................................................

cpu/x86: Add STM Support

STM Set up - The STM needs to be loaded into the MSEG during BIOS initialization and the SMM Monitor Control MSR be set to indicate that an STM is in the system.

Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Signed-off-by: Eugene D. Myers edmyers@tycho.nsa.gov --- M src/cpu/x86/mp_init.c 1 file changed, 27 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33236/17

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 17 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-CC: ron minnich rminnich@gmail.com Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

10:37 p.m.

New subject: Change in coreboot[master]: cpu/x86: Add STM Support

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )

Change subject: cpu/x86: Add STM Support ......................................................................

Patch Set 17:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33236/17/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/33236/17/src/cpu/x86/mp_init.c@747 PS17, Line 747: if (CONFIG(STM)) that open brace { should be on the previous line

https://review.coreboot.org/c/coreboot/+/33236/17/src/cpu/x86/mp_init.c@1039 PS17, Line 1039: ALIGN_UP(sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR), trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 17 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-CC: ron minnich rminnich@gmail.com Gerrit-Comment-Date: Fri, 13 Dec 2019 21:37:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Name of user not set (Code Review)

10:56 p.m.

New subject: Change in coreboot[master]: cpu/x86: Add STM Support

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33236

to look at the new patch set (#18).

Change subject: cpu/x86: Add STM Support ......................................................................

cpu/x86: Add STM Support

STM Set up - The STM needs to be loaded into the MSEG during BIOS initialization and the SMM Monitor Control MSR be set to indicate that an STM is in the system.

Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Signed-off-by: Eugene D. Myers edmyers@tycho.nsa.gov --- M src/cpu/x86/mp_init.c 1 file changed, 26 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33236/18

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 18 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-CC: ron minnich rminnich@gmail.com Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

10:57 p.m.

New subject: Change in coreboot[master]: cpu/x86: Add STM Support

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )

Change subject: cpu/x86: Add STM Support ......................................................................

Patch Set 18:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33236/18/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/33236/18/src/cpu/x86/mp_init.c@1040 PS18, Line 1040: ALIGN_UP(sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR), trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 18 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-CC: ron minnich rminnich@gmail.com Gerrit-Comment-Date: Fri, 13 Dec 2019 21:57:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

16 Dec 16 Dec

9:26 p.m.

New subject: Change in coreboot[master]: cpu/x86: Add STM Support

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )

Change subject: cpu/x86: Add STM Support ......................................................................

Patch Set 19:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33236/19/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/33236/19/src/cpu/x86/mp_init.c@1038 PS19, Line 1038: ALIGN_UP(sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR), trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 19 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-CC: ron minnich rminnich@gmail.com Gerrit-Comment-Date: Mon, 16 Dec 2019 20:26:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Name of user not set (Code Review)

10:49 p.m.

New subject: Change in coreboot[master]: cpu/x86: Add STM Support

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33236

to look at the new patch set (#20).

Change subject: cpu/x86: Add STM Support ......................................................................

cpu/x86: Add STM Support

STM Set up - The STM needs to be loaded into the MSEG during BIOS initialization and the SMM Monitor Control MSR be set to indicate that an STM is in the system.

Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Signed-off-by: Eugene D. Myers edmyers@tycho.nsa.gov --- M src/cpu/x86/mp_init.c 1 file changed, 34 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33236/20

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 20 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-CC: ron minnich rminnich@gmail.com Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

10:49 p.m.

New subject: Change in coreboot[master]: cpu/x86: Add STM Support

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )

Change subject: cpu/x86: Add STM Support ......................................................................

Patch Set 20:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33236/20/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:

https://review.coreboot.org/c/coreboot/+/33236/20/src/cpu/x86/mp_init.c@1045 PS20, Line 1045: ALIGN_UP(sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR), trailing whitespace

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 20 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-CC: ron minnich rminnich@gmail.com Gerrit-Comment-Date: Mon, 16 Dec 2019 21:49:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Name of user not set (Code Review)

11:03 p.m.

New subject: Change in coreboot[master]: cpu/x86: Add STM Support

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33236

to look at the new patch set (#21).

Change subject: cpu/x86: Add STM Support ......................................................................

cpu/x86: Add STM Support

STM Set up - The STM needs to be loaded into the MSEG during BIOS initialization and the SMM Monitor Control MSR be set to indicate that an STM is in the system.

Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Signed-off-by: Eugene D. Myers edmyers@tycho.nsa.gov --- M src/cpu/x86/mp_init.c 1 file changed, 34 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33236/21

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 21 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-CC: ron minnich rminnich@gmail.com Gerrit-MessageType: newpatchset

Name of user not set (Code Review)

17 Dec 17 Dec

12:04 a.m.

New subject: Change in coreboot[master]: cpu/x86: Add STM Support

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33236

to look at the new patch set (#22).

Change subject: cpu/x86: Add STM Support ......................................................................

cpu/x86: Add STM Support

STM Set up - The STM needs to be loaded into the MSEG during BIOS initialization and the SMM Monitor Control MSR be set to indicate that an STM is in the system.

Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Signed-off-by: Eugene D. Myers edmyers@tycho.nsa.gov --- M src/cpu/x86/mp_init.c 1 file changed, 35 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33236/22

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 22 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-CC: ron minnich rminnich@gmail.com Gerrit-MessageType: newpatchset

Name of user not set (Code Review)

12:12 a.m.

New subject: Change in coreboot[master]: cpu/x86: Add STM Support

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33236

to look at the new patch set (#23).

Change subject: cpu/x86: Add STM Support ......................................................................

cpu/x86: Add STM Support

STM Set up - The STM needs to be loaded into the MSEG during BIOS initialization and the SMM Monitor Control MSR be set to indicate that an STM is in the system.

Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Signed-off-by: Eugene D. Myers edmyers@tycho.nsa.gov --- M src/cpu/x86/mp_init.c 1 file changed, 35 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33236/23

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 23 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-CC: ron minnich rminnich@gmail.com Gerrit-MessageType: newpatchset

Name of user not set (Code Review)

20 Dec 20 Dec

9:25 p.m.

New subject: Change in coreboot[master]: cpu/x86: Add STM Support

Name of user not set #1002358 has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33236 )

Change subject: cpu/x86: Add STM Support ......................................................................

Abandoned

Squashed into CL #33234

-- To view, visit https://review.coreboot.org/c/coreboot/+/33236 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb Gerrit-Change-Number: 33236 Gerrit-PatchSet: 27 Gerrit-Owner: Name of user not set #1002358 Gerrit-Reviewer: Name of user not set #1002358 Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-CC: ron minnich rminnich@gmail.com Gerrit-MessageType: abandon

1800

days inactive

1998

days old

coreboot-gerrit@coreboot.org

25 comments

4 participants

tags (0)

participants (4)

build bot (Jenkins) (Code Review)
Name of user not set (Code Review)
Patrick Rudolph (Code Review)
Paul Menzel (Code Review)