Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )
Change subject: src/cpu/x86 STM Support ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@44 PS1, Line 44: extern int LoadStmImage(uint32_t mseg); don't use extern
https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@831 PS1, Line 831: uint32_t mseg; uintptr_t
https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@1042 PS1, Line 1042: #ifdef CONFIG_STM no need for preprocessor directives
https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@1048 PS1, Line 1048: state->smm_save_state_size += (sizeof(TXT_PROCESSOR_SMM_DESCRIPTOR) + 0x1000) & 0xfffff000; use one of the macros: ALIGN_UP and ALIGN_DOWN