6 comments:
Patch Set #1, Line 4: EugeneDMyers
Eugene D Myers
git commit --amend --author="Eugene D Myers <cedarhouse1@comcast.net>"
Patch Set #1, Line 7: src/cpu/x86 STM Support
Please use:
cpu/x86: Add STM support
See `git log --oneline` how summaries should be done.
Patch Set #1, Line 9: STM initialization
Please elaborate.
Patch Set #1, Line 11: Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb
Please add your Signed-off-by line below.
Patch Set #1, Line 1047: * that require 32k alignment of the save state on 32K boundries.*/
Please add a space before `*/`.
/* Currently, the CPU SMM save state size is based on a simplistic
* algorithm. (set it to 1K)
* note: In the future, this will need to handle newer x86 processors
* that require 32k alignment of the save state on 32K boundries.*/
Please see the coding style about how to format multi-line comments.
/*
* …
* /
or for concise style:
/* …
… */
To view, visit change 33236. To unsubscribe, or for help writing mail filters, visit settings.