Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41947 )
Change subject: mb/*: Remove remaining fadt.c files ......................................................................
mb/*: Remove remaining fadt.c files
Change-Id: I13ed3b6e8608c37c1ebe51838e4052f89a638d83 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/intel/harcuvar/acpi_tables.c D src/mainboard/intel/harcuvar/fadt.c M src/mainboard/ocp/tiogapass/acpi_tables.c D src/mainboard/ocp/tiogapass/fadt.c M src/mainboard/scaleway/tagada/acpi_tables.c D src/mainboard/scaleway/tagada/fadt.c 6 files changed, 18 insertions(+), 34 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/41947/1
diff --git a/src/mainboard/intel/harcuvar/acpi_tables.c b/src/mainboard/intel/harcuvar/acpi_tables.c index 046d3ac..f2e6678 100644 --- a/src/mainboard/intel/harcuvar/acpi_tables.c +++ b/src/mainboard/intel/harcuvar/acpi_tables.c @@ -23,3 +23,9 @@ /* TPM Present */ gnvs->tpmp = 0; } + +void motherboard_fill_fadt(acpi_fadt_t *fadt) +{ + fadt->reserved = 0; + fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; +} diff --git a/src/mainboard/intel/harcuvar/fadt.c b/src/mainboard/intel/harcuvar/fadt.c deleted file mode 100644 index fc12fee..0000000 --- a/src/mainboard/intel/harcuvar/fadt.c +++ /dev/null @@ -1,12 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi.h> - -#include <soc/acpi.h> -#include <soc/soc_util.h> - -void motherboard_fill_fadt(acpi_fadt_t *fadt) -{ - fadt->reserved = 0; - fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; -} diff --git a/src/mainboard/ocp/tiogapass/acpi_tables.c b/src/mainboard/ocp/tiogapass/acpi_tables.c index 9a36bd3..3d359b1 100644 --- a/src/mainboard/ocp/tiogapass/acpi_tables.c +++ b/src/mainboard/ocp/tiogapass/acpi_tables.c @@ -9,3 +9,9 @@ { acpi_init_gnvs(gnvs); } + +void motherboard_fill_fadt(acpi_fadt_t *fadt) +{ + fadt->reserved = 0; + fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; +} diff --git a/src/mainboard/ocp/tiogapass/fadt.c b/src/mainboard/ocp/tiogapass/fadt.c deleted file mode 100644 index 6e07787..0000000 --- a/src/mainboard/ocp/tiogapass/fadt.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <acpi/acpi.h> -#include <soc/acpi.h> - -void motherboard_fill_fadt(acpi_fadt_t *fadt) -{ - fadt->reserved = 0; - fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; -} diff --git a/src/mainboard/scaleway/tagada/acpi_tables.c b/src/mainboard/scaleway/tagada/acpi_tables.c index 046d3ac..f2e6678 100644 --- a/src/mainboard/scaleway/tagada/acpi_tables.c +++ b/src/mainboard/scaleway/tagada/acpi_tables.c @@ -23,3 +23,9 @@ /* TPM Present */ gnvs->tpmp = 0; } + +void motherboard_fill_fadt(acpi_fadt_t *fadt) +{ + fadt->reserved = 0; + fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; +} diff --git a/src/mainboard/scaleway/tagada/fadt.c b/src/mainboard/scaleway/tagada/fadt.c deleted file mode 100644 index fc12fee..0000000 --- a/src/mainboard/scaleway/tagada/fadt.c +++ /dev/null @@ -1,12 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi.h> - -#include <soc/acpi.h> -#include <soc/soc_util.h> - -void motherboard_fill_fadt(acpi_fadt_t *fadt) -{ - fadt->reserved = 0; - fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; -}
Hello build bot (Jenkins), David Guckian, Vanessa Eusebio,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41947
to look at the new patch set (#2).
Change subject: mb/*: Remove some fadt.c files ......................................................................
mb/*: Remove some fadt.c files
Change-Id: I13ed3b6e8608c37c1ebe51838e4052f89a638d83 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/intel/harcuvar/Makefile.inc M src/mainboard/intel/harcuvar/acpi_tables.c D src/mainboard/intel/harcuvar/fadt.c M src/mainboard/ocp/tiogapass/Makefile.inc M src/mainboard/ocp/tiogapass/acpi_tables.c D src/mainboard/ocp/tiogapass/fadt.c M src/mainboard/scaleway/tagada/Makefile.inc M src/mainboard/scaleway/tagada/acpi_tables.c D src/mainboard/scaleway/tagada/fadt.c 9 files changed, 18 insertions(+), 37 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/41947/2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, David Guckian, Vanessa Eusebio,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41947
to look at the new patch set (#3).
Change subject: mb/*: Remove some fadt.c files ......................................................................
mb/*: Remove some fadt.c files
Change-Id: I13ed3b6e8608c37c1ebe51838e4052f89a638d83 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/intel/harcuvar/Makefile.inc M src/mainboard/intel/harcuvar/acpi_tables.c D src/mainboard/intel/harcuvar/fadt.c M src/mainboard/ocp/tiogapass/Makefile.inc M src/mainboard/ocp/tiogapass/acpi_tables.c D src/mainboard/ocp/tiogapass/fadt.c M src/mainboard/scaleway/tagada/Makefile.inc M src/mainboard/scaleway/tagada/acpi_tables.c D src/mainboard/scaleway/tagada/fadt.c 9 files changed, 15 insertions(+), 37 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/41947/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41947 )
Change subject: mb/*: Remove some fadt.c files ......................................................................
Patch Set 5: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41947 )
Change subject: mb/*: Remove some fadt.c files ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41947 )
Change subject: mb/*: Remove some fadt.c files ......................................................................
mb/*: Remove some fadt.c files
Change-Id: I13ed3b6e8608c37c1ebe51838e4052f89a638d83 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41947 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/harcuvar/Makefile.inc M src/mainboard/intel/harcuvar/acpi_tables.c D src/mainboard/intel/harcuvar/fadt.c M src/mainboard/ocp/tiogapass/Makefile.inc M src/mainboard/ocp/tiogapass/acpi_tables.c D src/mainboard/ocp/tiogapass/fadt.c M src/mainboard/scaleway/tagada/Makefile.inc M src/mainboard/scaleway/tagada/acpi_tables.c D src/mainboard/scaleway/tagada/fadt.c 9 files changed, 15 insertions(+), 37 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/intel/harcuvar/Makefile.inc b/src/mainboard/intel/harcuvar/Makefile.inc index bfcde9c..aa1d779 100644 --- a/src/mainboard/intel/harcuvar/Makefile.inc +++ b/src/mainboard/intel/harcuvar/Makefile.inc @@ -8,6 +8,5 @@ ramstage-y += ramstage.c ramstage-y += boardid.c ramstage-y += hsio.c -ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c
CPPFLAGS_common += -Isrc/mainboard/$(MAINBOARDDIR)/ diff --git a/src/mainboard/intel/harcuvar/acpi_tables.c b/src/mainboard/intel/harcuvar/acpi_tables.c index 1351e62..e03ec0c 100644 --- a/src/mainboard/intel/harcuvar/acpi_tables.c +++ b/src/mainboard/intel/harcuvar/acpi_tables.c @@ -22,3 +22,8 @@ /* TPM Present */ gnvs->tpmp = 0; } + +void motherboard_fill_fadt(acpi_fadt_t *fadt) +{ + fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; +} diff --git a/src/mainboard/intel/harcuvar/fadt.c b/src/mainboard/intel/harcuvar/fadt.c deleted file mode 100644 index fc12fee..0000000 --- a/src/mainboard/intel/harcuvar/fadt.c +++ /dev/null @@ -1,12 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi.h> - -#include <soc/acpi.h> -#include <soc/soc_util.h> - -void motherboard_fill_fadt(acpi_fadt_t *fadt) -{ - fadt->reserved = 0; - fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; -} diff --git a/src/mainboard/ocp/tiogapass/Makefile.inc b/src/mainboard/ocp/tiogapass/Makefile.inc index 39e67be..ca4e463 100644 --- a/src/mainboard/ocp/tiogapass/Makefile.inc +++ b/src/mainboard/ocp/tiogapass/Makefile.inc @@ -2,7 +2,6 @@
bootblock-y += bootblock.c ramstage-y += ramstage.c -ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c
CPPFLAGS_common += -I$(src)/mainboard/$(MAINBOARDDIR)/include CPPFLAGS_common += -I$(CONFIG_FSP_HEADER_PATH) diff --git a/src/mainboard/ocp/tiogapass/acpi_tables.c b/src/mainboard/ocp/tiogapass/acpi_tables.c index 9a36bd3..250ccad 100644 --- a/src/mainboard/ocp/tiogapass/acpi_tables.c +++ b/src/mainboard/ocp/tiogapass/acpi_tables.c @@ -9,3 +9,8 @@ { acpi_init_gnvs(gnvs); } + +void motherboard_fill_fadt(acpi_fadt_t *fadt) +{ + fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; +} diff --git a/src/mainboard/ocp/tiogapass/fadt.c b/src/mainboard/ocp/tiogapass/fadt.c deleted file mode 100644 index 6e07787..0000000 --- a/src/mainboard/ocp/tiogapass/fadt.c +++ /dev/null @@ -1,10 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include <acpi/acpi.h> -#include <soc/acpi.h> - -void motherboard_fill_fadt(acpi_fadt_t *fadt) -{ - fadt->reserved = 0; - fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; -} diff --git a/src/mainboard/scaleway/tagada/Makefile.inc b/src/mainboard/scaleway/tagada/Makefile.inc index fe0fc79..97bab19 100644 --- a/src/mainboard/scaleway/tagada/Makefile.inc +++ b/src/mainboard/scaleway/tagada/Makefile.inc @@ -6,7 +6,6 @@
ramstage-y += ramstage.c ramstage-y += hsio.c -ramstage-$(CONFIG_HAVE_ACPI_TABLES) += fadt.c
bootblock-y += bmcinfo.c postcar-y += bmcinfo.c diff --git a/src/mainboard/scaleway/tagada/acpi_tables.c b/src/mainboard/scaleway/tagada/acpi_tables.c index 1351e62..e03ec0c 100644 --- a/src/mainboard/scaleway/tagada/acpi_tables.c +++ b/src/mainboard/scaleway/tagada/acpi_tables.c @@ -22,3 +22,8 @@ /* TPM Present */ gnvs->tpmp = 0; } + +void motherboard_fill_fadt(acpi_fadt_t *fadt) +{ + fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; +} diff --git a/src/mainboard/scaleway/tagada/fadt.c b/src/mainboard/scaleway/tagada/fadt.c deleted file mode 100644 index fc12fee..0000000 --- a/src/mainboard/scaleway/tagada/fadt.c +++ /dev/null @@ -1,12 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <acpi/acpi.h> - -#include <soc/acpi.h> -#include <soc/soc_util.h> - -void motherboard_fill_fadt(acpi_fadt_t *fadt) -{ - fadt->reserved = 0; - fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; -}
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41947 )
Change subject: mb/*: Remove some fadt.c files ......................................................................
Patch Set 6:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/5269 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5268 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5267 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/5266
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)