Change in coreboot[master]: soc/intel/braswell,broadwell,quark: Select COMMON_FADT

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/braswell,broadwell,quark: Select COMMON_FADT
......................................................................

soc/intel/braswell,broadwell,quark: Select COMMON_FADT

Change-Id: I04b602b2c23fbd163fcd110a44ad25c6be07ab66
Signed-off-by: Kyösti Mälkki 
---
D src/mainboard/facebook/fbg1701/fadt.c
D src/mainboard/google/auron/fadt.c
D src/mainboard/google/cyan/fadt.c
D src/mainboard/google/jecht/fadt.c
D src/mainboard/google/rambi/fadt.c
D src/mainboard/intel/galileo/acpi_tables.c
D src/mainboard/intel/strago/fadt.c
D src/mainboard/intel/wtm2/fadt.c
D src/mainboard/portwell/m107/fadt.c
D src/mainboard/protectli/vault_bsw/fadt.c
D src/mainboard/purism/librem_bdw/fadt.c
M src/soc/intel/braswell/Kconfig
M src/soc/intel/broadwell/Kconfig
M src/soc/intel/quark/Kconfig
14 files changed, 3 insertions(+), 355 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/41920/1

diff --git a/src/mainboard/facebook/fbg1701/fadt.c b/src/mainboard/facebook/fbg1701/fadt.c
deleted file mode 100644
index c6c53e3..0000000
--- a/src/mainboard/facebook/fbg1701/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-	motherboard_fill_fadt(fadt);
-
-	header->checksum =
-	    acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/google/auron/fadt.c b/src/mainboard/google/auron/fadt.c
deleted file mode 100644
index d6d3ea0..0000000
--- a/src/mainboard/google/auron/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <string.h>
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-	fadt->reserved = 0;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/google/cyan/fadt.c b/src/mainboard/google/cyan/fadt.c
deleted file mode 100644
index 901fc82..0000000
--- a/src/mainboard/google/cyan/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <soc/acpi.h>
-#include <string.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-	fadt->reserved = 0;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/google/jecht/fadt.c b/src/mainboard/google/jecht/fadt.c
deleted file mode 100644
index d6d3ea0..0000000
--- a/src/mainboard/google/jecht/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <string.h>
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-	fadt->reserved = 0;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/google/rambi/fadt.c b/src/mainboard/google/rambi/fadt.c
deleted file mode 100644
index d6d3ea0..0000000
--- a/src/mainboard/google/rambi/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <string.h>
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-	fadt->reserved = 0;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/intel/galileo/acpi_tables.c b/src/mainboard/intel/galileo/acpi_tables.c
deleted file mode 100644
index 6666be3..0000000
--- a/src/mainboard/intel/galileo/acpi_tables.c
+++ /dev/null
@@ -1,25 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <string.h>
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	/* Initialize the FADT header */
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = ACPI_FADT_REV_ACPI_5_0;
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	/* Fill in SoC specific values */
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/intel/strago/fadt.c b/src/mainboard/intel/strago/fadt.c
deleted file mode 100644
index 901fc82..0000000
--- a/src/mainboard/intel/strago/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <soc/acpi.h>
-#include <string.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-	fadt->reserved = 0;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/intel/wtm2/fadt.c b/src/mainboard/intel/wtm2/fadt.c
deleted file mode 100644
index 6858bc1..0000000
--- a/src/mainboard/intel/wtm2/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <string.h>
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = ACPI_FADT_REV_ACPI_5_0;
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-	fadt->reserved = 0;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/portwell/m107/fadt.c b/src/mainboard/portwell/m107/fadt.c
deleted file mode 100644
index c6c53e3..0000000
--- a/src/mainboard/portwell/m107/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-	motherboard_fill_fadt(fadt);
-
-	header->checksum =
-	    acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/protectli/vault_bsw/fadt.c b/src/mainboard/protectli/vault_bsw/fadt.c
deleted file mode 100644
index 3fb84d2..0000000
--- a/src/mainboard/protectli/vault_bsw/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
-
-#include <soc/acpi.h>
-#include <string.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long)facs;
-	fadt->dsdt = (unsigned long) dsdt;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-	motherboard_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *)fadt, header->length);
-}
diff --git a/src/mainboard/purism/librem_bdw/fadt.c b/src/mainboard/purism/librem_bdw/fadt.c
deleted file mode 100644
index 5904f62..0000000
--- a/src/mainboard/purism/librem_bdw/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <string.h>
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
-{
-	acpi_header_t *header = &fadt->header;
-
-	memset(fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (u32)facs;
-	fadt->dsdt = (u32)dsdt;
-	fadt->reserved = 0;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (u32)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (u32)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *)fadt, header->length);
-}
diff --git a/src/soc/intel/braswell/Kconfig b/src/soc/intel/braswell/Kconfig
index a437db2..f99ab98 100644
--- a/src/soc/intel/braswell/Kconfig
+++ b/src/soc/intel/braswell/Kconfig
@@ -15,6 +15,7 @@
    select BOOT_DEVICE_SUPPORTS_WRITES
    select CACHE_MRC_SETTINGS
    select SUPPORT_CPU_UCODE_IN_CBFS
+	select COMMON_FADT
    select CPU_INTEL_TURBO_NOT_PACKAGE_SCOPED
    select HAVE_SMI_HANDLER
    select NO_FIXED_XIP_ROM_SIZE
diff --git a/src/soc/intel/broadwell/Kconfig b/src/soc/intel/broadwell/Kconfig
index 67f7563..a3c6f03 100644
--- a/src/soc/intel/broadwell/Kconfig
+++ b/src/soc/intel/broadwell/Kconfig
@@ -15,6 +15,7 @@
    select BOOT_DEVICE_SUPPORTS_WRITES
    select CACHE_MRC_SETTINGS
    select MRC_SETTINGS_PROTECT
+	select COMMON_FADT
    select CPU_INTEL_COMMON
    select CPU_INTEL_FIRMWARE_INTERFACE_TABLE
    select SUPPORT_CPU_UCODE_IN_CBFS
diff --git a/src/soc/intel/quark/Kconfig b/src/soc/intel/quark/Kconfig
index 4ecf6c1..12bcb99 100644
--- a/src/soc/intel/quark/Kconfig
+++ b/src/soc/intel/quark/Kconfig
@@ -26,6 +26,7 @@
    select UNCOMPRESSED_RAMSTAGE
    select USE_MARCH_586
    select NO_SMM
+	select COMMON_FADT

#####
 # Debug serial output

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Kyösti Mälkki (Code Review)]

Hello build bot (Jenkins), Michał Żygowski, Frans Hendriks, Patrick Rudolph, Piotr Król, Wim Vervoorn,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41920

to look at the new patch set (#2).

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

Change-Id: I04b602b2c23fbd163fcd110a44ad25c6be07ab66
Signed-off-by: Kyösti Mälkki 
---
D src/mainboard/facebook/fbg1701/fadt.c
D src/mainboard/google/auron/fadt.c
D src/mainboard/google/cyan/fadt.c
D src/mainboard/google/jecht/fadt.c
D src/mainboard/google/rambi/fadt.c
D src/mainboard/intel/galileo/acpi_tables.c
D src/mainboard/intel/strago/fadt.c
D src/mainboard/intel/wtm2/fadt.c
D src/mainboard/portwell/m107/fadt.c
D src/mainboard/protectli/vault_bsw/fadt.c
D src/mainboard/purism/librem_bdw/fadt.c
M src/soc/intel/baytrail/Kconfig
M src/soc/intel/braswell/Kconfig
M src/soc/intel/broadwell/Kconfig
M src/soc/intel/quark/Kconfig
15 files changed, 4 insertions(+), 355 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/41920/2

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Kyösti Mälkki (Code Review)]

Hello build bot (Jenkins), Michał Żygowski, Frans Hendriks, Patrick Rudolph, Piotr Król, Wim Vervoorn,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41920

to look at the new patch set (#4).

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

Change-Id: I04b602b2c23fbd163fcd110a44ad25c6be07ab66
Signed-off-by: Kyösti Mälkki 
---
D src/mainboard/facebook/fbg1701/fadt.c
D src/mainboard/google/auron/fadt.c
D src/mainboard/google/cyan/fadt.c
D src/mainboard/google/jecht/fadt.c
D src/mainboard/google/rambi/fadt.c
D src/mainboard/intel/galileo/acpi_tables.c
D src/mainboard/intel/strago/fadt.c
D src/mainboard/intel/wtm2/fadt.c
D src/mainboard/portwell/m107/fadt.c
D src/mainboard/protectli/vault_bsw/fadt.c
D src/mainboard/purism/librem_bdw/fadt.c
M src/soc/intel/baytrail/Kconfig
M src/soc/intel/braswell/Kconfig
M src/soc/intel/broadwell/Kconfig
M src/soc/intel/quark/Kconfig
15 files changed, 4 insertions(+), 352 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/41920/4

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Wim Vervoorn (Code Review)]

Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

Patch Set 4: Code-Review+2

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

Patch Set 4: Code-Review+2

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

Patch Set 5: Code-Review-1

this is going to change the FADT PM profile for a lot of the affected boards from PM_MOBILE to PM_DESKTOP (eg, google/jecht, google/auron/buddy, and the protectli Braswell boards). Is that desired or advisable? Is there any actual difference? At the very least it should be noted in the commit msg.

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

Patch Set 5:
> Patch Set 5: Code-Review-1
>
> this is going to change the FADT PM profile for a lot of the affected boards from PM_MOBILE to PM_DESKTOP (eg, google/jecht, google/auron/buddy, and the protectli Braswell boards). Is that desired or advisable? Is there any actual difference? At the very least it should be noted in the commit msg.

FADT changes are not desireable here. CB:42032 is related but does not address the boards you mention here.

That protectli/vault_bsw is covered by CB:41917. I can add similar override for jecht and buddy, unless those should have some select SYSTEM_TYPE_xx instead and get their preferred_pm_profile right that way.

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

Patch Set 5:
> Patch Set 5:
>
> That protectli/vault_bsw is covered by CB:41917. I can add similar override for jecht and buddy, unless those should have some select SYSTEM_TYPE_xx instead and get their preferred_pm_profile right that way.

that sounds perfectly reasonable to me, thanks

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Kyösti Mälkki (Code Review)]

Hello build bot (Jenkins), Michał Żygowski, Frans Hendriks, Matt DeVillier, Patrick Rudolph, Wim Vervoorn, Piotr Król,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41920

to look at the new patch set (#6).

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

Some of the boards do not select SYSTEM_TYPE_LAPTOP or _CONVERTIBLE
so their FADT preffered_pm_profile would change from PM_PROFILE without
the added overrides here.

Change-Id: I04b602b2c23fbd163fcd110a44ad25c6be07ab66
Signed-off-by: Kyösti Mälkki 
---
D src/mainboard/facebook/fbg1701/fadt.c
M src/mainboard/google/auron/acpi_tables.c
D src/mainboard/google/auron/fadt.c
D src/mainboard/google/cyan/fadt.c
M src/mainboard/google/jecht/acpi_tables.c
D src/mainboard/google/jecht/fadt.c
M src/mainboard/google/rambi/acpi_tables.c
D src/mainboard/google/rambi/fadt.c
D src/mainboard/intel/galileo/acpi_tables.c
M src/mainboard/intel/strago/acpi_tables.c
D src/mainboard/intel/strago/fadt.c
M src/mainboard/intel/wtm2/acpi_tables.c
D src/mainboard/intel/wtm2/fadt.c
D src/mainboard/portwell/m107/fadt.c
D src/mainboard/protectli/vault_bsw/fadt.c
D src/mainboard/purism/librem_bdw/fadt.c
M src/soc/intel/baytrail/Kconfig
M src/soc/intel/braswell/Kconfig
M src/soc/intel/broadwell/Kconfig
M src/soc/intel/quark/Kconfig
20 files changed, 29 insertions(+), 352 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/41920/6

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

Patch Set 6: Code-Review+2

(1 comment)

Much better!

https://review.coreboot.org/c/coreboot/+/41920/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41920/6//COMMIT_MSG@10 
PS6, Line 10: PM_PROFILE
PM_MOBILE

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41920/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41920/6//COMMIT_MSG@7 
PS6, Line 7: soc/intel/baytrail,braswell,broadwell,quark:
Maybe splitting this into platforms would result in easier-to-digest commits

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Kyösti Mälkki (Code Review)]

Hello build bot (Jenkins), Michał Żygowski, Frans Hendriks, Matt DeVillier, Angel Pons, Patrick Rudolph, Wim Vervoorn, Piotr Król,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41920

to look at the new patch set (#7).

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

Some of the boards do not select SYSTEM_TYPE_LAPTOP or _CONVERTIBLE
so their FADT preffered_pm_profile would change from PM_MOBILE without
the added overrides here.

Change-Id: I04b602b2c23fbd163fcd110a44ad25c6be07ab66
Signed-off-by: Kyösti Mälkki 
---
D src/mainboard/facebook/fbg1701/fadt.c
M src/mainboard/google/auron/acpi_tables.c
D src/mainboard/google/auron/fadt.c
D src/mainboard/google/cyan/fadt.c
M src/mainboard/google/jecht/acpi_tables.c
D src/mainboard/google/jecht/fadt.c
M src/mainboard/google/rambi/acpi_tables.c
D src/mainboard/google/rambi/fadt.c
D src/mainboard/intel/galileo/acpi_tables.c
M src/mainboard/intel/strago/acpi_tables.c
D src/mainboard/intel/strago/fadt.c
M src/mainboard/intel/wtm2/acpi_tables.c
D src/mainboard/intel/wtm2/fadt.c
D src/mainboard/portwell/m107/fadt.c
D src/mainboard/protectli/vault_bsw/fadt.c
D src/mainboard/purism/librem_bdw/fadt.c
M src/soc/intel/baytrail/Kconfig
M src/soc/intel/braswell/Kconfig
M src/soc/intel/broadwell/Kconfig
M src/soc/intel/quark/Kconfig
20 files changed, 29 insertions(+), 352 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/41920/7

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

Patch Set 7:

(2 comments)
> Patch Set 5:
> > Patch Set 5:
> >
> > That protectli/vault_bsw is covered by CB:41917. I can add similar override for jecht and buddy, unless those should have some select SYSTEM_TYPE_xx instead and get their preferred_pm_profile right that way.
>
> that sounds perfectly reasonable to me, thanks

If one variant is SYSTEM_TYPE_LAPTOP, I would say SYSTEM_TYPE_DESKTOP is likely not the correct one for the other variants, assuming they have battery.

Similarly, advertising PM_MOBILE for a unit that does have a battery seems wrong.

Duncan? Any ideas

https://review.coreboot.org/c/coreboot/+/41920/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41920/6//COMMIT_MSG@7 
PS6, Line 7: soc/intel/baytrail,braswell,broadwell,quark:
> Maybe splitting this into platforms would result in easier-to-digest commits

I don't think it would make much difference.

https://review.coreboot.org/c/coreboot/+/41920/6//COMMIT_MSG@10 
PS6, Line 10: PM_PROFILE
> PM_MOBILE

Done

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

Patch Set 7:
> Patch Set 7:
>
> (2 comments)
> > Patch Set 5:
> > > Patch Set 5:
> > >
> > > That protectli/vault_bsw is covered by CB:41917. I can add similar override for jecht and buddy, unless those should have some select SYSTEM_TYPE_xx instead and get their preferred_pm_profile right that way.
> >
> > that sounds perfectly reasonable to me, thanks
>
> If one variant is SYSTEM_TYPE_LAPTOP, I would say SYSTEM_TYPE_DESKTOP is likely not the correct one for the other variants, assuming they have battery.
>
> Similarly, advertising PM_MOBILE for a unit that does have a battery seems wrong.
>
> Duncan? Any ideas

Ok.. So the entire SMBIOS_ENCLOSURE_TYPE is a bit of a mess, there will be followups on the topic. I have also discovered google/zork has fadt_pm_profile in devicetree.cb now.

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

Patch Set 7: Code-Review+2

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

Patch Set 7: Code-Review+2

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41920/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41920/6//COMMIT_MSG@7 
PS6, Line 7: soc/intel/baytrail,braswell,broadwell,quark:
> I don't think it would make much difference.

Ack

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

Some of the boards do not select SYSTEM_TYPE_LAPTOP or _CONVERTIBLE
so their FADT preffered_pm_profile would change from PM_MOBILE without
the added overrides here.

Change-Id: I04b602b2c23fbd163fcd110a44ad25c6be07ab66
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41920
Reviewed-by: Nico Huber 
Reviewed-by: Matt DeVillier 
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
D src/mainboard/facebook/fbg1701/fadt.c
M src/mainboard/google/auron/acpi_tables.c
D src/mainboard/google/auron/fadt.c
D src/mainboard/google/cyan/fadt.c
M src/mainboard/google/jecht/acpi_tables.c
D src/mainboard/google/jecht/fadt.c
M src/mainboard/google/rambi/acpi_tables.c
D src/mainboard/google/rambi/fadt.c
D src/mainboard/intel/galileo/acpi_tables.c
M src/mainboard/intel/strago/acpi_tables.c
D src/mainboard/intel/strago/fadt.c
M src/mainboard/intel/wtm2/acpi_tables.c
D src/mainboard/intel/wtm2/fadt.c
D src/mainboard/portwell/m107/fadt.c
D src/mainboard/protectli/vault_bsw/fadt.c
D src/mainboard/purism/librem_bdw/fadt.c
M src/soc/intel/baytrail/Kconfig
M src/soc/intel/braswell/Kconfig
M src/soc/intel/broadwell/Kconfig
M src/soc/intel/quark/Kconfig
20 files changed, 29 insertions(+), 352 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  Matt DeVillier: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/facebook/fbg1701/fadt.c b/src/mainboard/facebook/fbg1701/fadt.c
deleted file mode 100644
index 8436519..0000000
--- a/src/mainboard/facebook/fbg1701/fadt.c
+++ /dev/null
@@ -1,32 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-	motherboard_fill_fadt(fadt);
-
-	header->checksum =
-	    acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/google/auron/acpi_tables.c b/src/mainboard/google/auron/acpi_tables.c
index befe84e..ce21cb0 100644
--- a/src/mainboard/google/auron/acpi_tables.c
+++ b/src/mainboard/google/auron/acpi_tables.c
@@ -34,3 +34,8 @@

return acpi_madt_irq_overrides(current);
 }
+
+void motherboard_fill_fadt(acpi_fadt_t *fadt)
+{
+	fadt->preferred_pm_profile = PM_MOBILE;
+}
diff --git a/src/mainboard/google/auron/fadt.c b/src/mainboard/google/auron/fadt.c
deleted file mode 100644
index d6d3ea0..0000000
--- a/src/mainboard/google/auron/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <string.h>
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-	fadt->reserved = 0;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/google/cyan/fadt.c b/src/mainboard/google/cyan/fadt.c
deleted file mode 100644
index 901fc82..0000000
--- a/src/mainboard/google/cyan/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <soc/acpi.h>
-#include <string.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-	fadt->reserved = 0;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/google/jecht/acpi_tables.c b/src/mainboard/google/jecht/acpi_tables.c
index 3e8cc20..4dd6d49 100644
--- a/src/mainboard/google/jecht/acpi_tables.c
+++ b/src/mainboard/google/jecht/acpi_tables.c
@@ -36,3 +36,8 @@

return acpi_madt_irq_overrides(current);
 }
+
+void motherboard_fill_fadt(acpi_fadt_t *fadt)
+{
+	fadt->preferred_pm_profile = PM_MOBILE;
+}
diff --git a/src/mainboard/google/jecht/fadt.c b/src/mainboard/google/jecht/fadt.c
deleted file mode 100644
index d6d3ea0..0000000
--- a/src/mainboard/google/jecht/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <string.h>
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-	fadt->reserved = 0;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/google/rambi/acpi_tables.c b/src/mainboard/google/rambi/acpi_tables.c
index c4c1788..9b91266 100644
--- a/src/mainboard/google/rambi/acpi_tables.c
+++ b/src/mainboard/google/rambi/acpi_tables.c
@@ -40,3 +40,8 @@

return current;
 }
+
+void motherboard_fill_fadt(acpi_fadt_t *fadt)
+{
+	fadt->preferred_pm_profile = PM_MOBILE;
+}
diff --git a/src/mainboard/google/rambi/fadt.c b/src/mainboard/google/rambi/fadt.c
deleted file mode 100644
index d6d3ea0..0000000
--- a/src/mainboard/google/rambi/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <string.h>
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-	fadt->reserved = 0;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/intel/galileo/acpi_tables.c b/src/mainboard/intel/galileo/acpi_tables.c
deleted file mode 100644
index 6666be3..0000000
--- a/src/mainboard/intel/galileo/acpi_tables.c
+++ /dev/null
@@ -1,25 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <string.h>
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	/* Initialize the FADT header */
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = ACPI_FADT_REV_ACPI_5_0;
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	/* Fill in SoC specific values */
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/intel/strago/acpi_tables.c b/src/mainboard/intel/strago/acpi_tables.c
index e97d9c1..eec4790 100644
--- a/src/mainboard/intel/strago/acpi_tables.c
+++ b/src/mainboard/intel/strago/acpi_tables.c
@@ -42,3 +42,8 @@

return current;
 }
+
+void motherboard_fill_fadt(acpi_fadt_t *fadt)
+{
+	fadt->preferred_pm_profile = PM_MOBILE;
+}
diff --git a/src/mainboard/intel/strago/fadt.c b/src/mainboard/intel/strago/fadt.c
deleted file mode 100644
index 901fc82..0000000
--- a/src/mainboard/intel/strago/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <soc/acpi.h>
-#include <string.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-	fadt->reserved = 0;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/intel/wtm2/acpi_tables.c b/src/mainboard/intel/wtm2/acpi_tables.c
index 87cb965..6e56cf0 100644
--- a/src/mainboard/intel/wtm2/acpi_tables.c
+++ b/src/mainboard/intel/wtm2/acpi_tables.c
@@ -34,3 +34,8 @@

return acpi_madt_irq_overrides(current);
 }
+
+void motherboard_fill_fadt(acpi_fadt_t *fadt)
+{
+	fadt->preferred_pm_profile = PM_MOBILE;
+}
diff --git a/src/mainboard/intel/wtm2/fadt.c b/src/mainboard/intel/wtm2/fadt.c
deleted file mode 100644
index 6858bc1..0000000
--- a/src/mainboard/intel/wtm2/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <string.h>
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t * fadt, acpi_facs_t * facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = ACPI_FADT_REV_ACPI_5_0;
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-	fadt->reserved = 0;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/portwell/m107/fadt.c b/src/mainboard/portwell/m107/fadt.c
deleted file mode 100644
index 8436519..0000000
--- a/src/mainboard/portwell/m107/fadt.c
+++ /dev/null
@@ -1,32 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long) facs;
-	fadt->dsdt = (unsigned long) dsdt;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-	motherboard_fill_fadt(fadt);
-
-	header->checksum =
-	    acpi_checksum((void *) fadt, header->length);
-}
diff --git a/src/mainboard/protectli/vault_bsw/fadt.c b/src/mainboard/protectli/vault_bsw/fadt.c
deleted file mode 100644
index 37166c3..0000000
--- a/src/mainboard/protectli/vault_bsw/fadt.c
+++ /dev/null
@@ -1,32 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
-
-#include <soc/acpi.h>
-#include <string.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
-{
-	acpi_header_t *header = &(fadt->header);
-
-	memset((void *) fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (unsigned long)facs;
-	fadt->dsdt = (unsigned long) dsdt;
-
-	fadt->x_firmware_ctl_l = (unsigned long)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (unsigned long)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-	motherboard_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *)fadt, header->length);
-}
diff --git a/src/mainboard/purism/librem_bdw/fadt.c b/src/mainboard/purism/librem_bdw/fadt.c
deleted file mode 100644
index 5904f62..0000000
--- a/src/mainboard/purism/librem_bdw/fadt.c
+++ /dev/null
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-#include <string.h>
-#include <soc/acpi.h>
-#include <version.h>
-
-void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt)
-{
-	acpi_header_t *header = &fadt->header;
-
-	memset(fadt, 0, sizeof(acpi_fadt_t));
-	memcpy(header->signature, "FACP", 4);
-	header->length = sizeof(acpi_fadt_t);
-	header->revision = get_acpi_table_revision(FADT);
-	memcpy(header->oem_id, OEM_ID, 6);
-	memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8);
-	memcpy(header->asl_compiler_id, ASLC, 4);
-	header->asl_compiler_revision = asl_revision;
-
-	fadt->firmware_ctrl = (u32)facs;
-	fadt->dsdt = (u32)dsdt;
-	fadt->reserved = 0;
-	fadt->preferred_pm_profile = PM_MOBILE;
-
-	fadt->x_firmware_ctl_l = (u32)facs;
-	fadt->x_firmware_ctl_h = 0;
-	fadt->x_dsdt_l = (u32)dsdt;
-	fadt->x_dsdt_h = 0;
-
-	acpi_fill_fadt(fadt);
-
-	header->checksum = acpi_checksum((void *)fadt, header->length);
-}
diff --git a/src/soc/intel/baytrail/Kconfig b/src/soc/intel/baytrail/Kconfig
index 1fd9c40..692aee5 100644
--- a/src/soc/intel/baytrail/Kconfig
+++ b/src/soc/intel/baytrail/Kconfig
@@ -14,6 +14,7 @@
    select ARCH_RAMSTAGE_X86_32
    select BOOT_DEVICE_SUPPORTS_WRITES
    select CACHE_MRC_SETTINGS
+	select COMMON_FADT
    select CPU_INTEL_TURBO_NOT_PACKAGE_SCOPED
    select SUPPORT_CPU_UCODE_IN_CBFS
    select HAVE_SMI_HANDLER
diff --git a/src/soc/intel/braswell/Kconfig b/src/soc/intel/braswell/Kconfig
index a437db2..f99ab98 100644
--- a/src/soc/intel/braswell/Kconfig
+++ b/src/soc/intel/braswell/Kconfig
@@ -15,6 +15,7 @@
    select BOOT_DEVICE_SUPPORTS_WRITES
    select CACHE_MRC_SETTINGS
    select SUPPORT_CPU_UCODE_IN_CBFS
+	select COMMON_FADT
    select CPU_INTEL_TURBO_NOT_PACKAGE_SCOPED
    select HAVE_SMI_HANDLER
    select NO_FIXED_XIP_ROM_SIZE
diff --git a/src/soc/intel/broadwell/Kconfig b/src/soc/intel/broadwell/Kconfig
index 67f7563..a3c6f03 100644
--- a/src/soc/intel/broadwell/Kconfig
+++ b/src/soc/intel/broadwell/Kconfig
@@ -15,6 +15,7 @@
    select BOOT_DEVICE_SUPPORTS_WRITES
    select CACHE_MRC_SETTINGS
    select MRC_SETTINGS_PROTECT
+	select COMMON_FADT
    select CPU_INTEL_COMMON
    select CPU_INTEL_FIRMWARE_INTERFACE_TABLE
    select SUPPORT_CPU_UCODE_IN_CBFS
diff --git a/src/soc/intel/quark/Kconfig b/src/soc/intel/quark/Kconfig
index 4ecf6c1..12bcb99 100644
--- a/src/soc/intel/quark/Kconfig
+++ b/src/soc/intel/quark/Kconfig
@@ -26,6 +26,7 @@
    select UNCOMPRESSED_RAMSTAGE
    select USE_MARCH_586
    select NO_SMM
+	select COMMON_FADT

#####
 # Debug serial output

Change in coreboot[master]: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )

Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................

Patch Set 8:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4
Emulation targets:
"QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/5263
"QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5262
"QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5261
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/5260

Please note: This test is under development and might not be accurate at all!