Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41920 )
Change subject: soc/intel/baytrail,braswell,broadwell,quark: Select COMMON_FADT
......................................................................
Patch Set 5:
Patch Set 5:
That protectli/vault_bsw is covered by CB:41917. I can add similar override for jecht and buddy, unless those should have some select SYSTEM_TYPE_xx instead and get their preferred_pm_profile right that way.
that sounds perfectly reasonable to me, thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41920
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I04b602b2c23fbd163fcd110a44ad25c6be07ab66
Gerrit-Change-Number: 41920
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 07 Jun 2020 05:26:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment