Change in coreboot[master]: acpi: Rename motherboard_fill_fadt() to mainboard_fill_fadt()
Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42007 )
Change subject: acpi: Rename motherboard_fill_fadt() to mainboard_fill_fadt() ......................................................................
acpi: Rename motherboard_fill_fadt() to mainboard_fill_fadt()
Change-Id: Ie576fd47301aa484cb1396e0c6f7260b7698af4d Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/acpi/acpi.c M src/include/acpi/acpi.h M src/mainboard/facebook/fbg1701/acpi_tables.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/ocp/tiogapass/acpi_tables.c M src/mainboard/portwell/m107/acpi_tables.c M src/mainboard/protectli/vault_bsw/acpi_tables.c M src/mainboard/scaleway/tagada/acpi_tables.c 8 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/42007/1
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 2f4a2bb..fefa7bf 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1222,7 +1222,7 @@ #if CONFIG(COMMON_FADT)
__weak void soc_fill_fadt(acpi_fadt_t *fadt) { } -__weak void motherboard_fill_fadt(acpi_fadt_t *fadt) { } +__weak void mainboard_fill_fadt(acpi_fadt_t *fadt) { }
void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt) { @@ -1261,7 +1261,7 @@ acpi_fill_fadt(fadt);
soc_fill_fadt(fadt); - motherboard_fill_fadt(fadt); + mainboard_fill_fadt(fadt);
header->checksum = acpi_checksum((void *) fadt, header->length); diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 0691797..207e8dc 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -871,7 +871,7 @@
void acpi_fill_fadt(acpi_fadt_t *fadt); void soc_fill_fadt(acpi_fadt_t *fadt); -void motherboard_fill_fadt(acpi_fadt_t *fadt); +void mainboard_fill_fadt(acpi_fadt_t *fadt);
void update_ssdt(void *ssdt); void update_ssdtx(void *ssdtx, int i); diff --git a/src/mainboard/facebook/fbg1701/acpi_tables.c b/src/mainboard/facebook/fbg1701/acpi_tables.c index 8492704..e98df14 100644 --- a/src/mainboard/facebook/fbg1701/acpi_tables.c +++ b/src/mainboard/facebook/fbg1701/acpi_tables.c @@ -38,7 +38,7 @@ return current; }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_MOBILE; fadt->iapc_boot_arch &= ~ACPI_FADT_8042; diff --git a/src/mainboard/intel/harcuvar/acpi_tables.c b/src/mainboard/intel/harcuvar/acpi_tables.c index 6f8bd07..4be3f6f 100644 --- a/src/mainboard/intel/harcuvar/acpi_tables.c +++ b/src/mainboard/intel/harcuvar/acpi_tables.c @@ -24,7 +24,7 @@ gnvs->tpmp = 0; }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; } diff --git a/src/mainboard/ocp/tiogapass/acpi_tables.c b/src/mainboard/ocp/tiogapass/acpi_tables.c index 250ccad..85372e5 100644 --- a/src/mainboard/ocp/tiogapass/acpi_tables.c +++ b/src/mainboard/ocp/tiogapass/acpi_tables.c @@ -10,7 +10,7 @@ acpi_init_gnvs(gnvs); }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; } diff --git a/src/mainboard/portwell/m107/acpi_tables.c b/src/mainboard/portwell/m107/acpi_tables.c index 8492704..e98df14 100644 --- a/src/mainboard/portwell/m107/acpi_tables.c +++ b/src/mainboard/portwell/m107/acpi_tables.c @@ -38,7 +38,7 @@ return current; }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_MOBILE; fadt->iapc_boot_arch &= ~ACPI_FADT_8042; diff --git a/src/mainboard/protectli/vault_bsw/acpi_tables.c b/src/mainboard/protectli/vault_bsw/acpi_tables.c index 9ecb5ac..1724c71 100644 --- a/src/mainboard/protectli/vault_bsw/acpi_tables.c +++ b/src/mainboard/protectli/vault_bsw/acpi_tables.c @@ -28,7 +28,7 @@ return current; }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_MOBILE; fadt->iapc_boot_arch = ACPI_FADT_LEGACY_DEVICES; diff --git a/src/mainboard/scaleway/tagada/acpi_tables.c b/src/mainboard/scaleway/tagada/acpi_tables.c index 6f8bd07..4be3f6f 100644 --- a/src/mainboard/scaleway/tagada/acpi_tables.c +++ b/src/mainboard/scaleway/tagada/acpi_tables.c @@ -24,7 +24,7 @@ gnvs->tpmp = 0; }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; }
Hello build bot (Jenkins), David Guckian, Michał Żygowski, Frans Hendriks, Vanessa Eusebio, Piotr Król, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42007
to look at the new patch set (#3).
Change subject: acpi: Rename motherboard_fill_fadt() to mainboard_fill_fadt() ......................................................................
acpi: Rename motherboard_fill_fadt() to mainboard_fill_fadt()
The prefix mainboard_ was used everywhere else.
Change-Id: Ie576fd47301aa484cb1396e0c6f7260b7698af4d Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/acpi/acpi.c M src/include/acpi/acpi.h M src/mainboard/facebook/fbg1701/acpi_tables.c M src/mainboard/google/auron/acpi_tables.c M src/mainboard/google/jecht/acpi_tables.c M src/mainboard/google/rambi/acpi_tables.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/intel/strago/acpi_tables.c M src/mainboard/intel/wtm2/acpi_tables.c M src/mainboard/ocp/tiogapass/acpi_tables.c M src/mainboard/portwell/m107/acpi_tables.c M src/mainboard/protectli/vault_bsw/acpi_tables.c M src/mainboard/scaleway/tagada/acpi_tables.c 13 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/42007/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42007 )
Change subject: acpi: Rename motherboard_fill_fadt() to mainboard_fill_fadt() ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42007 )
Change subject: acpi: Rename motherboard_fill_fadt() to mainboard_fill_fadt() ......................................................................
acpi: Rename motherboard_fill_fadt() to mainboard_fill_fadt()
The prefix mainboard_ was used everywhere else.
Change-Id: Ie576fd47301aa484cb1396e0c6f7260b7698af4d Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42007 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/acpi/acpi.c M src/include/acpi/acpi.h M src/mainboard/facebook/fbg1701/acpi_tables.c M src/mainboard/google/auron/acpi_tables.c M src/mainboard/google/jecht/acpi_tables.c M src/mainboard/google/rambi/acpi_tables.c M src/mainboard/intel/harcuvar/acpi_tables.c M src/mainboard/intel/strago/acpi_tables.c M src/mainboard/intel/wtm2/acpi_tables.c M src/mainboard/ocp/tiogapass/acpi_tables.c M src/mainboard/portwell/m107/acpi_tables.c M src/mainboard/protectli/vault_bsw/acpi_tables.c M src/mainboard/scaleway/tagada/acpi_tables.c 13 files changed, 14 insertions(+), 14 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 2f4a2bb..fefa7bf 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1222,7 +1222,7 @@ #if CONFIG(COMMON_FADT)
__weak void soc_fill_fadt(acpi_fadt_t *fadt) { } -__weak void motherboard_fill_fadt(acpi_fadt_t *fadt) { } +__weak void mainboard_fill_fadt(acpi_fadt_t *fadt) { }
void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt) { @@ -1261,7 +1261,7 @@ acpi_fill_fadt(fadt);
soc_fill_fadt(fadt); - motherboard_fill_fadt(fadt); + mainboard_fill_fadt(fadt);
header->checksum = acpi_checksum((void *) fadt, header->length); diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 57109b4..cd99899 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -879,7 +879,7 @@
void acpi_fill_fadt(acpi_fadt_t *fadt); void soc_fill_fadt(acpi_fadt_t *fadt); -void motherboard_fill_fadt(acpi_fadt_t *fadt); +void mainboard_fill_fadt(acpi_fadt_t *fadt);
void update_ssdt(void *ssdt); void update_ssdtx(void *ssdtx, int i); diff --git a/src/mainboard/facebook/fbg1701/acpi_tables.c b/src/mainboard/facebook/fbg1701/acpi_tables.c index 8492704..e98df14 100644 --- a/src/mainboard/facebook/fbg1701/acpi_tables.c +++ b/src/mainboard/facebook/fbg1701/acpi_tables.c @@ -38,7 +38,7 @@ return current; }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_MOBILE; fadt->iapc_boot_arch &= ~ACPI_FADT_8042; diff --git a/src/mainboard/google/auron/acpi_tables.c b/src/mainboard/google/auron/acpi_tables.c index ce21cb0..4c72f3e 100644 --- a/src/mainboard/google/auron/acpi_tables.c +++ b/src/mainboard/google/auron/acpi_tables.c @@ -35,7 +35,7 @@ return acpi_madt_irq_overrides(current); }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_MOBILE; } diff --git a/src/mainboard/google/jecht/acpi_tables.c b/src/mainboard/google/jecht/acpi_tables.c index 4dd6d49..c566d84 100644 --- a/src/mainboard/google/jecht/acpi_tables.c +++ b/src/mainboard/google/jecht/acpi_tables.c @@ -37,7 +37,7 @@ return acpi_madt_irq_overrides(current); }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_MOBILE; } diff --git a/src/mainboard/google/rambi/acpi_tables.c b/src/mainboard/google/rambi/acpi_tables.c index 9b91266..c336d53 100644 --- a/src/mainboard/google/rambi/acpi_tables.c +++ b/src/mainboard/google/rambi/acpi_tables.c @@ -41,7 +41,7 @@ return current; }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_MOBILE; } diff --git a/src/mainboard/intel/harcuvar/acpi_tables.c b/src/mainboard/intel/harcuvar/acpi_tables.c index e03ec0c..b939a81 100644 --- a/src/mainboard/intel/harcuvar/acpi_tables.c +++ b/src/mainboard/intel/harcuvar/acpi_tables.c @@ -23,7 +23,7 @@ gnvs->tpmp = 0; }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; } diff --git a/src/mainboard/intel/strago/acpi_tables.c b/src/mainboard/intel/strago/acpi_tables.c index eec4790..8e26d3c 100644 --- a/src/mainboard/intel/strago/acpi_tables.c +++ b/src/mainboard/intel/strago/acpi_tables.c @@ -43,7 +43,7 @@ return current; }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_MOBILE; } diff --git a/src/mainboard/intel/wtm2/acpi_tables.c b/src/mainboard/intel/wtm2/acpi_tables.c index 6e56cf0..5c7e13e 100644 --- a/src/mainboard/intel/wtm2/acpi_tables.c +++ b/src/mainboard/intel/wtm2/acpi_tables.c @@ -35,7 +35,7 @@ return acpi_madt_irq_overrides(current); }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_MOBILE; } diff --git a/src/mainboard/ocp/tiogapass/acpi_tables.c b/src/mainboard/ocp/tiogapass/acpi_tables.c index 250ccad..85372e5 100644 --- a/src/mainboard/ocp/tiogapass/acpi_tables.c +++ b/src/mainboard/ocp/tiogapass/acpi_tables.c @@ -10,7 +10,7 @@ acpi_init_gnvs(gnvs); }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; } diff --git a/src/mainboard/portwell/m107/acpi_tables.c b/src/mainboard/portwell/m107/acpi_tables.c index 8492704..e98df14 100644 --- a/src/mainboard/portwell/m107/acpi_tables.c +++ b/src/mainboard/portwell/m107/acpi_tables.c @@ -38,7 +38,7 @@ return current; }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_MOBILE; fadt->iapc_boot_arch &= ~ACPI_FADT_8042; diff --git a/src/mainboard/protectli/vault_bsw/acpi_tables.c b/src/mainboard/protectli/vault_bsw/acpi_tables.c index 9ecb5ac..1724c71 100644 --- a/src/mainboard/protectli/vault_bsw/acpi_tables.c +++ b/src/mainboard/protectli/vault_bsw/acpi_tables.c @@ -28,7 +28,7 @@ return current; }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_MOBILE; fadt->iapc_boot_arch = ACPI_FADT_LEGACY_DEVICES; diff --git a/src/mainboard/scaleway/tagada/acpi_tables.c b/src/mainboard/scaleway/tagada/acpi_tables.c index e03ec0c..b939a81 100644 --- a/src/mainboard/scaleway/tagada/acpi_tables.c +++ b/src/mainboard/scaleway/tagada/acpi_tables.c @@ -23,7 +23,7 @@ gnvs->tpmp = 0; }
-void motherboard_fill_fadt(acpi_fadt_t *fadt) +void mainboard_fill_fadt(acpi_fadt_t *fadt) { fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; }
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42007 )
Change subject: acpi: Rename motherboard_fill_fadt() to mainboard_fill_fadt() ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/5275 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5274 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5273 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/5272
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)