Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42101 )
Change subject: vendorcode/amd: Clean up code smell ......................................................................
vendorcode/amd: Clean up code smell
Change-Id: I8a39e862176cd1c8a14424eb6d2bf7edabd36adb Found-by: Silvio Cesare, https://twitter.com/silviocesare/status/1268784333029965824 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuSrat.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42101/1
diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuSrat.c b/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuSrat.c index 9d6ca3d..2a935b2 100644 --- a/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuSrat.c +++ b/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuSrat.c @@ -226,7 +226,6 @@
// Get Node count NodeCount = 1; - NodeCount = 1;
// The worst-case buffer size to request is for the SRAT table header, one // entree for special region (base 640k block), two memory
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42101 )
Change subject: vendorcode/amd: Clean up code smell ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42101 )
Change subject: vendorcode/amd: Clean up code smell ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42101/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42101/1//COMMIT_MSG@7 PS1, Line 7: vendorcode/amd: Clean up code smell I’d prefer
Remove duplicate assignment
so it’s clear, that it’s not that bad.
https://review.coreboot.org/c/coreboot/+/42101/1/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuSrat.c:
https://review.coreboot.org/c/coreboot/+/42101/1/src/vendorcode/amd/agesa/f1... PS1, Line 228: NodeCount = 1; I wonder why it’s fixed to 1. In the older generation code, it’s determined from the system.
// Get Node count PciAddress.AddressValue = MAKE_SBDFO (0, 0, LOW_NODE_DEVICEID, FUNC_0, NodeID); LibAmdPciRead (AccessWidth32 , PciAddress, &RegVal, StdHeader); NodeCount = (UINT8) (((RegVal >> 4) & 0x7) + 1);
Hello build bot (Jenkins), Michał Żygowski, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42101
to look at the new patch set (#2).
Change subject: vendorcode/amd: Remove duplicate assignment ......................................................................
vendorcode/amd: Remove duplicate assignment
Change-Id: I8a39e862176cd1c8a14424eb6d2bf7edabd36adb Found-by: Silvio Cesare, https://twitter.com/silviocesare/status/1268784333029965824 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuSrat.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/42101/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42101 )
Change subject: vendorcode/amd: Remove duplicate assignment ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42101/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42101/1//COMMIT_MSG@7 PS1, Line 7: vendorcode/amd: Clean up code smell
I’d prefer […]
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42101 )
Change subject: vendorcode/amd: Remove duplicate assignment ......................................................................
vendorcode/amd: Remove duplicate assignment
Change-Id: I8a39e862176cd1c8a14424eb6d2bf7edabd36adb Found-by: Silvio Cesare, https://twitter.com/silviocesare/status/1268784333029965824 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42101 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuSrat.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuSrat.c b/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuSrat.c index 9d6ca3d..2a935b2 100644 --- a/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuSrat.c +++ b/src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuSrat.c @@ -226,7 +226,6 @@
// Get Node count NodeCount = 1; - NodeCount = 1;
// The worst-case buffer size to request is for the SRAT table header, one // entree for special region (base 640k block), two memory
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42101 )
Change subject: vendorcode/amd: Remove duplicate assignment ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42101/1/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuSrat.c:
https://review.coreboot.org/c/coreboot/+/42101/1/src/vendorcode/amd/agesa/f1... PS1, Line 228: NodeCount = 1;
I wonder why it’s fixed to 1. In the older generation code, it’s determined from the system. […]
Kabini only has one socket, it seems. The AGESA we have probably can't deal with more than one socket.
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42101 )
Change subject: vendorcode/amd: Remove duplicate assignment ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/5281 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5280 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/5279 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/5278
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)