[coreboot-gerrit] Change in coreboot[master]: vendorcode/amd: Clean up code smell

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42101 )

Change subject: vendorcode/amd: Clean up code smell
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42101/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42101/1//COMMIT_MSG@7 
PS1, Line 7: vendorcode/amd: Clean up code smell
I’d prefer
> Remove duplicate assignment

so it’s clear, that it’s not that bad.

https://review.coreboot.org/c/coreboot/+/42101/1/src/vendorcode/amd/agesa/f1... 
File src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuSrat.c:

https://review.coreboot.org/c/coreboot/+/42101/1/src/vendorcode/amd/agesa/f1... 
PS1, Line 228:   NodeCount = 1;
I wonder why it’s fixed to 1. In the older generation code, it’s determined from the system.

// Get Node count
    PciAddress.AddressValue = MAKE_SBDFO (0, 0, LOW_NODE_DEVICEID, FUNC_0, NodeID);
    LibAmdPciRead (AccessWidth32 , PciAddress, &RegVal, StdHeader);
    NodeCount = (UINT8) (((RegVal >> 4) & 0x7) + 1);