Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42101 )
Change subject: vendorcode/amd: Remove duplicate assignment
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42101/1/src/vendorcode/amd/agesa/f1...
File src/vendorcode/amd/agesa/f16kb/Proc/CPU/Feature/cpuSrat.c:
https://review.coreboot.org/c/coreboot/+/42101/1/src/vendorcode/amd/agesa/f1...
PS1, Line 228: NodeCount = 1;
I wonder why it’s fixed to 1. In the older generation code, it’s determined from the system. […]
Kabini only has one socket, it seems. The AGESA we have probably can't deal with more than one socket.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42101
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a39e862176cd1c8a14424eb6d2bf7edabd36adb
Gerrit-Change-Number: 42101
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 07 Jun 2020 23:13:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment